Skip to content

Generate valid ABI and Typechain for anticipated Diamond Cut #4

@cha0sg0d

Description

@cha0sg0d

The problems we have identified:

  1. If we have two functions with the same signature (example: initializePlayer in DFCore and initializePlayer in DFArena), we can't build the Diamond ABI due to the overlapping function check (strict = true).

  2. If we have two functions with the same name but different types, we have a problem with ethers where need to fetch the functions with await sampleContractEthers["overloading()"](); , which breaks most existing calls and tests that expect the standard sampleContractEthers.overloading() getter.

See #3 for proposed temporary solution.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions