Skip to content

Update for changes to google.appengine.api.memcache api changes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamiecollinson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update for changes to google.appengine.api.memcache api changes #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions gae_backends/memcache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@
Django Cache Backend for the Google App Engine
"""
import time
import logging

from django.core.cache.backends.base import BaseCache

from google.appengine.api import memcache

class MemcacheCache(BaseCache):

class MemcacheCache(BaseCache):
def __init__(self, location, params):
super(MemcacheCache, self).__init__(params)

Expand All @@ -18,7 +19,7 @@ def _get_memcache_timeout(self, timeout):
way. Call this function to obtain a safe value for your timeout.
"""
timeout = timeout or self.default_timeout
if timeout > 2592000: # 60*60*24*30, 30 days
if timeout > 2592000: # 60*60*24*30, 30 days
# See http://code.google.com/p/memcached/wiki/FAQ
# "You can set expire times up to 30 days in the future. After that
# memcached interprets it as a date, and will expire the item after
Expand All @@ -29,7 +30,10 @@ def _get_memcache_timeout(self, timeout):
return timeout

def add(self, key, value, timeout=None, version=None):
return memcache.add(key, value, timeout=None, version=None)
key = self.make_key(key, version=version)
self.validate_key(key)

return memcache.add(key, value, self._get_memcache_timeout(timeout))

def get(self, key, default=None, version=None):
key = self.make_key(key, version=version)
Expand Down Expand Up @@ -71,7 +75,10 @@ def set(self, key, value, timeout=None, version=None):
key = self.make_key(key, version=version)
self.validate_key(key)

memcache.set(key, value, self._get_memcache_timeout(timeout))
try:
memcache.set(key, value, self._get_memcache_timeout(timeout))
except:
logging.warning('Could not save response in memcache - too large')

def delete(self, key, version=None):
key = self.make_key(key, version=version)
Expand All @@ -91,7 +98,8 @@ def delete_many(self, keys, version=None):
memcache.delete_multi(map(l, keys))

def clear(self):
return memcache.flush_all()
return memcache.flush_all()


# For backwards compatibility
class CacheClass(MemcacheCache):
Expand Down