Skip to content

Commit 974f7bb

Browse files
committed
troubleshoot build workflow
1 parent 54a90c6 commit 974f7bb

3 files changed

Lines changed: 13 additions & 8 deletions

File tree

.github/workflows/build.yml

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ jobs:
1818
run: |
1919
wget https://github.com/mmadfox/go-crx3/releases/download/v1.6.0/go-crx3_1.6.0_linux_amd64.tar.gz
2020
tar xvf go-crx3_1.6.0_linux_amd64.tar.gz
21-
chmod +x go-crx3 && mv go-crx3 $HOME/.local/bin/
21+
chmod +x go-crx3
22+
mv go-crx3 /usr/local/bin/
2223
- name: build extension
2324
run: make build-chrome
2425
- name: upload artifacts
@@ -30,14 +31,18 @@ jobs:
3031
build_firefox:
3132
name: build firefox addon
3233
runs-on: ubuntu-latest
34+
env:
35+
AMO_JWT_ISSUER: ${{ secrets.AMO_JWT_ISSUER }}
36+
AMO_JWT_SECRET: ${{ secrets.AMO_JWT_SECRET }}
3337
steps:
3438
- name: git checkout
3539
uses: actions/checkout@v4
3640
- name: setup go-crx3
3741
run: |
3842
wget https://github.com/mmadfox/go-crx3/releases/download/v1.6.0/go-crx3_1.6.0_linux_amd64.tar.gz
3943
tar xvf go-crx3_1.6.0_linux_amd64.tar.gz
40-
chmod +x go-crx3 && mv go-crx3 $HOME/.local/bin/
44+
chmod +x go-crx3
45+
mv go-crx3 /usr/local/bin/
4146
- name: build addon
4247
run: make build-firefox
4348
- name: setup node
@@ -47,20 +52,20 @@ jobs:
4752
- name: install web-ext
4853
run: npm i -g web-ext
4954
- name: sign with AMO (if secrets provided)
50-
if: ${{ secrets.AMO_JWT_ISSUER && secrets.AMO_JWT_SECRET }}
55+
if: ${{ env.AMO_JWT_ISSUER != '' && env.AMO_JWT_SECRET != '' }}
5156
env:
5257
WEB_EXT_API_KEY: ${{ secrets.AMO_JWT_ISSUER }}
5358
WEB_EXT_API_SECRET: ${{ secrets.AMO_JWT_SECRET }}
5459
run: |
5560
web-ext sign \
56-
--api-key "$WEB_EXT_API_KEY" \
57-
--api-secret "$WEB_EXT_API_SECRET" \
61+
--api-key "$AMO_JWT_ISSUER" \
62+
--api-secret "$AMO_JWT_SECRET" \
5863
--channel listed
5964
--id sanitize-amazon@devloberto \
6065
--source-dir . \
6166
--artifacts-dir ./web-ext-artifacts
6267
- name: upload signed crx artifact
63-
if: ${{ secrets.AMO_JWT_ISSUER && secrets.AMO_JWT_SECRET }}
68+
if: ${{ env.AMO_JWT_ISSUER != '' && env.AMO_JWT_SECRET != '' }}
6469
uses: actions/upload-artifact@v4
6570
with:
6671
name: ${{ env.ARTIFACT_NAME }}_firefox

manifest.chrome.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"manifest_version": 3,
33
"name": "Sanitize Amazon",
4-
"version": "1.0",
4+
"version": "1.0.1",
55
"permissions": [
66
"contextMenus",
77
"activeTab"

manifest.firefox.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"manifest_version": 2,
33
"name": "Sanitize Amazon",
4-
"version": "1.0",
4+
"version": "1.0.1",
55
"permissions": [
66
"contextMenus",
77
"activeTab",

0 commit comments

Comments
 (0)