Skip to content

Commit 7dbcff3

Browse files
committed
refactor(HarRecorder): rename clear() to reset()
Rename clear() method to reset() for clearer semantics.
1 parent ac108e1 commit 7dbcff3

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/HarRecorder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ public function getHar(): Har
7878
}
7979

8080
/**
81-
* Clear all recorded entries.
81+
* Reset and clear all recorded entries.
8282
*/
83-
public function clear(): void
83+
public function reset(): void
8484
{
8585
$this->entries = [];
8686
}

tests/src/Unit/HarRecorderTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ public function testFailedRequestIsNotRecorded(): void
272272
$this->assertEmpty($recorder->getHar()->getLog()->getEntries());
273273
}
274274

275-
public function testClearRemovesAllEntries(): void
275+
public function testResetRemovesAllEntries(): void
276276
{
277277
$innerClient = $this->createMock(ClientInterface::class);
278278
$innerClient->method('sendRequest')->willReturn(new Response(200));
@@ -283,7 +283,7 @@ public function testClearRemovesAllEntries(): void
283283

284284
$this->assertCount(2, $recorder->getHar()->getLog()->getEntries());
285285

286-
$recorder->clear();
286+
$recorder->reset();
287287

288288
$this->assertEmpty($recorder->getHar()->getLog()->getEntries());
289289
}

0 commit comments

Comments
 (0)