From 5eec4e819a7bfde4ace52393fba26385c0a9ba42 Mon Sep 17 00:00:00 2001 From: Olaf Veerman Date: Mon, 21 Jul 2025 10:48:17 +0100 Subject: [PATCH 1/4] Ignore React not in scope --- eslint.config.mjs | 1 + 1 file changed, 1 insertion(+) diff --git a/eslint.config.mjs b/eslint.config.mjs index e60f045..abd8d51 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -25,6 +25,7 @@ export default [ 'prefer-promise-reject-errors': 0, // 'import/order': 2, 'react/button-has-type': 2, + 'react/react-in-jsx-scope': 0, 'react/jsx-closing-bracket-location': 2, 'react/jsx-closing-tag-location': 2, 'react/jsx-curly-spacing': 2, From 0008e9f10891d27541eac0ccb4173ddb9e96538f Mon Sep 17 00:00:00 2001 From: Olaf Veerman Date: Mon, 21 Jul 2025 15:14:04 +0100 Subject: [PATCH 2/4] Don't print NODE version in checks env.NODE is not available, nor necessary. The node version is printed in the step details. --- .github/workflows/checks.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 4252779..560e41a 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -33,7 +33,7 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - - name: Use Node.js ${{ env.NODE }} + - name: Use Node.js uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' @@ -60,7 +60,7 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - - name: Use Node.js ${{ env.NODE }} + - name: Use Node.js uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' @@ -90,7 +90,7 @@ jobs: - name: Install pnpm uses: pnpm/action-setup@v4 - - name: Use Node.js ${{ env.NODE }} + - name: Use Node.js uses: actions/setup-node@v4 with: node-version-file: '.nvmrc' @@ -107,4 +107,4 @@ jobs: run: pnpm install - name: Test - run: pnpm test \ No newline at end of file + run: pnpm test From 9c0decf4dc4bc27864127b8d18f9987268a7febb Mon Sep 17 00:00:00 2001 From: Olaf Veerman Date: Mon, 21 Jul 2025 15:18:21 +0100 Subject: [PATCH 3/4] Remove unused baseName Not used + trips up linter --- app/main.tsx | 6 ------ 1 file changed, 6 deletions(-) diff --git a/app/main.tsx b/app/main.tsx index 0299816..2ceda18 100644 --- a/app/main.tsx +++ b/app/main.tsx @@ -6,12 +6,6 @@ import system from './styles/theme'; // If using a router add the public url to the base path. const publicUrl = import.meta.env.VITE_BASE_URL || ''; -// The ds.io prefix is used just to get the base path when no public url is set. -const baseName = new URL( - publicUrl.startsWith('http') - ? publicUrl - : `https://ds.io/${publicUrl.replace(/^\//, '')}` - ).pathname; // Root component. function Root() { From d97b8684c7832142edac9b80f9bb68c74cbea0a4 Mon Sep 17 00:00:00 2001 From: Olaf Veerman Date: Mon, 21 Jul 2025 15:22:43 +0100 Subject: [PATCH 4/4] Comment unused variables --- app/main.tsx | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/app/main.tsx b/app/main.tsx index 2ceda18..6fba732 100644 --- a/app/main.tsx +++ b/app/main.tsx @@ -4,8 +4,15 @@ import { createRoot } from 'react-dom/client'; import system from './styles/theme'; -// If using a router add the public url to the base path. -const publicUrl = import.meta.env.VITE_BASE_URL || ''; +// // If using a router add the public url to the base path. +// const publicUrl = import.meta.env.VITE_BASE_URL || ''; + +// // The ds.io prefix is used just to get the base path when no public url is set. +// const baseName = new URL( +// publicUrl.startsWith('http') +// ? publicUrl +// : `https://ds.io/${publicUrl.replace(/^\//, '')}` +// ).pathname; // Root component. function Root() {