From b5b3a2874f7a5476b1c0faae2a107ba0612b0375 Mon Sep 17 00:00:00 2001 From: Garry Trinder Date: Fri, 27 Jun 2025 16:54:41 +0100 Subject: [PATCH 1/2] Increment version to 0.26.3 --- CHANGELOG.md | 1 + package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index db1b226..e51f15b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). > **Note**: odd version numbers, for example, `0.13.0`, are not included in this changelog. They are used to test the new features and fixes before the final release. +## [0.26.3] - 2025-06-27 ## [0.26.2] - 2025-06-27 diff --git a/package-lock.json b/package-lock.json index 0748de0..f624f7e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "dev-proxy-toolkit", - "version": "0.26.2", + "version": "0.26.3", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "dev-proxy-toolkit", - "version": "0.26.2", + "version": "0.26.3", "dependencies": { "json-to-ast": "2.1.0", "semver": "7.7.2" diff --git a/package.json b/package.json index b37e7ee..6bdb5f0 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "dev-proxy-toolkit", "displayName": "Dev Proxy Toolkit", "description": "Makes it easy to create and update Dev Proxy configuration files.", - "version": "0.26.2", + "version": "0.26.3", "publisher": "garrytrinder", "engines": { "vscode": "^1.101.0" From cb053350e1532e4ef9a81f550a9b6e5645498f21 Mon Sep 17 00:00:00 2001 From: Garry Trinder Date: Fri, 27 Jun 2025 16:54:56 +0100 Subject: [PATCH 2/2] Fix upgrade command. Closes #293 Closes #293 --- CHANGELOG.md | 5 +++++ src/helpers.ts | 7 ++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e51f15b..cae0421 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,8 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). > **Note**: odd version numbers, for example, `0.13.0`, are not included in this changelog. They are used to test the new features and fixes before the final release. + ## [0.26.3] - 2025-06-27 +### Fixed: + +- Commands: Fixed issue where brew update output would be shown in a notification when upgrading Dev Proxy via homebrew + ## [0.26.2] - 2025-06-27 ### Changed: diff --git a/src/helpers.ts b/src/helpers.ts index f89388c..5185404 100644 --- a/src/helpers.ts +++ b/src/helpers.ts @@ -122,10 +122,11 @@ export const executeCommand = async (cmd: string, options: ExecOptions = {}): Pr return new Promise((resolve, reject) => { exec(cmd, options, (error, stdout, stderr) => { if (error) { - reject(`exec error: ${error}`); - } else if (stderr) { - reject(`stderr: ${stderr}`); + // Command failed with non-zero exit code + reject(`exec error: ${error}${stderr ? `\nstderr: ${stderr}` : ''}`); } else { + // Command succeeded (exit code 0), return stdout + // Note: Many tools like brew send informational messages to stderr even on success resolve(stdout); } });