From 6c34b96ec2eb0e34fe0680a9f248e3891d520feb Mon Sep 17 00:00:00 2001 From: Garry Trinder Date: Tue, 4 Mar 2025 13:54:32 +0000 Subject: [PATCH 1/2] Bump version to 0.19.0 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 166d0cf..de15438 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "dev-proxy-toolkit", - "version": "0.18.3", + "version": "0.19.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "dev-proxy-toolkit", - "version": "0.18.3", + "version": "0.19.0", "dependencies": { "json-to-ast": "^2.1.0" }, diff --git a/package.json b/package.json index 1ccb8e8..7cf12bb 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "dev-proxy-toolkit", "displayName": "Dev Proxy Toolkit", "description": "Makes it easy to create and update Dev Proxy configuration files.", - "version": "0.18.3", + "version": "0.19.0", "publisher": "garrytrinder", "engines": { "vscode": "^1.89.0" From 9e6ca1d635a7cc8df8a28ef20a03ff856c19992f Mon Sep 17 00:00:00 2001 From: Garry Trinder Date: Tue, 4 Mar 2025 13:55:01 +0000 Subject: [PATCH 2/2] Refactor stop command logic for improved proxy status handling. Closes #207 Closes #207 --- CHANGELOG.md | 6 ++++++ src/commands.ts | 16 ++++++++++------ 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4aa29c2..e606379 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 > **Note**: odd version numbers, for example, `0.13.0`, are not included in this changelog. They are used to test the new features and fixes before the final release. +## [0.19.0] - Unreleased + +### Changed: + +- Commands: Refactored stop command logic + ## [0.18.3] - 2025-03-03 ### Added: diff --git a/src/commands.ts b/src/commands.ts index c8aa254..b960754 100644 --- a/src/commands.ts +++ b/src/commands.ts @@ -122,13 +122,17 @@ export const registerCommands = (context: vscode.ExtensionContext, configuration } }; - let isRunning = true; - while (isRunning) { - isRunning = await checkProxyStatus(); - if (isRunning) { - await new Promise(resolve => setTimeout(resolve, 1000)); + const waitForProxyToStop = async () => { + let isRunning = true; + while (isRunning) { + isRunning = await checkProxyStatus(); + if (isRunning) { + await new Promise(resolve => setTimeout(resolve, 1000)); + } } - } + }; + + await waitForProxyToStop(); vscode.window.terminals.forEach(terminal => { if (terminal.name === 'Dev Proxy') {