From bdd3c94f68ba794835cbbe2d9e0935c925f90173 Mon Sep 17 00:00:00 2001 From: deraldosp <38322215+deraldosp@users.noreply.github.com> Date: Mon, 4 Apr 2022 10:59:41 -0300 Subject: [PATCH 1/6] Improve CI --- .github/workflows/node.js.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index c65dfbf..49ec312 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -16,7 +16,7 @@ jobs: strategy: matrix: - node-version: [12.x, 14.x, 16.x] + node-version: [12.x, 14.x] # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ steps: From 57ab1e72ea2adbec427a1b96b4af17ec96c37acf Mon Sep 17 00:00:00 2001 From: deraldosp <38322215+deraldosp@users.noreply.github.com> Date: Mon, 4 Apr 2022 11:02:17 -0300 Subject: [PATCH 2/6] Update .github/workflows/node.js.yml Co-authored-by: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com> --- .github/workflows/node.js.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 49ec312..2978b29 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -16,6 +16,7 @@ jobs: strategy: matrix: + os: [ubuntu-latest, windows-2016] node-version: [12.x, 14.x] # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ From 6dad3fe27442361ff2ea5c4b4789a050cdb70de2 Mon Sep 17 00:00:00 2001 From: deraldosp <38322215+deraldosp@users.noreply.github.com> Date: Mon, 4 Apr 2022 11:11:48 -0300 Subject: [PATCH 3/6] Improve CI with build and test separataly --- .github/workflows/node.js.yml | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 2978b29..1a0f372 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -10,23 +10,32 @@ on: branches: [ main ] jobs: - build: + build: runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: npm install and build webpack + run: | + npm install + npm run build + test: + runs-on: ubuntu-latest strategy: matrix: os: [ubuntu-latest, windows-2016] node-version: [12.x, 14.x] - # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ - steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} - cache: 'npm' - - run: npm ci - - run: npm run build --if-present - - run: npm test + - name: npm install, and test + run: | + npm install + npm test + env: + CI: true + From dc822f8ce0c47e8f36e26006712f8a8f008260ee Mon Sep 17 00:00:00 2001 From: deraldosp <38322215+deraldosp@users.noreply.github.com> Date: Mon, 4 Apr 2022 11:16:30 -0300 Subject: [PATCH 4/6] Update node.js.yml --- .github/workflows/node.js.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 1a0f372..2cea5aa 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -19,6 +19,10 @@ jobs: run: | npm install npm run build + - uses: actions/upload-artifact@main + with: + name: webpack artifacts + path: public/ test: runs-on: ubuntu-latest From cf6c4effb4ef8c7cbd346bb6594f75053c8e692d Mon Sep 17 00:00:00 2001 From: deraldosp <38322215+deraldosp@users.noreply.github.com> Date: Mon, 4 Apr 2022 11:19:06 -0300 Subject: [PATCH 5/6] Update .github/workflows/node.js.yml Co-authored-by: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com> --- .github/workflows/node.js.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 2cea5aa..3d67027 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -24,7 +24,10 @@ jobs: name: webpack artifacts path: public/ - test: + - uses: actions/upload-artifact@master + with: + name: webpack artifacts + path: public/ runs-on: ubuntu-latest strategy: matrix: From a9d83d29d908790f1e561543743797fb5d4faa0d Mon Sep 17 00:00:00 2001 From: deraldosp <38322215+deraldosp@users.noreply.github.com> Date: Mon, 4 Apr 2022 11:19:27 -0300 Subject: [PATCH 6/6] Update .github/workflows/node.js.yml Co-authored-by: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com> --- .github/workflows/node.js.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 3d67027..288e390 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -22,7 +22,7 @@ jobs: - uses: actions/upload-artifact@main with: name: webpack artifacts - path: public/ + needs: build - uses: actions/upload-artifact@master with: