Skip to content

remove global imports of numpy etc. #9

@demisjohn

Description

@demisjohn

From @demisjohn on February 28, 2018 9:38

the module repeatedly calls from numpy import *, which, aside from being bad practice, actually has stomped on one of it's own functions.

The camfr function full(), as in set_mode_correct(full), has been replaced by numpy.full() (which presumably didn't exist in ~2005). This now pops an error.

    set_mode_correction(full)
Boost.Python.ArgumentError: Python argument types in
    camfr._camfr.set_mode_correction(function)
did not match C++ signature:
    set_mode_correction(Mode_correction)

Must go thru the python files and replace the import statement with import numpy as np and go through to prepend all numpy functions with np.!

Copied from original issue: #5

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions