diff --git a/vane/database.py b/vane/database.py index d83959e..503b26a 100644 --- a/vane/database.py +++ b/vane/database.py @@ -124,7 +124,29 @@ def save_data_to_archive_file(self, data, filename): def extract_downloaded_files(self, archive_filename): with tarfile.open(archive_filename, 'r:gz', errorlevel=1) as archive: - archive.extractall(re.sub("\.tar\.gz$", "", archive_filename)) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(archive, re.sub("\.tar\.gz$","",archive_filename)) def cleanup_archive_file(self, archive_filename): remove(archive_filename)