Warnings when compiling in C

[memononen]

I'm using the bindings directly for a C project, and I'm getting a bunch of warnings due to mixed enums, something like this:

5>dcimgui_internal.h(1030,320): Warning C5287 : operands are different enum types 'ImGuiHoveredFlags_' and '<unnamed-enum-ImGuiHoveredFlags_DelayMask_>'; use an explicit cast to silence this warning
(compiling source file '../../src/imgui_utils.c')

Casting via int does not seem to work in this case, but casting via unsigned works. I think this coult be partially a MSVC issue:
https://developercommunity.microsoft.com/t/warning-C5287:-operands-are-different-e/10877942

Another warning I'm hitting is redefinition of IMGUI_VERSION and IMGUI_VERSION_NUM. This happens when both the dcimgui.h and imgui.h are included in the cpp wrapper files.

4>dcimgui.h(36,9): Warning C4005 : 'IMGUI_VERSION': macro redefinition
(compiling source file '../_deps/dcimgui_external-src/backends/dcimgui_impl_opengl3.cpp')
    C:\Users\memon\code\array_merge\build\_deps\imgui_external-src\imgui.h(32,9):
    see previous definition of 'IMGUI_VERSION'

4>dcimgui.h(37,9): Warning C4005 : 'IMGUI_VERSION_NUM': macro redefinition
(compiling source file '../_deps/dcimgui_external-src/backends/dcimgui_impl_opengl3.cpp')
    C:\Users\memon\code\array_merge\build\_deps\imgui_external-src\imgui.h(33,9):
    see previous definition of 'IMGUI_VERSION_NUM'

The define could be fixed by either #undef or #ifndef, but not sure which one makes sense here.

I try to see if I can get the generation process going and try to make PR for the fixes.

MSBuild version 17.14.23+b0019275e
Microsoft (R) C/C++ Optimizing Compiler Version 19.44.35222 for x64

[memononen]

Looks like there are int casts in ImGuiDockNodeFlagsPrivate_ for enums in the docking branch, but one is missing, and I also get complaints in ImGuiHoveredFlagsPrivate_ and ImGuiInputFlagsPrivate_, which dont have any casts.

With the following changes, I get things to compile without warnings (sans mine :)):

dcimgui.h

#undef IMGUI_VERSION
#undef IMGUI_VERSION_NUM
#define IMGUI_VERSION       "1.92.7 WIP"
#define IMGUI_VERSION_NUM   19262

dcimgui_internal.h

typedef enum
{
	...
    ImGuiHoveredFlags_AllowedMaskForIsItemHovered   = ImGuiHoveredFlags_AllowWhenBlockedByPopup | ImGuiHoveredFlags_AllowWhenBlockedByActiveItem | ImGuiHoveredFlags_AllowWhenOverlapped | ImGuiHoveredFlags_AllowWhenDisabled | ImGuiHoveredFlags_NoNavOverride | ImGuiHoveredFlags_ForTooltip | ImGuiHoveredFlags_Stationary | (unsigned)ImGuiHoveredFlags_DelayMask_,
} ImGuiHoveredFlagsPrivate_;

typedef enum
{
	...
    ImGuiInputFlags_RepeatMask_                      = (unsigned)ImGuiInputFlags_Repeat | ImGuiInputFlags_RepeatRateMask_ | ImGuiInputFlags_RepeatUntilMask_,
	...
    ImGuiInputFlags_SupportedBySetNextItemShortcut   = ImGuiInputFlags_RepeatMask_ | ImGuiInputFlags_RouteTypeMask_ | ImGuiInputFlags_RouteOptionsMask_ | (unsigned)ImGuiInputFlags_Tooltip,
} ImGuiInputFlagsPrivate_;



typedef enum
{
	...
    ImGuiDockNodeFlags_NoDocking                 = ImGuiDockNodeFlags_NoDockingOverMe | ImGuiDockNodeFlags_NoDockingOverOther | ImGuiDockNodeFlags_NoDockingOverEmpty | (unsigned)ImGuiDockNodeFlags_NoDockingSplit | ImGuiDockNodeFlags_NoDockingSplitOther,
	...
    ImGuiDockNodeFlags_NoResizeFlagsMask_        = (unsigned)ImGuiDockNodeFlags_NoResize | ImGuiDockNodeFlags_NoResizeX | ImGuiDockNodeFlags_NoResizeY,
	...
    ImGuiDockNodeFlags_LocalFlagsTransferMask_   = (unsigned)ImGuiDockNodeFlags_NoDockingSplit | ImGuiDockNodeFlags_NoResizeFlagsMask_ |(int)ImGuiDockNodeFlags_AutoHideTabBar | ImGuiDockNodeFlags_CentralNode | ImGuiDockNodeFlags_NoTabBar | ImGuiDockNodeFlags_HiddenTabBar | ImGuiDockNodeFlags_NoWindowMenuButton | ImGuiDockNodeFlags_NoCloseButton,
	...
} ImGuiDockNodeFlagsPrivate_;

Not sure how to proceed, should I try to make PR for the main dear imgui repo?

I think the (int) cast not working is MSVC bug. I updated to the latest 2022 version via installer, but it does not seem to be fixed yet.

MSBuild version 17.14.40+3e7442088 for .NET Framework
Microsoft (R) C/C++ Optimizing Compiler Version 19.44.35224 for x64