Deprecation warnings in the 'network' package

[chris-martin]

Network/Socket/Activation.hs:83:14: warning: [-Wdeprecations]                            
    In the use of ‘unpackFamily’                                                         
    (imported from Network.Socket, but defined in network-2.7.0.0:Network.Socket.Types): 
    Deprecated: "unpackFamily will not be available in version 3.0.0.0 or later."        
   |                                                                                     
83 |     return $ unpackFamily familyInt                                                 
   |              ^^^^^^^^^^^^                                                           
                                                                                         
Network/Socket/Activation.hs:97:35: warning: [-Wdeprecations]                            
    In the use of type constructor or class ‘SocketStatus’                               
    (imported from Network.Socket, but defined in network-2.7.0.0:Network.Socket.Types): 
    Deprecated: "SocketStatus will be removed"                                           
   |                                                                                     
97 | socketStatus :: CInt -> MaybeT IO SocketStatus                                      
   |                                   ^^^^^^^^^^^^                                      
                                                                                         
Network/Socket/Activation.hs:101:19: warning: [-Wdeprecations]                           
    In the use of data constructor ‘Bound’                                               
    (imported from Network.Socket, but defined in network-2.7.0.0:Network.Socket.Types): 
    Deprecated: "SocketStatus will be removed"                                           
    |                                                                                    
101 |       0 -> return Bound                                                            
    |                   ^^^^^                                                            
                                                                                         
Network/Socket/Activation.hs:102:27: warning: [-Wdeprecations]                           
    In the use of data constructor ‘Listening’                                           
    (imported from Network.Socket, but defined in network-2.7.0.0:Network.Socket.Types): 
    Deprecated: "SocketStatus will be removed"                                           
    |                                                                                    
102 |       x | x > 0 -> return Listening                                                
    |                           ^^^^^^^^^                                                

I'm not sure why these things are deprecated; I've raised an issue to ask. haskell/network#324

[ddfisher]

Thanks for looking into this! Interested to see what the network folks say.

[chris-martin]

Okay so they're going to un-deprecate unpackFamily.

I think this is moot anyway, though. network 3 is going to change mkSocket to

-- | Creating a socket from a file descriptor.
mkSocket :: CInt -> IO Socket

so looks like a lot of the code in Network.Socket.Activation just won't be needed anymore.