Relax requirements baseSym != nullptr for lvalue

Author: aneshlya

src/expr.cpp

@@ -4911,11 +4911,6 @@ llvm::Value *IndexExpr::GetValue(FunctionEmitContext *ctx) const {
         mask = LLVMMaskAllOn;
     } else {
         Symbol *baseSym = GetBaseSymbol();
-        if (llvm::dyn_cast<FunctionCallExpr>(baseExpr) == nullptr && llvm::dyn_cast<BinaryExpr>(baseExpr) == nullptr &&
-            llvm::dyn_cast<SelectExpr>(baseExpr) == nullptr) {
-            // Don't check if we're doing a function call or pointer arith or select
-            AssertPos(pos, baseSym != nullptr);
-        }
         mask = lMaskForSymbol(baseSym, ctx);
     }
 
@@ -5815,11 +5810,6 @@ llvm::Value *MemberExpr::GetValue(FunctionEmitContext *ctx) const {
         mask = LLVMMaskAllOn;
     } else {
         Symbol *baseSym = GetBaseSymbol();
-        if (llvm::dyn_cast<FunctionCallExpr>(expr) == nullptr && llvm::dyn_cast<BinaryExpr>(expr) == nullptr &&
-            llvm::dyn_cast<SelectExpr>(expr) == nullptr && llvm::dyn_cast<PtrDerefExpr>(expr) == nullptr) {
-            // Don't check if we're doing a function call or pointer arith or select
-            AssertPos(pos, baseSym != nullptr);
-        }
         mask = lMaskForSymbol(baseSym, ctx);
     }
 

tests/lit-tests/2496.ispc

@@ -1,17 +1,23 @@
 // This test checks that there is no ICE on the following code.
-// RUN: %{ispc} %s -o %t.o --target=host --nostdlib --nowrap 2>&1 | FileCheck %s
 
-// CHECK-NOT: FATAL ERROR:
+// RUN: %{ispc} --target=host --nowrap --nostdlib --emit-llvm-text --debug-phase=210:210 %s -o - | FileCheck %s
+
+// CHECK-NOT: FATAL ERROR: Unhandled signal sent to process
 struct S {
     uint32 a;
 };
 
 S v;
 
-void foo1(int i) {
-    uint32 a = ((S*)(&v) + i)->a;
+// CHECK-LABEL: @foo1
+// CHECK: __pseudo_gather64_i32
+// CHECK: __pseudo_masked_store_i32
+uint32 foo1(int i) {
+    return ((S*)(&v) + i)->a;
 }
-
-void foo2(int i) {
-    uint32 a = (*((S*)(&v) + i)).a;
+// CHECK-LABEL: @foo2
+// CHECK: __pseudo_gather64_i32
+// CHECK: __pseudo_masked_store_i32
+uint32 foo2(int i) {
+    return (*((S*)(&v) + i)).a;
 }

tests/lit-tests/2583.ispc

@@ -0,0 +1,13 @@
+// RUN: %{ispc} %s -o %t.o --target=host --nostdlib --nowrap 2>&1 | FileCheck %s --allow-empty
+
+// CHECK-NOT: FATAL ERROR: Unhandled signal sent to process
+task void sum_M_float_task(uniform float v_out[], uniform float M[], uniform int M_pitch, uniform int N,
+                      uniform int chunk_size) {
+    uniform int col = taskIndex0 * chunk_size;
+
+    uniform float *v_out_chunked = new float[chunk_size];
+
+    foreach (row = 0 ... N) {
+        v_out[row] = ((uniform float *)((uniform int8 *)M + col * M_pitch))[row];
+    }
+}