Error when building: No overloaded function takes 2 arguments

[110Percent]

Hello!

I'm having trouble building this module with node-gyp. When I run the build command, I get this error:

d:\users\curtis\documents\winctl\src\winctlwindow.cc(50): error C2661: 'v8 ::Function::NewInstance': no overloaded function takes 2 arguments [D:\Users\Curtis\Documents\winctl\build\winctl.vcxproj]

I've tried looking through the source files to see what the issue could be, but I'm at a loss. Do you happen to know what's going on?

node-gyp@3.7.0, node@10.5.0 | win32 | x64, msvs_version=2015

[MingqianYang]

I have the same problem with you.
Have you solved it?

[lusentis]

Probably a breaking change in node@10? 😢

No idea what I'm doing, but, if you remove this else block, it will compile (and works perfectly in my case):
https://github.com/thraaawn/winctl/blob/master/src/WinCtlWindow.cc#L46

But, again, I have no idea what the else is for, so probably we're not supposed to randomly delete code ✋