From 0b0cd7e31397d0959ca86728988bb173f926f7fc Mon Sep 17 00:00:00 2001
From: Jose Szychowski <joseszychowski@gmail.com>
Date: Thu, 6 Nov 2025 14:53:59 -0300
Subject: [PATCH] refactor: update ContactSpec fields to optional

---
 .../notification/notification.miloapis.com_contacts.yaml      | 2 --
 docs/api/notification.md                                      | 4 ++--
 pkg/apis/notification/v1alpha1/contact_types.go               | 4 ++--
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/config/crd/bases/notification/notification.miloapis.com_contacts.yaml b/config/crd/bases/notification/notification.miloapis.com_contacts.yaml
index a915fd3a..39aebffd 100644
--- a/config/crd/bases/notification/notification.miloapis.com_contacts.yaml
+++ b/config/crd/bases/notification/notification.miloapis.com_contacts.yaml
@@ -91,8 +91,6 @@ spec:
                 type: object
             required:
             - email
-            - familyName
-            - givenName
             type: object
           status:
             properties:
diff --git a/docs/api/notification.md b/docs/api/notification.md
index 224b9267..51005065 100644
--- a/docs/api/notification.md
+++ b/docs/api/notification.md
@@ -857,14 +857,14 @@ ContactSpec defines the desired state of Contact.
         <td>
           <br/>
         </td>
-        <td>true</td>
+        <td>false</td>
       </tr><tr>
         <td><b>givenName</b></td>
         <td>string</td>
         <td>
           <br/>
         </td>
-        <td>true</td>
+        <td>false</td>
       </tr><tr>
         <td><b><a href="#contactspecsubject">subject</a></b></td>
         <td>object</td>
diff --git a/pkg/apis/notification/v1alpha1/contact_types.go b/pkg/apis/notification/v1alpha1/contact_types.go
index 681a8baf..4637e041 100644
--- a/pkg/apis/notification/v1alpha1/contact_types.go
+++ b/pkg/apis/notification/v1alpha1/contact_types.go
@@ -61,10 +61,10 @@ type ContactSpec struct {
 	// +kubebuilder:validation:Optional
 	SubjectRef *SubjectReference `json:"subject,omitempty"`
 
-	// +kubebuilder:validation:Required
+	// +kubebuilder:validation:Optional
 	FamilyName string `json:"familyName,omitempty"`
 
-	// +kubebuilder:validation:Required
+	// +kubebuilder:validation:Optional
 	GivenName string `json:"givenName,omitempty"`
 
 	// +kubebuilder:validation:Required