Tap_Settings TABLE_NAME filter is ignored

[alvin-mwangi]

Passing in a comma-separated list of tables via tap_settings[“TABLE_NAME”] should cause tapdance to sync only the tables specified. However, the current behavior is that this filter gets ignored and it instead uses the default value of “*”, which syncs all the tables.

I suspect the issue is on line 111 in syncs.py which currently checks the table_name variable first before looking at tap_settings[“TABLE_NAME”]. If they’re both populated (with a truthy value), the OR condition will return the value from table_name.

[alvin-mwangi]

Confirmed during testing that passing in table_name=None as an argument when calling the sync function produces the expected behavior. It correctly uses the tap_settings “TABLE_NAME” as the filter when we pass that in. Otherwise, it returns None as the filter, which causes get_table_list to fetch all the tables into list_of_tables.

Perhaps the default for table_name should be changed to None?

[aaronsteers]

@alvin-mwangi - Thanks for reporting this - and nice work finding the root cause and fix! For my part, I've reviewed the code in question and I agree with you analysis and proposod fix.

Would you be comfortable submitting a PR with the proposed change? (I haven't thoroughly reviewed the downstreams but it might be as simple as changing the default for this arg.)

@jtimeus-slalom is also an admin on this repo so either of us can approve your change when it comes through.