Skip to content

Commit 2f38ebd

Browse files
fjakobsclaudeilia-db
authored
Use public @databricks/sdk-experimental package (#1805)
## Summary Replace custom SDK download scripts with the public `@databricks/sdk-experimental` npm package (v0.14.2). This simplifies the build process and ensures users get official SDK updates through npm. ## Changes - bumped minimal VS Code version to `1.101` because we need node.js 22. - Updated `package.json` files to use `@databricks/sdk-experimental` instead of `file:../../vendor/databricks-sdk.tgz` - Removed SDK download scripts (`install_sdk.sh` and `fetch:sdk` npm script) - Removed `vendor` directory - Updated all imports from `@databricks/databricks-sdk` to `@databricks/sdk-experimental` - Fixed test mocks to work with new SDK API (request method signature changed from 4 positional params to single options object) - Added `@types/ini` dependency ## Test plan - ✅ All unit tests pass - ✅ Linting and formatting checks pass - 🔄 CI checks will validate the changes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Ilia Babanov <ilia.babanov@databricks.com>
1 parent 0c0c60d commit 2f38ebd

File tree

94 files changed

+358
-310
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

94 files changed

+358
-310
lines changed

package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@
99
"hoistingLimits": "dependencies"
1010
},
1111
"engines": {
12-
"node": ">=16.0",
12+
"node": ">=22.0",
1313
"yarn": ">=3.2.0"
1414
},
1515
"scripts": {
16-
"install:sdk": "yarn fetch:sdk && chmod a+x scripts/install_sdk.sh && scripts/install_sdk.sh",
17-
"fetch:sdk": "rm -rf vendor && mkdir vendor && gh release download -R databricks/databricks-sdk-js v0.10.0 -p '*.tgz' && mv *.tgz vendor/databricks-sdk.tgz",
1816
"test": "yarn workspaces foreach run test",
1917
"test:integ": "yarn workspaces foreach run test:integ",
2018
"build": "yarn workspaces foreach run build",
@@ -34,7 +32,7 @@
3432
"homepage": "https://github.com/databricks/databricks-vscode#readme",
3533
"packageManager": "yarn@3.2.1",
3634
"devDependencies": {
37-
"@types/node": "^20.10.4",
35+
"@types/node": "^22.0.0",
3836
"@typescript-eslint/eslint-plugin": "^6.14.0",
3937
"@typescript-eslint/parser": "^6.14.0",
4038
"conventional-changelog-cli": "^4.1.0",

packages/databricks-vscode-types/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {ApiClient, WorkspaceClient} from "@databricks/databricks-sdk";
1+
import {ApiClient, WorkspaceClient} from "@databricks/sdk-experimental";
22
import {Cluster} from "databricks/src/sdk-extensions";
33
import {Event} from "vscode";
44
export type ConnectionState = "CONNECTED" | "CONNECTING" | "DISCONNECTED";

packages/databricks-vscode-types/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"typescript": "^5.3.3"
3030
},
3131
"dependencies": {
32-
"@databricks/databricks-sdk": "file:../../vendor/databricks-sdk.tgz",
32+
"@databricks/sdk-experimental": "^0.15.0",
3333
"databricks": "workspace:^"
3434
}
3535
}

packages/databricks-vscode/package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1187,8 +1187,8 @@
11871187
"generate-telemetry": "ts-node ./scripts/generateTelemetry.ts"
11881188
},
11891189
"dependencies": {
1190-
"@databricks/databricks-sdk": "file:../../vendor/databricks-sdk.tgz",
11911190
"@databricks/databricks-vscode-types": "workspace:^",
1191+
"@databricks/sdk-experimental": "^0.15.0",
11921192
"@types/lodash": "^4.14.202",
11931193
"@types/shell-quote": "^1.7.5",
11941194
"@vscode/debugadapter": "^1.64.0",
@@ -1211,9 +1211,10 @@
12111211
"@types/chai": "^4.3.11",
12121212
"@types/eslint": "^8.44.9",
12131213
"@types/fs-extra": "^11.0.4",
1214+
"@types/ini": "^4.1.1",
12141215
"@types/mocha": "^10.0.6",
12151216
"@types/mock-require": "^2.0.3",
1216-
"@types/node": "^20.10.4",
1217+
"@types/node": "^22.0.0",
12171218
"@types/sinonjs__fake-timers": "^8.1.5",
12181219
"@types/tmp": "^0.2.6",
12191220
"@types/triple-beam": "^1.3.5",

packages/databricks-vscode/src/bundle/BundleInitWizard.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
TerminalLocation,
77
commands,
88
} from "vscode";
9-
import {logging} from "@databricks/databricks-sdk";
9+
import {logging} from "@databricks/sdk-experimental";
1010
import {Loggers} from "../logger";
1111
import {AuthProvider} from "../configuration/auth/AuthProvider";
1212
import {LoginWizard} from "../configuration/LoginWizard";

packages/databricks-vscode/src/bundle/BundlePipelinesManager.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ import {
2727
ListPipelineEventsRequest,
2828
PipelineEvent,
2929
UpdateInfo,
30-
} from "@databricks/databricks-sdk/dist/apis/pipelines";
30+
} from "@databricks/sdk-experimental/dist/apis/pipelines";
3131
import {ConnectionManager} from "../configuration/ConnectionManager";
3232
import {Barrier} from "../locking/Barrier";
33-
import {WorkspaceClient} from "@databricks/databricks-sdk";
33+
import {WorkspaceClient} from "@databricks/sdk-experimental";
3434
import {LocalUri, RemoteUri} from "../sync/SyncDestination";
3535
import {expandUriAndType, NotebookType} from "../utils/fileUtils";
3636
import {onError} from "../utils/onErrorDecorator";

packages/databricks-vscode/src/bundle/BundleProjectManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import os from "node:os";
55
import {ConnectionManager} from "../configuration/ConnectionManager";
66
import {ConfigModel} from "../configuration/models/ConfigModel";
77
import {BundleFileSet, getSubProjects} from "./BundleFileSet";
8-
import {logging} from "@databricks/databricks-sdk";
8+
import {logging} from "@databricks/sdk-experimental";
99
import {Loggers} from "../logger";
1010
import {CachedValue} from "../locking/CachedValue";
1111
import {CustomWhenContext} from "../vscode-objs/CustomWhenContext";

packages/databricks-vscode/src/bundle/models/BundleRemoteStateModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {BundleTarget, Resource, ResourceKey, Resources} from "../types";
66
import {AuthProvider} from "../../configuration/auth/AuthProvider";
77
import lodash from "lodash";
88
import {WorkspaceConfigs} from "../../vscode-objs/WorkspaceConfigs";
9-
import {logging} from "@databricks/databricks-sdk";
9+
import {logging} from "@databricks/sdk-experimental";
1010
import {Loggers} from "../../logger";
1111
import {WorkspaceFolderManager} from "../../vscode-objs/WorkspaceFolderManager";
1212
import {CancellationToken} from "vscode";

packages/databricks-vscode/src/bundle/models/BundleValidateModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import lodash from "lodash";
77
import {workspaceConfigs} from "../../vscode-objs/WorkspaceConfigs";
88
import {BaseModelWithStateCache} from "../../configuration/models/BaseModelWithStateCache";
99
import {withOnErrorHandler} from "../../utils/onErrorDecorator";
10-
import {logging} from "@databricks/databricks-sdk";
10+
import {logging} from "@databricks/sdk-experimental";
1111
import {Loggers} from "../../logger";
1212
import {WorkspaceFolderManager} from "../../vscode-objs/WorkspaceFolderManager";
1313

packages/databricks-vscode/src/bundle/models/BundleVariableModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {ConfigModel} from "../../configuration/models/ConfigModel";
44
import {Mutex} from "../../locking";
55
import {BundleSchema} from "../types";
66
import {readFile} from "fs/promises";
7-
import {NamedLogger} from "@databricks/databricks-sdk/dist/logging";
7+
import {NamedLogger} from "@databricks/sdk-experimental/dist/logging";
88
import {Loggers} from "../../logger";
99
import {onError} from "../../utils/onErrorDecorator";
1010
import {BundleValidateModel} from "./BundleValidateModel";

0 commit comments

Comments
 (0)