Use @AfterEach for test cleanup instead of manual calls

Move cleanupAgentEnv() to an @AfterEach tearDown method so test
isolation is failure-safe. Previously, if an assertion failed before
the manual cleanup call, static state would leak between tests.

Co-authored-by: Isaac

Author: simonfaltum

databricks-sdk-java/src/test/java/com/databricks/sdk/core/UserAgentTest.java

@@ -4,11 +4,17 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.Map;
+import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
 public class UserAgentTest {
 
+  @AfterEach
+  void tearDown() {
+    cleanupAgentEnv();
+  }
+
   private void setupAgentEnv(Map<String, String> envMap) {
     UserAgent.agentProvider = null;
     UserAgent.cicdProvider = null;
@@ -80,7 +86,6 @@ public void testUserAgentCicdNoProvider() {
     UserAgent.env =
         new Environment(new HashMap<>(), new ArrayList<>(), System.getProperty("os.name"));
     Assertions.assertFalse(UserAgent.asString().contains("cicd"));
-    UserAgent.env = null;
   }
 
   @Test
@@ -96,7 +101,6 @@ public void testUserAgentCicdOneProvider() {
             new ArrayList<>(),
             System.getProperty("os.name"));
     Assertions.assertTrue(UserAgent.asString().contains("cicd/github"));
-    UserAgent.env = null;
   }
 
   @Test
@@ -113,7 +117,6 @@ public void testUserAgentCicdTwoProvider() {
             new ArrayList<>(),
             System.getProperty("os.name"));
     Assertions.assertTrue(UserAgent.asString().contains("cicd/gitlab"));
-    UserAgent.env = null;
   }
 
   @Test
@@ -125,7 +128,6 @@ public void testAgentProviderAntigravity() {
           }
         });
     Assertions.assertTrue(UserAgent.asString().contains("agent/antigravity"));
-    cleanupAgentEnv();
   }
 
   @Test
@@ -137,7 +139,6 @@ public void testAgentProviderClaudeCode() {
           }
         });
     Assertions.assertTrue(UserAgent.asString().contains("agent/claude-code"));
-    cleanupAgentEnv();
   }
 
   @Test
@@ -149,7 +150,6 @@ public void testAgentProviderCline() {
           }
         });
     Assertions.assertTrue(UserAgent.asString().contains("agent/cline"));
-    cleanupAgentEnv();
   }
 
   @Test
@@ -161,7 +161,6 @@ public void testAgentProviderCodex() {
           }
         });
     Assertions.assertTrue(UserAgent.asString().contains("agent/codex"));
-    cleanupAgentEnv();
   }
 
   @Test
@@ -173,7 +172,6 @@ public void testAgentProviderCursor() {
           }
         });
     Assertions.assertTrue(UserAgent.asString().contains("agent/cursor"));
-    cleanupAgentEnv();
   }
 
   @Test
@@ -185,7 +183,6 @@ public void testAgentProviderGeminiCli() {
           }
         });
     Assertions.assertTrue(UserAgent.asString().contains("agent/gemini-cli"));
-    cleanupAgentEnv();
   }
 
   @Test
@@ -197,14 +194,12 @@ public void testAgentProviderOpencode() {
           }
         });
     Assertions.assertTrue(UserAgent.asString().contains("agent/opencode"));
-    cleanupAgentEnv();
   }
 
   @Test
   public void testAgentProviderNoAgent() {
     setupAgentEnv(new HashMap<>());
     Assertions.assertFalse(UserAgent.asString().contains("agent/"));
-    cleanupAgentEnv();
   }
 
   @Test
@@ -217,7 +212,6 @@ public void testAgentProviderMultipleAgents() {
           }
         });
     Assertions.assertFalse(UserAgent.asString().contains("agent/"));
-    cleanupAgentEnv();
   }
 
   @Test
@@ -229,7 +223,6 @@ public void testAgentProviderEmptyValue() {
           }
         });
     Assertions.assertFalse(UserAgent.asString().contains("agent/"));
-    cleanupAgentEnv();
   }
 
   @Test
@@ -255,6 +248,5 @@ public void testAgentProviderCached() {
             System.getProperty("os.name"));
     Assertions.assertTrue(UserAgent.asString().contains("agent/cursor"));
     Assertions.assertFalse(UserAgent.asString().contains("agent/claude-code"));
-    cleanupAgentEnv();
   }
 }