Fix lint: gofmt alignment, perfsprint, testifylint

Co-authored-by: Isaac

Author: simonfaltum

experimental/aitools/cmd/install_test.go

@@ -52,13 +52,13 @@ func TestInstallCommandsDelegateToSkillsInstall(t *testing.T) {
 	calls := setupInstallMock(t)
 
 	tests := []struct {
-		name               string
-		newCmd             func() *cobra.Command
-		args               []string
-		flags              []string
-		wantAgents         int
-		wantSkills         []string
-		wantExperimental   bool
+		name             string
+		newCmd           func() *cobra.Command
+		args             []string
+		flags            []string
+		wantAgents       int
+		wantSkills       []string
+		wantExperimental bool
 	}{
 		{
 			name:       "skills install installs all skills for all agents",

experimental/aitools/lib/installer/installer.go

@@ -2,6 +2,7 @@ package installer
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -143,7 +144,7 @@ func InstallSkillsForAgents(ctx context.Context, src ManifestSource, targetAgent
 	if state == nil {
 		isLegacy := checkLegacyInstall(ctx, globalDir)
 		if isLegacy && len(opts.SpecificSkills) > 0 {
-			return fmt.Errorf("legacy install detected without state tracking; run 'databricks experimental aitools skills install' (without a skill name) first to rebuild state")
+			return errors.New("legacy install detected without state tracking; run 'databricks experimental aitools skills install' (without a skill name) first to rebuild state")
 		}
 	}
 

experimental/aitools/lib/installer/installer_test.go

@@ -516,7 +516,7 @@ func TestIdempotentInstallReinstallsForNewAgent(t *testing.T) {
 	require.NoError(t, err)
 
 	// Skills should be re-fetched because agent2 doesn't have them yet.
-	assert.Greater(t, fetchCalls, 0, "should re-install skills for new agent")
+	assert.Positive(t, fetchCalls, "should re-install skills for new agent")
 
 	// Verify agent2 got the skills.
 	agent2SkillsDir := filepath.Join(agent2Dir, "skills")