Skip to content

Commit ea74946

Browse files
committed
Fix project-scope tests: remove stale mock fields and hardcoded version refs
The mockManifestSource no longer has release/authoritative fields after FetchLatestRelease was removed. Update test struct literals and replace hardcoded "v0.1.0" assertions with defaultSkillsRepoRef.
1 parent 041f5c2 commit ea74946

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

experimental/aitools/lib/installer/installer_test.go

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@ package installer
33
import (
44
"bytes"
55
"context"
6+
"fmt"
67
"log/slog"
78
"os"
89
"path/filepath"
10+
"strings"
911
"testing"
1012

1113
"github.com/databricks/cli/experimental/aitools/lib/agents"
@@ -593,7 +595,7 @@ func TestInstallProjectScopeWritesState(t *testing.T) {
593595
require.NoError(t, os.MkdirAll(projectDir, 0o755))
594596
t.Chdir(projectDir)
595597

596-
src := &mockManifestSource{manifest: testManifest(), release: "v0.1.0", authoritative: true}
598+
src := &mockManifestSource{manifest: testManifest()}
597599
agent := testProjectAgent(tmp)
598600

599601
err := InstallSkillsForAgents(ctx, src, []*agents.Agent{agent}, InstallOptions{Scope: ScopeProject})
@@ -604,10 +606,11 @@ func TestInstallProjectScopeWritesState(t *testing.T) {
604606
require.NoError(t, err)
605607
require.NotNil(t, state)
606608
assert.Equal(t, ScopeProject, state.Scope)
607-
assert.Equal(t, "v0.1.0", state.Release)
609+
assert.Equal(t, defaultSkillsRepoRef, state.Release)
608610
assert.Len(t, state.Skills, 2)
609611

610-
assert.Contains(t, stderr.String(), "Installed 2 skills (v0.1.0).")
612+
tag := strings.TrimPrefix(defaultSkillsRepoRef, "v")
613+
assert.Contains(t, stderr.String(), fmt.Sprintf("Installed 2 skills (v%s).", tag))
611614
}
612615

613616
func TestInstallProjectScopeCreatesSymlinks(t *testing.T) {
@@ -623,7 +626,7 @@ func TestInstallProjectScopeCreatesSymlinks(t *testing.T) {
623626
cwd, err := os.Getwd()
624627
require.NoError(t, err)
625628

626-
src := &mockManifestSource{manifest: testManifest(), release: "v0.1.0", authoritative: true}
629+
src := &mockManifestSource{manifest: testManifest()}
627630
agent := testProjectAgent(tmp)
628631

629632
err = InstallSkillsForAgents(ctx, src, []*agents.Agent{agent}, InstallOptions{Scope: ScopeProject})
@@ -661,7 +664,7 @@ func TestInstallProjectScopeFiltersIncompatibleAgents(t *testing.T) {
661664
require.NoError(t, os.MkdirAll(projectDir, 0o755))
662665
t.Chdir(projectDir)
663666

664-
src := &mockManifestSource{manifest: testManifest(), release: "v0.1.0", authoritative: true}
667+
src := &mockManifestSource{manifest: testManifest()}
665668

666669
compatibleAgent := testProjectAgent(tmp)
667670
incompatibleAgent := &agents.Agent{
@@ -676,7 +679,7 @@ func TestInstallProjectScopeFiltersIncompatibleAgents(t *testing.T) {
676679
require.NoError(t, err)
677680

678681
assert.Contains(t, stderr.String(), "Skipped No Project Agent: does not support project-scoped skills.")
679-
assert.Contains(t, stderr.String(), "Installed 2 skills (v0.1.0).")
682+
assert.Contains(t, stderr.String(), fmt.Sprintf("Installed 2 skills (v%s).", strings.TrimPrefix(defaultSkillsRepoRef, "v")))
680683
}
681684

682685
func TestInstallProjectScopeZeroCompatibleAgentsReturnsError(t *testing.T) {
@@ -688,7 +691,7 @@ func TestInstallProjectScopeZeroCompatibleAgentsReturnsError(t *testing.T) {
688691
require.NoError(t, os.MkdirAll(projectDir, 0o755))
689692
t.Chdir(projectDir)
690693

691-
src := &mockManifestSource{manifest: testManifest(), release: "v0.1.0", authoritative: true}
694+
src := &mockManifestSource{manifest: testManifest()}
692695

693696
// Only provide agents that don't support project scope.
694697
globalOnlyAgent := &agents.Agent{

0 commit comments

Comments
 (0)