Skip to content

Commit d2dab23

Browse files
denikclaude
andauthored
direct: add declarative config, remove FieldTriggers() (#4304)
## Changes - Add resources.yml which is declarative part of resource configuration. - Remove FieldTriggers(), no longer needed. - Add custom YAML marshallers to PathNode so that it can be used in config structs. ## Why Makes the behaviour more visible and easier to tweak. It also matches names and format that we can add later to databricks.yml, e.g. lifecycle.ignore_remote_changes. Potentially, we can also allow overriding the whole config at runtime, so you can tweak / test different behaviour without rebuilding CLI. ## Tests Existing tests. --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent 3dea15d commit d2dab23

File tree

34 files changed

+509
-221
lines changed

34 files changed

+509
-221
lines changed

acceptance/bundle/resource_deps/pipelines_recreate/out.plan_update.direct.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
"changes": {
115115
"storage": {
116116
"action": "recreate",
117-
"reason": "field_triggers",
117+
"reason": "builtin_rule",
118118
"old": "dbfs:/my-storage",
119119
"new": "dbfs:/my-new-storage",
120120
"remote": "dbfs:/my-storage"

acceptance/bundle/resources/model_serving_endpoints/basic/out.second-plan.direct.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
},
3737
"name": {
3838
"action": "recreate",
39-
"reason": "field_triggers",
39+
"reason": "builtin_rule",
4040
"old": "[ENDPOINT_NAME_1]",
4141
"new": "[ENDPOINT_NAME_2]",
4242
"remote": "[ENDPOINT_NAME_1]"

acceptance/bundle/resources/model_serving_endpoints/recreate/catalog-name/out.second-plan.direct.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"changes": {
6969
"config.auto_capture_config.catalog_name": {
7070
"action": "recreate",
71-
"reason": "field_triggers",
71+
"reason": "builtin_rule",
7272
"old": "main",
7373
"new": "other_catalog",
7474
"remote": "main"

acceptance/bundle/resources/model_serving_endpoints/recreate/name-change/out.second-plan.direct.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
"changes": {
5959
"name": {
6060
"action": "recreate",
61-
"reason": "field_triggers",
61+
"reason": "builtin_rule",
6262
"old": "[ORIGINAL_ENDPOINT_ID]",
6363
"new": "[NEW_ENDPOINT_ID]",
6464
"remote": "[ORIGINAL_ENDPOINT_ID]"

acceptance/bundle/resources/model_serving_endpoints/recreate/route-optimized/out.second-plan.direct.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"changes": {
5252
"route_optimized": {
5353
"action": "recreate",
54-
"reason": "field_triggers",
54+
"reason": "builtin_rule",
5555
"old": false,
5656
"new": true,
5757
"remote": false

acceptance/bundle/resources/model_serving_endpoints/recreate/schema-name/out.second-plan.direct.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"changes": {
6969
"config.auto_capture_config.schema_name": {
7070
"action": "recreate",
71-
"reason": "field_triggers",
71+
"reason": "builtin_rule",
7272
"old": "default",
7373
"new": "other_schema",
7474
"remote": "default"

acceptance/bundle/resources/model_serving_endpoints/recreate/table-prefix/out.second-plan.direct.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"changes": {
6969
"config.auto_capture_config.table_name_prefix": {
7070
"action": "recreate",
71-
"reason": "field_triggers",
71+
"reason": "builtin_rule",
7272
"old": "my_table",
7373
"new": "other_table",
7474
"remote": "my_table"

acceptance/bundle/resources/pipelines/recreate-keys/change-ingestion-definition/out.plan_recreate.direct.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"changes": {
6666
"ingestion_definition.connection_name": {
6767
"action": "recreate",
68-
"reason": "field_triggers",
68+
"reason": "builtin_rule",
6969
"old": "my_connection",
7070
"new": "my_new_connection",
7171
"remote": "my_connection"

acceptance/bundle/resources/pipelines/recreate-keys/change-storage/out.plan_recreate.direct.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"changes": {
5555
"storage": {
5656
"action": "recreate",
57-
"reason": "field_triggers",
57+
"reason": "builtin_rule",
5858
"old": "dbfs:/pipelines/custom",
5959
"new": "dbfs:/pipelines/newcustom",
6060
"remote": "dbfs:/pipelines/custom"

acceptance/bundle/resources/quality_monitors/change_assets_dir/out.plan.direct.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"changes": {
3232
"assets_dir": {
3333
"action": "recreate",
34-
"reason": "field_triggers",
34+
"reason": "builtin_rule",
3535
"old": "/Workspace/Users/[USERNAME]/monitor_assets_[UNIQUE_NAME]",
3636
"new": "/Workspace/Users/[USERNAME]/monitor_assets2_[UNIQUE_NAME]",
3737
"remote": "/Workspace/Users/[USERNAME]/monitor_assets_[UNIQUE_NAME]"

0 commit comments

Comments
 (0)