Proactively create the resource path for dashboards (#4608)

## Changes
Proactively create the resource path for dashboards

## Why
Previously, we relied on TF implementation to create it, but it can be
fragile (for example, an API response message can change, and the path
won't be created). Explicitly creating it in DABs makes it more
resilient.

## Tests
Existing tests pass

<!-- If your PR needs to be included in the release notes for next
release,
add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->

Author: andrewnester

acceptance/bundle/resources/dashboards/change-embed-credentials/out.post.requests.txt

@@ -1,13 +1,3 @@
-{
-  "method": "POST",
-  "path": "/api/2.0/lakeview/dashboards",
-  "body": {
-    "display_name": "test dashboard",
-    "parent_path": "/Workspace/Users/[USERNAME]/.bundle/change-embed-credentials-[UNIQUE_NAME]/default/resources",
-    "serialized_dashboard": "{}\n",
-    "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
-  }
-}
 {
   "method": "POST",
   "path": "/api/2.0/workspace/mkdirs",
@@ -33,6 +23,13 @@
     "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
   }
 }
+{
+  "method": "POST",
+  "path": "/api/2.0/workspace/mkdirs",
+  "body": {
+    "path": "/Workspace/Users/[USERNAME]/.bundle/change-embed-credentials-[UNIQUE_NAME]/default/resources"
+  }
+}
 {
   "method": "POST",
   "path": "/api/2.0/lakeview/dashboards/[DASHBOARD_ID]/published",

acceptance/bundle/resources/dashboards/change-name/out.post.requests.txt

@@ -1,13 +1,3 @@
-{
-  "method": "POST",
-  "path": "/api/2.0/lakeview/dashboards",
-  "body": {
-    "display_name": "dashboard1",
-    "parent_path": "/Workspace/Users/[USERNAME]/.bundle/change-name-[UNIQUE_NAME]/default/resources",
-    "serialized_dashboard": "{}\n",
-    "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
-  }
-}
 {
   "method": "POST",
   "path": "/api/2.0/workspace/mkdirs",
@@ -33,6 +23,13 @@
     "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
   }
 }
+{
+  "method": "POST",
+  "path": "/api/2.0/workspace/mkdirs",
+  "body": {
+    "path": "/Workspace/Users/[USERNAME]/.bundle/change-name-[UNIQUE_NAME]/default/resources"
+  }
+}
 {
   "method": "POST",
   "path": "/api/2.0/lakeview/dashboards/[DASHBOARD_ID]/published",

acceptance/bundle/resources/dashboards/change-parent-path/out.dashboardrequests.txt

@@ -1,13 +1,3 @@
-{
-  "method": "POST",
-  "path": "/api/2.0/lakeview/dashboards",
-  "body": {
-    "display_name": "test dashboard",
-    "parent_path": "/Workspace/Users/[USERNAME]/.bundle/change-parent-path-[UNIQUE_NAME]/default/resources",
-    "serialized_dashboard": "{}\n",
-    "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
-  }
-}
 {
   "method": "POST",
   "path": "/api/2.0/workspace/mkdirs",
@@ -33,6 +23,13 @@
     "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
   }
 }
+{
+  "method": "POST",
+  "path": "/api/2.0/workspace/mkdirs",
+  "body": {
+    "path": "/Workspace/Users/[USERNAME]/.bundle/change-parent-path-[UNIQUE_NAME]/default/resources"
+  }
+}
 {
   "method": "DELETE",
   "path": "/api/2.0/lakeview/dashboards/[ORIGINAL_DASHBOARD_ID]"

acceptance/bundle/resources/dashboards/change-serialized-dashboard/out.post.requests.txt

@@ -1,13 +1,3 @@
-{
-  "method": "POST",
-  "path": "/api/2.0/lakeview/dashboards",
-  "body": {
-    "display_name": "test dashboard",
-    "parent_path": "/Workspace/Users/[USERNAME]/.bundle/change-serialized-dashboard-[UNIQUE_NAME]/default/resources",
-    "serialized_dashboard": "{\"pages\":[{\"name\":\"name1\",\"displayName\":\"name1\",\"pageType\":\"PAGE_TYPE_CANVAS\"}]}\n",
-    "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
-  }
-}
 {
   "method": "POST",
   "path": "/api/2.0/workspace/mkdirs",
@@ -33,6 +23,13 @@
     "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
   }
 }
+{
+  "method": "POST",
+  "path": "/api/2.0/workspace/mkdirs",
+  "body": {
+    "path": "/Workspace/Users/[USERNAME]/.bundle/change-serialized-dashboard-[UNIQUE_NAME]/default/resources"
+  }
+}
 {
   "method": "POST",
   "path": "/api/2.0/lakeview/dashboards/[DASHBOARD_ID]/published",

acceptance/bundle/resources/dashboards/detect-change/out.post.requests.txt

@@ -8,16 +8,6 @@
     "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
   }
 }
-{
-  "method": "POST",
-  "path": "/api/2.0/lakeview/dashboards",
-  "body": {
-    "display_name": "test-dashboard-[UNIQUE_NAME]",
-    "parent_path": "/Workspace/Users/[USERNAME]/.bundle/[UNIQUE_NAME]/resources",
-    "serialized_dashboard": "{\n  \"pages\": [\n    {\n      \"displayName\": \"New Page\",\n      \"layout\": [\n        {\n          \"position\": {\n            \"height\": 2,\n            \"width\": 6,\n            \"x\": 0,\n            \"y\": 0\n          },\n          \"widget\": {\n            \"name\": \"82eb9107\",\n            \"textbox_spec\": \"# I'm a title\"\n          }\n        },\n        {\n          \"position\": {\n            \"height\": 2,\n            \"width\": 6,\n            \"x\": 0,\n            \"y\": 2\n          },\n          \"widget\": {\n            \"name\": \"ffa6de4f\",\n            \"textbox_spec\": \"Text\"\n          }\n        }\n      ],\n      \"name\": \"fdd21a3c\"\n    }\n  ]\n}\n",
-    "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
-  }
-}
 {
   "method": "POST",
   "path": "/api/2.0/lakeview/dashboards/[DASHBOARD_ID]/published",

acceptance/bundle/resources/dashboards/publish-failure-cleans-up-dashboard/out.dashboardrequests.txt

@@ -12,16 +12,6 @@
     "path": "/Workspace/Users/[USERNAME]/.bundle/publish-failure-cleans-up-dashboard/default/files"
   }
 }
-{
-  "method": "POST",
-  "path": "/api/2.0/lakeview/dashboards",
-  "body": {
-    "display_name": "my dashboard",
-    "parent_path": "/Workspace/Users/[USERNAME]/.bundle/publish-failure-cleans-up-dashboard/default/resources",
-    "serialized_dashboard": "{\"pages\":[{\"name\":\"test-page\",\"displayName\":\"Test Dashboard\"}]}\n",
-    "warehouse_id": "doesnotexist"
-  }
-}
 {
   "method": "POST",
   "path": "/api/2.0/workspace/mkdirs",

bundle/deploy/resource_path_mkdir.go

@@ -21,13 +21,7 @@ func (m *resourcePathMkdir) Name() string {
 
 func (m *resourcePathMkdir) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
 	// Only dashboards and alerts need ${workspace.resource_path} to exist.
-	//
-	// We'll defer to TF to create resource_path for for dashboards.
-	// ref: https://github.com/databricks/terraform-provider-databricks/blob/d84bc6f28d8aa0fd77d110a41f745970299142b1/dashboards/resource_dashboard.go#L83.
-	//
-	// For alerts we proactively create it here because the TF implementation
-	// is autogenerated and cannot be easily customized.
-	if len(b.Config.Resources.Alerts) == 0 {
+	if len(b.Config.Resources.Alerts) == 0 && len(b.Config.Resources.Dashboards) == 0 {
 		return nil
 	}