deployplan: Rename Action.Action to Action.ActionType (#3093)

This is a better name.

Author: denik

bundle/deploy/terraform/showplanfile.go

@@ -40,9 +40,9 @@ func GetActions(changes []*tfjson.ResourceChange) []deployplan.Action {
 		}
 
 		result = append(result, deployplan.Action{
-			Action: actionType,
-			Group:  group,
-			Name:   rc.Name,
+			ActionType: actionType,
+			Group:      group,
+			Name:       rc.Name,
 		})
 	}
 

bundle/deployplan/plan.go

@@ -20,12 +20,12 @@ type Action struct {
 	// Key of the resource the config
 	Name string
 
-	Action ActionType
+	ActionType ActionType
 }
 
 func (a Action) String() string {
 	typ, _ := strings.CutSuffix(a.Group, "s")
-	return fmt.Sprintf("  %s %s %s", a.Action, typ, a.Name)
+	return fmt.Sprintf("  %s %s %s", a.ActionType, typ, a.Name)
 }
 
 // Implements cmdio.Event for cmdio.Log
@@ -50,7 +50,7 @@ const (
 func Filter(changes []Action, actionType ActionType) []Action {
 	var result []Action
 	for _, action := range changes {
-		if action.Action == actionType {
+		if action.ActionType == actionType {
 			result = append(result, action)
 		}
 	}
@@ -68,7 +68,7 @@ func FilterGroup(changes []Action, group string, actionTypes ...ActionType) []Ac
 	}
 
 	for _, action := range changes {
-		if action.Group == group && actionTypeSet[action.Action] {
+		if action.Group == group && actionTypeSet[action.ActionType] {
 			result = append(result, action)
 		}
 	}

bundle/phases/deploy_test.go

@@ -46,14 +46,14 @@ func TestParseTerraformActions(t *testing.T) {
 
 	assert.Equal(t, []deployplan.Action{
 		{
-			Action: deployplan.ActionTypeDelete,
-			Group:  "pipelines",
-			Name:   "delete pipeline",
+			ActionType: deployplan.ActionTypeDelete,
+			Group:      "pipelines",
+			Name:       "delete pipeline",
 		},
 		{
-			Action: deployplan.ActionTypeRecreate,
-			Group:  "pipelines",
-			Name:   "recreate pipeline",
+			ActionType: deployplan.ActionTypeRecreate,
+			Group:      "pipelines",
+			Name:       "recreate pipeline",
 		},
 	}, res)
 }