Skip to content

Commit a6080fa

Browse files
authored
acc: clean up NUMBER replacement, use NUMID (#3150)
Noticed in #3149 it is being referenced in places where it's not used.
1 parent 30ac067 commit a6080fa

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

acceptance/bundle/deploy/jobs/check-metadata/test.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ MSYS_NO_PATHCONV = "1"
1717

1818
[[Repls]]
1919
# clean up ?o=<num> suffix after URL since not all workspaces have that
20-
Old = '\?o=\[(NUMBER|NUMID)\]'
20+
Old = '\?o=\[NUMID\]'
2121
New = ''
2222
Order = 1000

acceptance/bundle/templates/default-python/integration_classic/output.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Validation OK!
2626

2727
>>> [CLI] bundle deploy -t dev
2828
Building python_artifact...
29-
Uploading dist/project_name_[UNIQUE_NAME]-0.0.1+[NUMBER].[NUMBER]-py3-none-any.whl...
29+
Uploading dist/project_name_[UNIQUE_NAME]-0.0.1+[NUMID].[NUMID]-py3-none-any.whl...
3030
Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/project_name_[UNIQUE_NAME]/dev/files...
3131
Deploying resources...
3232
Updating deployment state...
@@ -43,7 +43,7 @@ Resources:
4343
Jobs:
4444
project_name_[UNIQUE_NAME]_job:
4545
Name: [dev [USERNAME]] project_name_[UNIQUE_NAME]_job
46-
URL: [DATABRICKS_URL]/jobs/[NUMBER]
46+
URL: [DATABRICKS_URL]/jobs/[NUMID]
4747
Pipelines:
4848
project_name_[UNIQUE_NAME]_pipeline:
4949
Name: [dev [USERNAME]] project_name_[UNIQUE_NAME]_pipeline
@@ -231,7 +231,7 @@ Validation OK!
231231

232232
>>> [CLI] bundle deploy -t prod
233233
Building python_artifact...
234-
Uploading dist/project_name_[UNIQUE_NAME]-0.0.1+[NUMBER].[NUMBER]-py3-none-any.whl...
234+
Uploading dist/project_name_[UNIQUE_NAME]-0.0.1+[NUMID].[NUMID]-py3-none-any.whl...
235235
Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/project_name_[UNIQUE_NAME]/prod/files...
236236
Deploying resources...
237237
Updating deployment state...
@@ -248,7 +248,7 @@ Resources:
248248
Jobs:
249249
project_name_[UNIQUE_NAME]_job:
250250
Name: project_name_[UNIQUE_NAME]_job
251-
URL: [DATABRICKS_URL]/jobs/[NUMBER]
251+
URL: [DATABRICKS_URL]/jobs/[NUMID]
252252
Pipelines:
253253
project_name_[UNIQUE_NAME]_pipeline:
254254
Name: project_name_[UNIQUE_NAME]_pipeline

acceptance/bundle/templates/default-python/integration_classic/test.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Response.Body = '{}'
2525
[[Repls]]
2626
# for some reason leading number is lost converting "%H%M%S" 061234 to 61234
2727
Old = '\d{5,}'
28-
New = '[NUMBER]'
28+
New = '[NUMID]'
2929

3030
[[Repls]]
3131
Old = 'Standard_D3_v2'
@@ -42,7 +42,7 @@ New = "python3 setup.py bdist_wheel"
4242

4343
[[Repls]]
4444
# clean up ?o=<num> suffix after URL since not all workspaces have that
45-
Old = '\?o=\[(NUMBER|NUMID)\]'
45+
Old = '\?o=\[NUMID\]'
4646
New = ''
4747
Order = 1000
4848

0 commit comments

Comments
 (0)