Skip to content

Commit a50e230

Browse files
authored
Run cloud integration tests if experimental/ssh files are changed (#4577)
## Changes <!-- Brief summary of your changes that is easy to understand --> Push workflow now triggers integration tests if there is a `test-exp-ssh` target detected for the changed files ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> Without this change the integration tests are not triggered for pull requests that only change experimental/ssh files (or acceptance tests for them). This is not correct since experimental ssh project does have acceptance tests that run in the cloud. ## Tests <!-- How have you tested the changes? --> Created a PR to this PR and verified that the integration tests are triggered for it: #4579 <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
1 parent 5074868 commit a50e230

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/push.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ jobs:
388388

389389
# Trigger integration tests if the primary "test" target is triggered by this change.
390390
- name: Trigger integration tests (pull request)
391-
if: ${{ github.event_name == 'pull_request' && contains(fromJSON(needs.testmask.outputs.targets), 'test') }}
391+
if: ${{ github.event_name == 'pull_request' && (contains(fromJSON(needs.testmask.outputs.targets), 'test') || contains(fromJSON(needs.testmask.outputs.targets), 'test-exp-ssh')) }}
392392
env:
393393
GH_TOKEN: ${{ steps.generate-token.outputs.token }}
394394
run: |-
@@ -400,7 +400,7 @@ jobs:
400400
# Skip integration tests if the primary "test" target is not triggered by this change.
401401
# Use Checks API (not Statuses API) to match the required "Integration Tests" check.
402402
- name: Skip integration tests (pull request)
403-
if: ${{ github.event_name == 'pull_request' && !contains(fromJSON(needs.testmask.outputs.targets), 'test') }}
403+
if: ${{ github.event_name == 'pull_request' && !contains(fromJSON(needs.testmask.outputs.targets), 'test') && !contains(fromJSON(needs.testmask.outputs.targets), 'test-exp-ssh') }}
404404
uses: actions/github-script@v8
405405
with:
406406
script: |

0 commit comments

Comments
 (0)