Fix gofmt, gofumpt, perfsprint, and staticcheck lint issues

Author: simonfaltum

experimental/aitools/cmd/install_test.go

@@ -1,8 +1,8 @@
 package aitools
 
 import (
-	"context"
 	"bufio"
+	"context"
 	"os"
 	"path/filepath"
 	"testing"

experimental/aitools/cmd/skills.go

@@ -2,7 +2,8 @@ package aitools
 
 import (
 	"context"
-	"fmt"
+	"errors"
+
 	"github.com/charmbracelet/huh"
 	"github.com/databricks/cli/experimental/aitools/lib/agents"
 	"github.com/databricks/cli/experimental/aitools/lib/installer"
@@ -13,7 +14,7 @@ import (
 
 // Package-level vars for testability.
 var (
-	promptAgentSelection    = defaultPromptAgentSelection
+	promptAgentSelection     = defaultPromptAgentSelection
 	installSkillsForAgentsFn = installer.InstallSkillsForAgents
 )
 
@@ -37,7 +38,7 @@ func defaultPromptAgentSelection(ctx context.Context, detected []*agents.Agent)
 	}
 
 	if len(selected) == 0 {
-		return nil, fmt.Errorf("at least one agent must be selected")
+		return nil, errors.New("at least one agent must be selected")
 	}
 
 	result := make([]*agents.Agent, 0, len(selected))

experimental/aitools/lib/installer/installer_test.go

@@ -481,7 +481,8 @@ func TestLegacyDetectLegacyDir(t *testing.T) {
 }
 
 func TestInstallAllSkillsSignaturePreserved(t *testing.T) {
-	// Compile-time check that InstallAllSkills satisfies func(context.Context) error.
-	var fn func(context.Context) error = InstallAllSkills
-	_ = fn
+	// Compile-time check that InstallAllSkills matches the expected signature.
+	// cmd/apps/init.go passes this as func(context.Context) error.
+	callback := func(fn func(context.Context) error) { _ = fn }
+	callback(InstallAllSkills)
 }