Commit 8c7ec3b
authored
Use App for Integration Test Check Runs (#4563)
The "mark as pending" job in the integration test workflow has been
broken since late January. The nightly run fails with:
```
gh: Invalid app_id `15368` - check run can only be modified by the GitHub App that created it. (HTTP 403)
```
The "Auto-approve for merge group" and "Skip integration tests" steps in
`push.yml` create "Integration Tests" checks using
`actions/github-script`, which runs under the built-in `GITHUB_TOKEN` —
the `github-actions` app (ID 15368). When that same commit lands on main
and triggers the nightly, the `update-check` action in eng-dev-ecosystem
tries to update that check using the `DECO_TEST_APPROVAL` app token.
GitHub's Checks API rejects this because only the app that created a
check can modify it.
This PR generates a `DECO_TEST_APPROVAL` token for both steps and passes
it via `github-token` to `actions/github-script`, so checks are created
by the same app that later updates them.
---------
Co-authored-by: Omer Lachish <rauchy@users.noreply.github.com>1 parent 1e2f2f3 commit 8c7ec3b
1 file changed
+15
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
394 | 394 | | |
395 | 395 | | |
396 | 396 | | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
397 | 410 | | |
398 | 411 | | |
399 | 412 | | |
| |||
411 | 424 | | |
412 | 425 | | |
413 | 426 | | |
| 427 | + | |
414 | 428 | | |
415 | 429 | | |
416 | 430 | | |
| |||
431 | 445 | | |
432 | 446 | | |
433 | 447 | | |
| 448 | + | |
434 | 449 | | |
435 | 450 | | |
436 | 451 | | |
| |||
0 commit comments