Skip to content

Commit 6988c16

Browse files
authored
Temporarily disable integration test trigger (#4899)
## Summary - Skip integration test triggering on PRs and pushes to main while the integration test infrastructure is not working - The required "Integration Tests" check still passes (marked as skipped) so PRs and merge queue are not blocked - Removed dependency on `test-trigger-is` environment and app tokens since no external workflows are triggered - Revert this PR when integration tests are working again ## Test plan - [x] Verify the "Integration Tests" check shows as passed with skip message on a PR - [x] Verify merge queue auto-approves correctly This pull request was AI-assisted by Isaac.
1 parent ae55704 commit 6988c16

1 file changed

Lines changed: 8 additions & 65 deletions

File tree

.github/workflows/push.yml

Lines changed: 8 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -379,70 +379,25 @@ jobs:
379379
exit 1
380380
fi
381381
382-
# Trigger integration tests in a separate repository.
383-
# Requires secrets from "test-trigger-is" environment (not available for fork PRs or dependabot).
384-
# Auto-approves for merge groups to avoid running twice and queue timeouts.
382+
# Skip integration tests (temporarily disabled).
383+
# Creates a passing check for PRs and auto-approves for merge groups.
385384
integration-trigger:
386-
needs:
387-
- testmask
388-
389385
if: >-
390386
(github.event_name == 'pull_request' && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]') ||
391-
(github.event_name == 'merge_group') ||
392-
(github.event_name == 'push')
387+
(github.event_name == 'merge_group')
393388
394389
runs-on:
395-
group: databricks-deco-testing-runner-group
396-
labels: ubuntu-latest-deco
390+
group: databricks-protected-runner-group-large
391+
labels: linux-ubuntu-latest-large
397392

398393
permissions:
399394
checks: write
400-
contents: read
401-
402-
environment: "test-trigger-is"
403395

404396
steps:
405-
- name: Generate GitHub App Token
406-
if: ${{ github.event_name == 'pull_request' || github.event_name == 'push' }}
407-
id: generate-token
408-
uses: actions/create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859 # v3.0.0
409-
with:
410-
app-id: ${{ secrets.DECO_WORKFLOW_TRIGGER_APP_ID }}
411-
private-key: ${{ secrets.DECO_WORKFLOW_TRIGGER_PRIVATE_KEY }}
412-
owner: ${{ secrets.ORG_NAME }}
413-
repositories: ${{ secrets.REPO_NAME }}
414-
415-
- name: Generate GitHub App Token (check runs)
416-
if: >-
417-
(github.event_name == 'merge_group') ||
418-
(github.event_name == 'pull_request' && !contains(fromJSON(needs.testmask.outputs.targets), 'test'))
419-
id: generate-check-token
420-
uses: actions/create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859 # v3.0.0
421-
with:
422-
app-id: ${{ secrets.DECO_TEST_APPROVAL_APP_ID }}
423-
private-key: ${{ secrets.DECO_TEST_APPROVAL_PRIVATE_KEY }}
424-
# DECO_TEST_APPROVAL is installed on the databricks org (not databricks-eng).
425-
owner: databricks
426-
repositories: cli
427-
428-
# Trigger integration tests if the primary "test" target is triggered by this change.
429-
- name: Trigger integration tests (pull request)
430-
if: ${{ github.event_name == 'pull_request' && (contains(fromJSON(needs.testmask.outputs.targets), 'test') || contains(fromJSON(needs.testmask.outputs.targets), 'test-exp-ssh')) }}
431-
env:
432-
GH_TOKEN: ${{ steps.generate-token.outputs.token }}
433-
run: |-
434-
gh workflow run cli-isolated-pr.yml -R ${{ secrets.ORG_NAME }}/${{ secrets.REPO_NAME }} \
435-
--ref main \
436-
-f pull_request_number=${{ github.event.pull_request.number }} \
437-
-f commit_sha=${{ github.event.pull_request.head.sha }}
438-
439-
# Skip integration tests if the primary "test" target is not triggered by this change.
440-
# Use Checks API (not Statuses API) to match the required "Integration Tests" check.
441397
- name: Skip integration tests (pull request)
442-
if: ${{ github.event_name == 'pull_request' && !contains(fromJSON(needs.testmask.outputs.targets), 'test') && !contains(fromJSON(needs.testmask.outputs.targets), 'test-exp-ssh') }}
398+
if: ${{ github.event_name == 'pull_request' }}
443399
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
444400
with:
445-
github-token: ${{ steps.generate-check-token.outputs.token }}
446401
script: |
447402
await github.rest.checks.create({
448403
owner: context.repo.owner,
@@ -453,17 +408,14 @@ jobs:
453408
conclusion: 'success',
454409
output: {
455410
title: 'Integration Tests',
456-
summary: '⏭️ Skipped (changes do not require integration tests)'
411+
summary: '⏭️ Skipped (integration test trigger is temporarily disabled)'
457412
}
458413
});
459414
460-
# Auto-approve for merge group since tests already passed on the PR.
461-
# Use Checks API (not Statuses API) to match the required "Integration Tests" check.
462415
- name: Auto-approve for merge group
463416
if: ${{ github.event_name == 'merge_group' }}
464417
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
465418
with:
466-
github-token: ${{ steps.generate-check-token.outputs.token }}
467419
script: |
468420
await github.rest.checks.create({
469421
owner: context.repo.owner,
@@ -474,19 +426,10 @@ jobs:
474426
conclusion: 'success',
475427
output: {
476428
title: 'Integration Tests',
477-
summary: '⏭️ Auto-approved for merge queue (tests already passed on PR)'
429+
summary: '⏭️ Skipped (integration test trigger is temporarily disabled)'
478430
}
479431
});
480432
481-
- name: Trigger integration tests (push to main)
482-
if: ${{ github.event_name == 'push' }}
483-
env:
484-
GH_TOKEN: ${{ steps.generate-token.outputs.token }}
485-
run: |-
486-
gh workflow run cli-isolated-nightly.yml -R ${{ secrets.ORG_NAME }}/${{ secrets.REPO_NAME }} \
487-
--ref main \
488-
-f commit_sha=${{ github.event.after }}
489-
490433
# Skip integration tests for dependabot PRs.
491434
# Dependabot has no access to the "test-trigger-is" environment secrets,
492435
# so we use the built-in GITHUB_TOKEN to mark the required "Integration

0 commit comments

Comments
 (0)