Replace make+copy with direct assignment in migrateGrantsEntry

denik · claude · denik · commit 512d20f07765 · 2026-03-18T11:29:12.000+01:00
old.Grants is a fresh local allocation from json.Unmarshal, no aliasing risk.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/bundle/direct/dstate/migrate.go b/bundle/direct/dstate/migrate.go
@@ -132,9 +132,8 @@ func migrateGrantsEntry(raw json.RawMessage) (json.RawMessage, error) {
 	newState := dresources.GrantsState{
 		SecurableType: old.SecurableType,
 		FullName:      old.FullName,
-		EmbeddedSlice: make([]catalog.PrivilegeAssignment, len(old.Grants)),
+		EmbeddedSlice: old.Grants,
 	}
-	copy(newState.EmbeddedSlice, old.Grants)
 
 	return json.Marshal(newState)
 }

Original file line number	Diff line number	Diff line change
`@@ -132,9 +132,8 @@ func migrateGrantsEntry(raw json.RawMessage) (json.RawMessage, error) {`
`132`	`132`	`newState := dresources.GrantsState{`
`133`	`133`	`SecurableType: old.SecurableType,`
`134`	`134`	`FullName: old.FullName,`
`135`		`- EmbeddedSlice: make([]catalog.PrivilegeAssignment, len(old.Grants)),`
	`135`	`+ EmbeddedSlice: old.Grants,`
`136`	`136`	`}`
`137`		`- copy(newState.EmbeddedSlice, old.Grants)`
`138`	`137`
`139`	`138`	`return json.Marshal(newState)`
`140`	`139`	`}`