Use env.UserHomeDir(ctx) instead of os.UserHomeDir() (#4654)

## Summary
- Convert `os.UserHomeDir()` to `env.UserHomeDir(ctx)` at callsites
where context is available
- Makes home directory resolution context-aware, enabling test overrides
- Covers `cmd/completion`, `libs/databrickscfg`, `experimental/aitools`,
`experimental/ssh/internal/server`, and internal test utilities
- Thread ctx through `InstallMCP` and agent `ConfigDir` function
signatures
- Add `forbidigo` linter rule to reject new `os.UserHomeDir()` calls
- Remaining callsites in `libs/git` and `experimental/ssh` (public API
changes) are annotated with `nolint` and left for separate PRs

## Test plan
- [x] All modified packages compile
- [x] `experimental/aitools` tests pass
- [x] `make lintfull` passes with zero issues


🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: pietern

.golangci.yaml

@@ -28,6 +28,8 @@ linters:
           msg: Use cmdio.IsPromptSupported(ctx) to check for a TTY.
         - pattern: 'isatty\.IsCygwinTerminal'
           msg: Use cmdio.IsPromptSupported(ctx) to check for a TTY.
+        - pattern: 'os\.UserHomeDir'
+          msg: Use env.UserHomeDir(ctx) from libs/env instead.
       analyze-types: true
     copyloopvar:
       check-alias: true

cmd/apps/init.go

@@ -871,7 +871,7 @@ func runCreate(ctx context.Context, opts createOptions) error {
 	// Recommend skills installation if coding agents are detected without skills.
 	// In flags mode, only print a hint — never prompt interactively.
 	if flagsMode {
-		if !agents.HasDatabricksSkillsInstalled() {
+		if !agents.HasDatabricksSkillsInstalled(ctx) {
 			cmdio.LogString(ctx, "Tip: coding agents detected without Databricks skills. Run 'databricks experimental aitools skills install' to install them.")
 		}
 	} else if err := agents.RecommendSkillsInstall(ctx, installer.InstallAllSkills); err != nil {

cmd/completion/install.go

@@ -3,11 +3,11 @@ package completion
 import (
 	"errors"
 	"fmt"
-	"os"
 	"path/filepath"
 
 	"github.com/databricks/cli/libs/cmdio"
 	libcompletion "github.com/databricks/cli/libs/completion"
+	"github.com/databricks/cli/libs/env"
 	"github.com/spf13/cobra"
 )
 
@@ -28,7 +28,7 @@ func newInstallCmd() *cobra.Command {
 				return err
 			}
 
-			home, err := os.UserHomeDir()
+			home, err := env.UserHomeDir(ctx)
 			if err != nil {
 				return err
 			}

cmd/completion/status.go

@@ -2,11 +2,11 @@ package completion
 
 import (
 	"fmt"
-	"os"
 	"path/filepath"
 
 	"github.com/databricks/cli/libs/cmdio"
 	libcompletion "github.com/databricks/cli/libs/completion"
+	"github.com/databricks/cli/libs/env"
 	"github.com/spf13/cobra"
 )
 
@@ -26,7 +26,7 @@ func newStatusCmd() *cobra.Command {
 				return err
 			}
 
-			home, err := os.UserHomeDir()
+			home, err := env.UserHomeDir(ctx)
 			if err != nil {
 				return err
 			}

cmd/completion/uninstall.go

@@ -3,11 +3,11 @@ package completion
 import (
 	"errors"
 	"fmt"
-	"os"
 	"path/filepath"
 
 	"github.com/databricks/cli/libs/cmdio"
 	libcompletion "github.com/databricks/cli/libs/completion"
+	"github.com/databricks/cli/libs/env"
 	"github.com/spf13/cobra"
 )
 
@@ -28,7 +28,7 @@ func newUninstallCmd() *cobra.Command {
 				return err
 			}
 
-			home, err := os.UserHomeDir()
+			home, err := env.UserHomeDir(ctx)
 			if err != nil {
 				return err
 			}

experimental/aitools/cmd/install.go

@@ -39,7 +39,7 @@ func runInstall(ctx context.Context) error {
 		}
 
 		if targetAgent != nil && targetAgent.InstallMCP != nil {
-			if err := targetAgent.InstallMCP(); err != nil {
+			if err := targetAgent.InstallMCP(ctx); err != nil {
 				return err
 			}
 			cmdio.LogString(ctx, color.GreenString("✓ Installed Databricks MCP server for %s", targetAgent.DisplayName))
@@ -81,7 +81,7 @@ func runInstall(ctx context.Context) error {
 		}
 		if ans == "yes" {
 			fmt.Fprintf(os.Stderr, "Installing MCP server for %s...", a.DisplayName)
-			if err := a.InstallMCP(); err != nil {
+			if err := a.InstallMCP(ctx); err != nil {
 				fmt.Fprint(os.Stderr, "\r"+color.YellowString("⊘ Skipped %s: %s", a.DisplayName, err.Error())+"\n")
 			} else {
 				// Brief delay so users see the "Installing..." message before it's replaced

experimental/aitools/lib/agents/agents.go

@@ -1,9 +1,11 @@
 package agents
 
 import (
+	"context"
 	"os"
 	"path/filepath"
-	"runtime"
+
+	"github.com/databricks/cli/libs/env"
 )
 
 // Agent defines a coding agent that can have skills installed and optionally MCP server.
@@ -12,17 +14,17 @@ type Agent struct {
 	DisplayName string
 	// ConfigDir returns the agent's config directory (e.g., ~/.claude).
 	// Used for detection and as base for skills directory.
-	ConfigDir func() (string, error)
+	ConfigDir func(ctx context.Context) (string, error)
 	// SkillsSubdir is the subdirectory within ConfigDir for skills (default: "skills").
 	SkillsSubdir string
 	// InstallMCP installs the Databricks MCP server for this agent.
 	// Nil if agent doesn't support MCP or we haven't implemented it.
-	InstallMCP func() error
+	InstallMCP func(ctx context.Context) error
 }
 
 // Detected returns true if the agent is installed on the system.
-func (a *Agent) Detected() bool {
-	dir, err := a.ConfigDir()
+func (a *Agent) Detected(ctx context.Context) bool {
+	dir, err := a.ConfigDir(ctx)
 	if err != nil {
 		return false
 	}
@@ -31,8 +33,8 @@ func (a *Agent) Detected() bool {
 }
 
 // SkillsDir returns the full path to the agent's skills directory.
-func (a *Agent) SkillsDir() (string, error) {
-	configDir, err := a.ConfigDir()
+func (a *Agent) SkillsDir(ctx context.Context) (string, error) {
+	configDir, err := a.ConfigDir(ctx)
 	if err != nil {
 		return "", err
 	}
@@ -43,20 +45,10 @@ func (a *Agent) SkillsDir() (string, error) {
 	return filepath.Join(configDir, subdir), nil
 }
 
-// getHomeDir returns home directory, handling Windows USERPROFILE.
-func getHomeDir() (string, error) {
-	if runtime.GOOS == "windows" {
-		if userProfile := os.Getenv("USERPROFILE"); userProfile != "" {
-			return userProfile, nil
-		}
-	}
-	return os.UserHomeDir()
-}
-
 // homeSubdir returns a function that computes ~/subpath.
-func homeSubdir(subpath ...string) func() (string, error) {
-	return func() (string, error) {
-		home, err := getHomeDir()
+func homeSubdir(subpath ...string) func(ctx context.Context) (string, error) {
+	return func(ctx context.Context) (string, error) {
+		home, err := env.UserHomeDir(ctx)
 		if err != nil {
 			return "", err
 		}
@@ -103,10 +95,10 @@ var Registry = []Agent{
 }
 
 // DetectInstalled returns all agents that are installed on the system.
-func DetectInstalled() []*Agent {
+func DetectInstalled(ctx context.Context) []*Agent {
 	var installed []*Agent
 	for i := range Registry {
-		if Registry[i].Detected() {
+		if Registry[i].Detected(ctx) {
 			installed = append(installed, &Registry[i])
 		}
 	}

experimental/aitools/lib/agents/claude.go

@@ -1,14 +1,15 @@
 package agents
 
 import (
+	"context"
 	"errors"
 	"fmt"
 	"os"
 	"os/exec"
 )
 
 // InstallClaude installs the Databricks AI Tools MCP server in Claude Code.
-func InstallClaude() error {
+func InstallClaude(_ context.Context) error {
 	// Check if claude CLI is available
 	if _, err := exec.LookPath("claude"); err != nil {
 		return errors.New("'claude' CLI is not installed or not on PATH\n\nPlease install Claude Code and ensure 'claude' is available on your system PATH.\nFor installation instructions, visit: https://docs.anthropic.com/en/docs/claude-code")

experimental/aitools/lib/agents/cursor.go

@@ -1,10 +1,13 @@
 package agents
 
 import (
+	"context"
 	"encoding/json"
 	"fmt"
 	"os"
 	"path/filepath"
+
+	"github.com/databricks/cli/libs/env"
 )
 
 type cursorConfig struct {
@@ -18,11 +21,12 @@ type mcpServer struct {
 }
 
 // InstallCursor installs the Databricks AI Tools MCP server in Cursor.
-func InstallCursor() error {
-	configDir, err := homeSubdir(".cursor")()
+func InstallCursor(ctx context.Context) error {
+	home, err := env.UserHomeDir(ctx)
 	if err != nil {
 		return fmt.Errorf("failed to determine Cursor config path: %w", err)
 	}
+	configDir := filepath.Join(home, ".cursor")
 
 	// Check if .cursor directory exists
 	if _, err := os.Stat(configDir); err != nil {

experimental/aitools/lib/agents/recommend.go

@@ -10,7 +10,7 @@ import (
 // RecommendSkillsInstall checks if coding agents are detected but have no skills installed.
 // In interactive mode, prompts the user to install now using installFn. In non-interactive mode, prints a hint.
 func RecommendSkillsInstall(ctx context.Context, installFn func(context.Context) error) error {
-	if HasDatabricksSkillsInstalled() {
+	if HasDatabricksSkillsInstalled(ctx) {
 		return nil
 	}