Skip to content

Commit 438ffd1

Browse files
authored
Fix broken acceptance test (#4296)
## Changes Update the acceptance test output from #4291.
1 parent 9072fbc commit 438ffd1

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ generate:
174174
.PHONY: lint lintfull tidy lintcheck fmt fmtfull test test-unit test-acc test-slow test-slow-unit test-slow-acc cover showcover build snapshot snapshot-release schema integration integration-short acc-cover acc-showcover docs ws wsfix links checks test-update test-update-templates generate-out-test-toml test-update-aws test-update-all generate-validation
175175

176176
test-exp-aitools:
177-
make test TEST_PACKAGES="./experimental/aitools/..." ACCEPTANCE_TEST_FILTER="TestAccept/idontexistyet/aitools"
177+
make test TEST_PACKAGES="./experimental/aitools/..." ACCEPTANCE_TEST_FILTER="TestAccept/apps"
178178

179179
test-exp-ssh:
180180
make test TEST_PACKAGES="./experimental/ssh/..." ACCEPTANCE_TEST_FILTER="TestAccept/ssh"

acceptance/apps/init-template/app/output.txt

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,15 @@ export const querySchemas = {
9191
};
9292
```
9393

94-
**Step 3: Add visualization to your app**
94+
**Step 3: Run typegen (REQUIRED after any schema change)**
95+
96+
```bash
97+
npm run typegen
98+
```
99+
100+
This regenerates `client/src/appKitTypes.d.ts` with your new query types. **Without this step, TypeScript will not recognize your query keys and builds will fail.**
101+
102+
**Step 4: Add visualization to your app**
95103

96104
```typescript
97105
// client/src/App.tsx
@@ -102,9 +110,9 @@ import { BarChart } from '@databricks/appkit-ui/react';
102110

103111
**That's it!** The component handles data fetching, loading states, and rendering automatically.
104112

105-
**To refresh TypeScript types after adding queries:**
106-
- Run `npm run typegen` OR run `npm run dev` - both auto-generate type definitions in `client/src/appKitTypes.d.ts`
107-
- DO NOT manually edit `appKitTypes.d.ts`
113+
**⚠️ CRITICAL: Always run `npm run typegen` after modifying files in `config/queries/`**
114+
- DO NOT manually edit `client/src/appKitTypes.d.ts` - it is auto-generated
115+
- If you see errors like `'"my_query"' is not assignable to parameter of type`, run `npm run typegen`
108116

109117
## Installation
110118

0 commit comments

Comments
 (0)