Fix dashboard tests for Lakeview API behavior change (#4640)

## Changes

The server-side Lakeview API changed behavior in two ways:

1. `lakeview update` now returns the full `serialized_dashboard` in its
response, even when the update only changed other fields (e.g.
`display_name`). Previously it returned "{}".

2. `lakeview update` now clears fields not included in the request (e.g.
`warehouse_id`). Previously unspecified fields were preserved.

Both changes are consistent with a move from partial update (merge) to
full replace semantics on the Lakeview API's mutable fields.

## Tests

Update acceptance tests, testserver, and integration test to match.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: pietern

acceptance/bundle/generate/dashboard-inplace/output.txt

@@ -21,7 +21,7 @@ Deployment complete!
   "path":"/Users/[USERNAME]/.bundle/dashboard update inplace/default/resources/test dashboard.lvdash.json",
   "serialized_dashboard":"{\"a\":\"b\"}\n",
   "update_time":"[TIMESTAMP]",
-  "warehouse_id":"my-warehouse-1234"
+  "warehouse_id":""
 }
 
 === update the dashboard file using bundle generate

acceptance/bundle/resources/dashboards/detect-change/out.patch.requests.direct.txt

@@ -2,7 +2,8 @@
   "method": "PATCH",
   "path": "/api/2.0/lakeview/dashboards/[DASHBOARD_ID]",
   "body": {
-    "serialized_dashboard": "{}"
+    "serialized_dashboard": "{}",
+    "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
   }
 }
 {

acceptance/bundle/resources/dashboards/detect-change/out.patch.requests.terraform.txt

@@ -2,7 +2,8 @@
   "method": "PATCH",
   "path": "/api/2.0/lakeview/dashboards/[DASHBOARD_ID]",
   "body": {
-    "serialized_dashboard": "{}"
+    "serialized_dashboard": "{}",
+    "warehouse_id": "[TEST_DEFAULT_WAREHOUSE_ID]"
   }
 }
 {

acceptance/bundle/resources/dashboards/detect-change/script

@@ -29,7 +29,7 @@ $CLI lakeview get "${DASHBOARD_ID}" | jq '{display_name,page_display_name: (.ser
 
 title "Make an out of band modification to the dashboard and confirm that it is detected:\n"
 RESOURCE_ID=$($CLI workspace get-status "${DASHBOARD_PATH}" | jq -r '.resource_id')
-DASHBOARD_JSON='{"serialized_dashboard": "{}"}'
+DASHBOARD_JSON="{\"serialized_dashboard\": \"{}\", \"warehouse_id\": \"$TEST_DEFAULT_WAREHOUSE_ID\"}"
 $CLI lakeview update "${RESOURCE_ID}" --json "${DASHBOARD_JSON}" | jq '{lifecycle_state}'
 
 title "Try to redeploy the bundle and confirm that the out of band modification is detected:"

acceptance/bundle/resources/dashboards/generate_inplace/output.txt

@@ -9,7 +9,7 @@ Deployment complete!
 "{\n  \"uiSettings\": {\n    \"theme\": {\n      \"widgetHeaderAlignment\": \"ALIGNMENT_UNSPECIFIED\"\n    }\n  }\n}\n"
 
 === Update dashboard
-"{}\n"
+"{\n  \"uiSettings\": {\n    \"theme\": {\n      \"widgetHeaderAlignment\": \"ALIGNMENT_UNSPECIFIED\"\n    }\n  }\n}\n"
 
 >>> [CLI] bundle generate dashboard --resource already_exists
 Error: dashboard.lvdash.json already exists. Use --force to overwrite
@@ -30,7 +30,13 @@ Exit code: 1
 Writing dashboard to dashboard.lvdash.json
 
 >>> cat dashboard.lvdash.json
-{}
+{
+  "uiSettings": {
+    "theme": {
+      "widgetHeaderAlignment": "ALIGNMENT_UNSPECIFIED"
+    }
+  }
+}
 
 >>> [CLI] bundle destroy --auto-approve
 The following resources will be deleted:

integration/assumptions/dashboard_assumptions_test.go

@@ -88,11 +88,12 @@ func TestDashboardAssumptions_WorkspaceImport(t *testing.T) {
 		current, err := convert.FromTyped(currentDashboard, dyn.NilValue)
 		require.NoError(t, err)
 
-		// Collect updated paths.
+		// Collect updated and deleted paths.
 		var updatedFieldPaths []string
+		var deletedFieldPaths []string
 		_, err = merge.Override(previous, current, merge.OverrideVisitor{
 			VisitDelete: func(basePath dyn.Path, left dyn.Value) error {
-				assert.Fail(t, "unexpected delete operation")
+				deletedFieldPaths = append(deletedFieldPaths, basePath.String())
 				return nil
 			},
 			VisitInsert: func(basePath dyn.Path, right dyn.Value) (dyn.Value, error) {
@@ -111,5 +112,10 @@ func TestDashboardAssumptions_WorkspaceImport(t *testing.T) {
 			"etag",
 			"update_time",
 		}, updatedFieldPaths)
+
+		// The warehouse_id field is cleared after workspace import.
+		assert.ElementsMatch(t, []string{
+			"warehouse_id",
+		}, deletedFieldPaths)
 	}
 }

libs/testserver/dashboards.go

@@ -198,9 +198,7 @@ func (s *FakeWorkspace) DashboardUpdate(req Request) Response {
 		datasetSchema := req.URL.Query().Get("dataset_schema")
 		dashboard.SerializedDashboard = transformSerializedDashboard(updateReq.SerializedDashboard, datasetCatalog, datasetSchema)
 	}
-	if updateReq.WarehouseId != "" {
-		dashboard.WarehouseId = updateReq.WarehouseId
-	}
+	dashboard.WarehouseId = updateReq.WarehouseId
 	dashboard.UpdateTime = time.Now().UTC().Format(time.RFC3339)
 
 	s.Dashboards[dashboardId] = dashboard