Commit 3b7b63d
Fix alert threshold double_value with terraform engine (#4615)
## Summary
- The TF schema codegen maps `cty.Number` to Go `int` by default. The
alert `double_value` field was not in the `float64` allowlist, so
fractional values like `1.3` were dropped during normalization, causing
terraform to fail with `"evaluation.threshold is provided but doesn't
contain any value"`.
- Add alert `double_value` paths to the float64 allowlist and update the
generated schema types from `int` to `float64`.
## Test plan
- [x] Unit test `TestConvertAlertWithThresholdDoubleValue` verifies
fractional `double_value` survives normalization
- [x] Updated existing `acceptance/bundle/resources/alerts/basic`
acceptance test to use fractional `double_value: 1.3` instead of integer
`2`
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>1 parent 299af6c commit 3b7b63d
File tree
5 files changed
+46
-5
lines changed- acceptance/bundle/resources/alerts/basic
- bundle
- deploy/terraform/tfdyn
- internal/tf
- codegen/generator
- schema
5 files changed
+46
-5
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
36 | 39 | | |
37 | 40 | | |
38 | 41 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments