Address PR review feedback

- Revert tagging.yml and tagging.py to main (no version downgrades
  or mode changes from codegen)
- Remove user_agent_agent_test.go per reviewer feedback (we don't test
  other SDK-injected UA bits, no need to test this one)
- Fix govet nilness lint in workspaceClientOrPrompt: simplify needsPrompt
  logic to avoid tautological/impossible nil checks after the early
  return on successful auth

Co-authored-by: Isaac

Author: simonfaltum

.github/workflows/tagging.yml

@@ -34,13 +34,13 @@ jobs:
     steps:
       - name: Generate GitHub App Token
         id: generate-token
-        uses: actions/create-github-app-token@v2
+        uses: actions/create-github-app-token@v3
         with:
           app-id: ${{ secrets.DECO_SDK_TAGGING_APP_ID }}
           private-key: ${{ secrets.DECO_SDK_TAGGING_PRIVATE_KEY }}
 
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           fetch-depth: 0
           token: ${{ steps.generate-token.outputs.token }}

cmd/root/auth.go

@@ -189,32 +189,21 @@ func workspaceClientOrPrompt(ctx context.Context, cfg *config.Config, allowPromp
 		return w, nil
 	}
 
-	// Determine if we should prompt for a profile based on host type.
-	// The SDK no longer returns ErrNotWorkspaceClient from NewWorkspaceClient
-	// (as of v0.125.0, host-type validation was removed in favor of host
-	// metadata resolution). Use HostType() to detect the wrong host type.
-	var needsPrompt bool
-	switch cfg.HostType() {
-	case config.WorkspaceHost, config.UnifiedHost:
-		// Both workspace and unified hosts can serve workspace APIs.
-		needsPrompt = false
-	default:
-		// AccountHost or unknown: wrong type for workspace client.
-		needsPrompt = true
-	}
-	if !needsPrompt && err != nil && errors.Is(err, config.ErrCannotConfigureDefault) {
-		needsPrompt = true
-	}
+	// Determine if we should prompt for a profile. The SDK no longer returns
+	// ErrNotWorkspaceClient from NewWorkspaceClient (as of v0.125.0, host-type
+	// validation was removed in favor of host metadata resolution). Use
+	// HostType() to detect wrong host type, and check for ErrCannotConfigureDefault.
+	needsPrompt := cfg.HostType() == config.AccountHost ||
+		errors.Is(err, config.ErrCannotConfigureDefault)
 
 	if !needsPrompt {
 		return w, err
 	}
 
 	if !allowPrompt || !cmdio.IsPromptSupported(ctx) {
-		if err == nil {
-			err = databricks.ErrNotWorkspaceClient
-		}
-		return w, err
+		// Synthesize ErrNotWorkspaceClient so callers (like MustAnyClient)
+		// can detect the wrong config type and fall through to account client.
+		return w, databricks.ErrNotWorkspaceClient
 	}
 
 	// Try picking a profile dynamically if the current configuration is not valid.

cmd/root/auth_test.go

@@ -17,8 +17,14 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+type roundTripperFunc func(*http.Request) (*http.Response, error)
+
+func (f roundTripperFunc) RoundTrip(r *http.Request) (*http.Response, error) {
+	return f(r)
+}
+
 // noNetworkTransport prevents real HTTP calls in auth tests.
-// Returns 404 for all requests, preventing real HTTP calls during auth tests.
+// Returns 404 for all requests so host metadata resolution falls back gracefully.
 var noNetworkTransport = roundTripperFunc(func(r *http.Request) (*http.Response, error) {
 	return &http.Response{StatusCode: http.StatusNotFound, Body: http.NoBody}, nil
 })