Skip to content

Commit 275b67a

Browse files
Remove secrets from Claude Code workflow caller
The reusable Claude Code workflow in eng-dev-ecosystem now uses GitHub OIDC federation instead of static secrets, so callers no longer need to pass any credentials. Co-authored-by: Isaac
1 parent f2bc990 commit 275b67a

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

.github/workflows/claude-code.yml

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,26 +15,23 @@ jobs:
1515
review:
1616
if: github.event_name == 'pull_request'
1717
uses: databricks-eng/eng-dev-ecosystem/.github/workflows/claude-code.yml@main
18-
secrets:
19-
DATABRICKS_SP_CLIENT_ID: ${{ secrets.DATABRICKS_SP_CLIENT_ID }}
20-
DATABRICKS_SP_CLIENT_SECRET: ${{ secrets.DATABRICKS_SP_CLIENT_SECRET }}
2118
with:
22-
prompt: "Review this PR. Focus on correctness, error handling, and adherence to the project's Go conventions documented in CLAUDE.md."
19+
prompt: "Review this PR. Focus on correctness, error handling, and adherence to the project's Go conventions documented in CLAUDE.md. Post your review as a PR comment. If you have no issues to raise, post a short comment saying the PR looks good."
2320
allowed_tools: |
21+
Bash(gh pr diff)
22+
Bash(gh pr comment)
23+
Bash(grep)
2424
Read
2525
Glob
2626
Grep
27-
claude_args: "--max-turns 10"
27+
claude_args: "--max-turns 100"
2828

2929
# Interactive @claude mentions — Claude can make changes and push commits.
3030
assist:
3131
if: |
3232
(github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) ||
3333
(github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude'))
3434
uses: databricks-eng/eng-dev-ecosystem/.github/workflows/claude-code.yml@main
35-
secrets:
36-
DATABRICKS_SP_CLIENT_ID: ${{ secrets.DATABRICKS_SP_CLIENT_ID }}
37-
DATABRICKS_SP_CLIENT_SECRET: ${{ secrets.DATABRICKS_SP_CLIENT_SECRET }}
3835
with:
3936
allowed_tools: |
4037
Bash(make lint)
@@ -46,4 +43,4 @@ jobs:
4643
Write
4744
Glob
4845
Grep
49-
claude_args: "--max-turns 20"
46+
claude_args: "--max-turns 100"

0 commit comments

Comments
 (0)