Commit 11c9d86
Fix line ending related integration failures (#4256)
## Why
The root cause of TestExport and TestImportDir test failures was that we
relied on the backend to normalize line endings. Previously, the backend
would normalize line endings during import/export. Starting 2025-12-16,
the backend changed to preserve line endings exactly as provided,
without any normalization.
This change fixes the tests by:
1. Including trailing newlines in input notebook content that we upload
(fixes TestExport and TestExportWithFileFlag)
2. Adding integration/.gitattributes to enforce LF line endings on all
platforms (Linux, Mac, Windows) for test files (fixes TestImportDir,
TestImportDirDoesNotOverwrite, TestImportDirWithOverwriteFlag,
TestImportFileFormatAuto, TestImportFileFormatSource)
By sending payloads with the expected line endings and ensuring
consistent checkout behavior via .gitattributes, the tests now validate
correct round-trip behavior across all platforms.
Without .gitattributes, Windows would check out test files with CRLF,
causing the uploaded content to differ from what Linux/Mac upload,
leading to platform-specific test failures.
## Tests
The mentioned tests should show up as "recovered" in this run.
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent a2ed757 commit 11c9d86
2 files changed
+11
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
279 | 279 | | |
280 | 280 | | |
281 | 281 | | |
282 | | - | |
| 282 | + | |
283 | 283 | | |
284 | 284 | | |
285 | 285 | | |
| |||
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
314 | | - | |
| 314 | + | |
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
| |||
0 commit comments