Skip to content

Commit 02642c5

Browse files
committed
remove --summary-file changes (will be in separate PR)
1 parent 5271caa commit 02642c5

File tree

2 files changed

+1
-19
lines changed

2 files changed

+1
-19
lines changed

tools/gh_parse.py

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ def mark_known_failures(results, known_failures_config):
353353
return marked_results
354354

355355

356-
def print_report(filenames, filter, filter_env, show_output, markdown=False, omit_repl=False, summary_file=None):
356+
def print_report(filenames, filter, filter_env, show_output, markdown=False, omit_repl=False):
357357
known_failures_config = load_known_failures()
358358
outputs = {} # test_key -> env -> [output]
359359
per_test_per_env_stats = {} # test_key -> env -> action -> count
@@ -536,25 +536,12 @@ def key(column):
536536
}
537537
)
538538
table_txt = format_table(table, markdown=markdown)
539-
summary_msg = None
540539
if len(table) > 5:
541540
summary_msg = make_summary_message(table, summary)
542541
table_txt = wrap_in_details(table_txt, summary_msg)
543542
if table_txt:
544543
print(table_txt)
545544

546-
# Write summary to file if requested
547-
if summary_file:
548-
if summary_msg:
549-
Path(summary_file).write_text(summary_msg)
550-
elif len(table) > 0:
551-
# If we have tests but not enough for full summary, create a simple one
552-
summary_msg = make_summary_message(table, summary)
553-
Path(summary_file).write_text(summary_msg)
554-
else:
555-
# No interesting tests found
556-
Path(summary_file).write_text("All tests passed")
557-
558545
# Generate slowest tests table (tests slower than 10 minutes)
559546
all_durations = [] # [(env, package, testname, duration), ...]
560547
for env, env_durations in durations_by_env.items():
@@ -704,7 +691,6 @@ def main():
704691
help="Omit lines starting with 'REPL' and containing 'Available replacements:'",
705692
action="store_true",
706693
)
707-
parser.add_argument("--summary-file", help="Write summary line to this file")
708694
args = parser.parse_args()
709695
print_report(
710696
args.filenames,
@@ -713,7 +699,6 @@ def main():
713699
show_output=args.output,
714700
markdown=args.markdown,
715701
omit_repl=args.omit_repl,
716-
summary_file=args.summary_file,
717702
)
718703

719704

tools/gh_report.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,6 @@ def main():
175175
help="Omit lines starting with 'REPL' and containing 'Available replacements:'",
176176
action="store_true",
177177
)
178-
parser.add_argument("--summary-file", help="Write summary line to this file")
179178

180179
# This does not work because we don't store artifacts for unit tests. We could download logs instead but that requires different parsing method:
181180
# ~/work/cli % gh api -H "Accept: application/vnd.github+json" /repos/databricks/cli/actions/runs/15827411452/logs > logs.zip
@@ -218,8 +217,6 @@ def main():
218217
cmd.append("--markdown")
219218
if args.omit_repl:
220219
cmd.append("--omit-repl")
221-
if args.summary_file:
222-
cmd.extend(["--summary-file", args.summary_file])
223220
cmd.append(f"{target_dir}")
224221
run(cmd, shell=True)
225222

0 commit comments

Comments
 (0)