Remove FetchLatestRelease, use GetSkillsRef for version resolution

After squash-merge of PR2, FetchLatestRelease was replaced with
getSkillsRef. Export it as GetSkillsRef and update all PR3 code
(update.go, version.go, tests) to use the config-based ref instead
of the removed GitHub API release lookup.

Co-authored-by: Isaac

Author: simonfaltum

experimental/aitools/cmd/version.go

@@ -6,8 +6,6 @@ import (
 
 	"github.com/databricks/cli/experimental/aitools/lib/installer"
 	"github.com/databricks/cli/libs/cmdio"
-	"github.com/databricks/cli/libs/env"
-	"github.com/databricks/cli/libs/log"
 	"github.com/spf13/cobra"
 )
 
@@ -41,36 +39,14 @@ func newVersionCmd() *cobra.Command {
 				skillNoun = "skill"
 			}
 
-			// Best-effort staleness check.
-			if env.Get(ctx, "DATABRICKS_SKILLS_REF") != "" {
-				cmdio.LogString(ctx, "Databricks AI Tools:")
-				cmdio.LogString(ctx, fmt.Sprintf("  Skills: v%s (%d %s)", version, len(state.Skills), skillNoun))
-				cmdio.LogString(ctx, "  Last updated: "+state.LastUpdated.Format("2006-01-02"))
-				cmdio.LogString(ctx, "  Using custom ref: $DATABRICKS_SKILLS_REF")
-				return nil
-			}
-
-			src := &installer.GitHubManifestSource{}
-			latest, authoritative, err := src.FetchLatestRelease(ctx)
-			if err != nil {
-				log.Debugf(ctx, "Could not check for updates: %v", err)
-				authoritative = false
-			}
-
 			cmdio.LogString(ctx, "Databricks AI Tools:")
 
-			if !authoritative {
-				cmdio.LogString(ctx, fmt.Sprintf("  Skills: v%s (%d %s)", version, len(state.Skills), skillNoun))
-				cmdio.LogString(ctx, "  Last updated: "+state.LastUpdated.Format("2006-01-02"))
-				cmdio.LogString(ctx, "  Could not check for latest version.")
-				return nil
-			}
-
-			if latest == state.Release {
+			latestRef := installer.GetSkillsRef(ctx)
+			if latestRef == state.Release {
 				cmdio.LogString(ctx, fmt.Sprintf("  Skills: v%s (%d %s, up to date)", version, len(state.Skills), skillNoun))
 				cmdio.LogString(ctx, "  Last updated: "+state.LastUpdated.Format("2006-01-02"))
 			} else {
-				latestVersion := strings.TrimPrefix(latest, "v")
+				latestVersion := strings.TrimPrefix(latestRef, "v")
 				cmdio.LogString(ctx, fmt.Sprintf("  Skills: v%s (%d %s)", version, len(state.Skills), skillNoun))
 				cmdio.LogString(ctx, "  Update available: v"+latestVersion)
 				cmdio.LogString(ctx, "  Last updated: "+state.LastUpdated.Format("2006-01-02"))

experimental/aitools/lib/installer/installer.go

@@ -32,7 +32,9 @@ const (
 // It is a package-level var so tests can replace it with a mock.
 var fetchFileFn = fetchSkillFile
 
-func getSkillsRef(ctx context.Context) string {
+// GetSkillsRef returns the skills repo ref to use. If DATABRICKS_SKILLS_REF
+// is set, it returns that value; otherwise it returns the default ref.
+func GetSkillsRef(ctx context.Context) string {
 	if ref := env.Get(ctx, "DATABRICKS_SKILLS_REF"); ref != "" {
 		return ref
 	}
@@ -66,7 +68,7 @@ type InstallOptions struct {
 // This is a convenience wrapper that uses the default GitHubManifestSource.
 func FetchManifest(ctx context.Context) (*Manifest, error) {
 	src := &GitHubManifestSource{}
-	ref := getSkillsRef(ctx)
+	ref := GetSkillsRef(ctx)
 	return src.FetchManifest(ctx, ref)
 }
 
@@ -117,7 +119,7 @@ func ListSkills(ctx context.Context) error {
 // This is the core installation function. Callers are responsible for agent detection,
 // prompting, and printing the "Installing..." header.
 func InstallSkillsForAgents(ctx context.Context, src ManifestSource, targetAgents []*agents.Agent, opts InstallOptions) error {
-	ref := getSkillsRef(ctx)
+	ref := GetSkillsRef(ctx)
 	manifest, err := src.FetchManifest(ctx, ref)
 	if err != nil {
 		return err

experimental/aitools/lib/installer/uninstall_test.go

@@ -18,7 +18,7 @@ func installTestSkills(t *testing.T, tmp string) string {
 	ctx := cmdio.MockDiscard(t.Context())
 	setupFetchMock(t)
 
-	src := &mockManifestSource{manifest: testManifest(), release: "v0.1.0", authoritative: true}
+	src := &mockManifestSource{manifest: testManifest()}
 	agent := testAgent(tmp)
 	require.NoError(t, InstallSkillsForAgents(ctx, src, []*agents.Agent{agent}, InstallOptions{}))
 
@@ -68,7 +68,7 @@ func TestUninstallRemovesSymlinks(t *testing.T) {
 		},
 	}
 
-	src := &mockManifestSource{manifest: testManifest(), release: "v0.1.0", authoritative: true}
+	src := &mockManifestSource{manifest: testManifest()}
 	require.NoError(t, InstallSkillsForAgents(ctx, src, []*agents.Agent{claudeAgent, cursorAgent}, InstallOptions{}))
 
 	ctx2, _ := cmdio.NewTestContextWithStderr(t.Context())

experimental/aitools/lib/installer/update.go

@@ -59,15 +59,7 @@ func UpdateSkills(ctx context.Context, src ManifestSource, targetAgents []*agent
 		return nil, errors.New("no skills installed. Run 'databricks experimental aitools install' to install")
 	}
 
-	latestTag, authoritative, err := src.FetchLatestRelease(ctx)
-	if err != nil {
-		return nil, fmt.Errorf("failed to fetch latest release: %w", err)
-	}
-
-	if !authoritative && !opts.Force {
-		cmdio.LogString(ctx, "Could not check for updates (offline?). Use --force to update anyway.")
-		return &UpdateResult{Unchanged: sortedKeys(state.Skills)}, nil
-	}
+	latestTag := GetSkillsRef(ctx)
 
 	if state.Release == latestTag && !opts.Force {
 		cmdio.LogString(ctx, "Already up to date.")