From 6de940cb40bf9dc23e2579dc40609147270ecadf Mon Sep 17 00:00:00 2001 From: psainics Date: Thu, 23 Jan 2025 05:50:25 +0530 Subject: [PATCH] Return null for ErrorDetailsProvider by default --- .../main/java/io/cdap/plugin/db/sink/AbstractDBSink.java | 6 ++++-- .../java/io/cdap/plugin/db/source/AbstractDBSource.java | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/database-commons/src/main/java/io/cdap/plugin/db/sink/AbstractDBSink.java b/database-commons/src/main/java/io/cdap/plugin/db/sink/AbstractDBSink.java index 26a95405b..63d9bd415 100644 --- a/database-commons/src/main/java/io/cdap/plugin/db/sink/AbstractDBSink.java +++ b/database-commons/src/main/java/io/cdap/plugin/db/sink/AbstractDBSink.java @@ -172,7 +172,7 @@ public void validateOperations(FailureCollector collector, T dbSinkConfig, @Null * @return ErrorDetailsProvider class name */ protected String getErrorDetailsProviderClassName() { - return DBErrorDetailsProvider.class.getName(); + return null; } @Override @@ -240,7 +240,9 @@ public void prepareRun(BatchSinkContext context) { context.getArguments().get(ETLDBOutputFormat.COMMIT_BATCH_SIZE)); } // set error details provider - context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName())); + if (!Strings.isNullOrEmpty(getErrorDetailsProviderClassName())) { + context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName())); + } addOutputContext(context); } protected void addOutputContext(BatchSinkContext context) { diff --git a/database-commons/src/main/java/io/cdap/plugin/db/source/AbstractDBSource.java b/database-commons/src/main/java/io/cdap/plugin/db/source/AbstractDBSource.java index 559985758..aefa629ce 100644 --- a/database-commons/src/main/java/io/cdap/plugin/db/source/AbstractDBSource.java +++ b/database-commons/src/main/java/io/cdap/plugin/db/source/AbstractDBSource.java @@ -239,7 +239,7 @@ protected SchemaReader getSchemaReader() { * @return ErrorDetailsProvider class name */ protected String getErrorDetailsProviderClassName() { - return DBErrorDetailsProvider.class.getName(); + return null; } private DriverCleanup loadPluginClassAndGetDriver(Class driverClass) @@ -299,7 +299,9 @@ public void prepareRun(BatchSourceContext context) throws Exception { schema.getFields().stream().map(Schema.Field::getName).collect(Collectors.toList())); } // set error details provider - context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName())); + if (!Strings.isNullOrEmpty(getErrorDetailsProviderClassName())) { + context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName())); + } context.setInput(Input.of(sourceConfig.getReferenceName(), new SourceInputFormatProvider( DataDrivenETLDBInputFormat.class, connectionConfigAccessor.getConfiguration()))); }