From 599bda96f72e0a9c05765af2a34ec0f1a1f7aeb6 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Mon, 14 Jul 2025 22:37:53 +0000 Subject: [PATCH 1/3] feat: Add ASAN workflow This commit adds a new job to the `R-CMD-check.yaml` workflow to run AddressSanitizer (ASan) tests. This will help in detecting memory errors in the package. --- .github/workflows/R-CMD-check.yaml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml index 14159b7..ef1c75b 100644 --- a/.github/workflows/R-CMD-check.yaml +++ b/.github/workflows/R-CMD-check.yaml @@ -48,3 +48,24 @@ jobs: with: upload-snapshots: true build_args: 'c("--no-manual","--compact-vignettes=gs+qpdf")' + ASan: + runs-on: ubuntu-latest + name: ASan + env: + _R_CHECK_ASAN_: true + steps: + - uses: actions/checkout@v4 + + - uses: r-lib/actions/setup-pandoc@v2 + + - uses: r-lib/actions/setup-r@v2 + with: + r-version: 'release' + + - uses: r-lib/actions/setup-r-dependencies@v2 + with: + extra-packages: any::rcmdcheck + needs: check + + - name: Run tests with ASan + run: rcmdcheck::rcmdcheck(args = "--no-manual", error_on = "warning", check_dir = "check") From 05a3666afa1f3c584a72727259f9fd744bcd9b41 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Mon, 14 Jul 2025 22:49:17 +0000 Subject: [PATCH 2/3] fix: Correct syntax in ASAN workflow This commit fixes a syntax error in the ASAN workflow by wrapping the `rcmdcheck::rcmdcheck()` command in `R -e '...'` to execute it as an R command. --- .github/workflows/R-CMD-check.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml index ef1c75b..b7af824 100644 --- a/.github/workflows/R-CMD-check.yaml +++ b/.github/workflows/R-CMD-check.yaml @@ -68,4 +68,4 @@ jobs: needs: check - name: Run tests with ASan - run: rcmdcheck::rcmdcheck(args = "--no-manual", error_on = "warning", check_dir = "check") + run: R -e 'rcmdcheck::rcmdcheck(args = "--no-manual", error_on = "warning", check_dir = "check")' From ba569a5d72004bda62bacd8949e2bad253c5a882 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Mon, 14 Jul 2025 22:49:37 +0000 Subject: [PATCH 3/3] fix: Correct syntax in ASAN workflow This commit fixes a syntax error in the ASAN workflow by wrapping the `rcmdcheck::rcmdcheck()` command in `R -e '...'` to execute it as an R command.