From fa806c156f30157b31b2f67480dd8def121dc8bf Mon Sep 17 00:00:00 2001 From: keemsisi Date: Sat, 30 Aug 2025 03:02:41 +0100 Subject: [PATCH] Added support for varchar for postgres engine, and unified webview message devdb-view-provider.ts --- src/database-engines/postgres-engine.ts | 2 +- src/devdb-view-provider.ts | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/database-engines/postgres-engine.ts b/src/database-engines/postgres-engine.ts index d4cc173..53ef5ce 100644 --- a/src/database-engines/postgres-engine.ts +++ b/src/database-engines/postgres-engine.ts @@ -158,7 +158,7 @@ export class PostgresEngine implements DatabaseEngine { } getPlainStringTypes(): string[] { - return ['character', 'character varying', 'text', 'json', 'jsonb']; + return ['character', 'character varying', 'varchar', 'char', 'text', 'json', 'jsonb']; } async getTotalRows(table: string, columns: Column[], whereClause?: Record): Promise { diff --git a/src/devdb-view-provider.ts b/src/devdb-view-provider.ts index e994dcb..5547518 100644 --- a/src/devdb-view-provider.ts +++ b/src/devdb-view-provider.ts @@ -9,6 +9,7 @@ import { logToOutput } from './services/output-service'; export class DevDbViewProvider implements vscode.WebviewViewProvider { public static readonly viewType = 'devdb'; + private static readonly webViewNotAvailableMsg = `Message received but the webview not available`; private _view?: vscode.WebviewView; private _extensionUri: vscode.Uri; @@ -42,7 +43,7 @@ export class DevDbViewProvider implements vscode.WebviewViewProvider { webviewView.webview.html = getWebviewHtml(webviewView.webview, this.jsFile, this.cssFile, this._extensionUri); webviewView.webview.onDidReceiveMessage(async (data) => { - if (!this._view) return logToOutput(`Message received but the webview not available`) + if (!this._view) return logToOutput(DevDbViewProvider.webViewNotAvailableMsg) await handleIncomingMessage(data, this._view) }); @@ -54,7 +55,7 @@ export class DevDbViewProvider implements vscode.WebviewViewProvider { } public setActiveTable(table: string) { - if (!this._view) return logToOutput(`Message received but the webview not available`) + if (!this._view) return logToOutput(DevDbViewProvider.webViewNotAvailableMsg) if (!isTablesLoaded()) { return showEmptyTablesNotification() @@ -67,7 +68,7 @@ export class DevDbViewProvider implements vscode.WebviewViewProvider { } public async sendUnsolicitedResponse(command: string, response: unknown) { - if (!this._view) return logToOutput(`Message received but the webview not available`) + if (!this._view) return logToOutput(DevDbViewProvider.webViewNotAvailableMsg) await reply(this._view.webview, command, response) }