From 5c2740c77aac7dcfe5273a752f4752a2ff67dbc9 Mon Sep 17 00:00:00 2001 From: Dani Date: Thu, 26 Mar 2026 07:16:44 +0100 Subject: [PATCH 1/2] First commit --- products/.gitattributes | 2 + products/.gitignore | 33 ++ .../.mvn/wrapper/maven-wrapper.properties | 3 + products/mvnw | 295 ++++++++++++++++++ products/mvnw.cmd | 189 +++++++++++ products/pom.xml | 68 ++++ .../products/ProductsApplication.java | 13 + .../products/client/ProductApiClient.java | 13 + .../products/client/ProductApiClientImpl.java | 40 +++ .../products/config/CacheConfig.java | 27 ++ .../products/config/RestClientConfig.java | 31 ++ .../controller/ProductController.java | 30 ++ .../products/dto/ProductDetailFailure.java | 4 + .../products/dto/ProductDetailResult.java | 18 ++ .../products/dto/ProductDetailsResponse.java | 8 + .../products/dto/ProductResponse.java | 9 + .../products/exception/ErrorResponse.java | 4 + .../products/exception/GlobalException.java | 17 + .../exception/GlobalExceptionHandler.java | 30 ++ .../service/SimilarProductService.java | 13 + .../service/SimilarProductServiceImpl.java | 91 ++++++ products/src/main/resources/application.yaml | 15 + .../products/ProductsApplicationTests.java | 13 + .../client/ProductApiClientImplTest.java | 16 + .../controller/ProductControllerTest.java | 12 + .../SimilarProductServiceImplTest.java | 12 + 26 files changed, 1006 insertions(+) create mode 100644 products/.gitattributes create mode 100644 products/.gitignore create mode 100644 products/.mvn/wrapper/maven-wrapper.properties create mode 100644 products/mvnw create mode 100644 products/mvnw.cmd create mode 100644 products/pom.xml create mode 100644 products/src/main/java/com/danivelasco/products/ProductsApplication.java create mode 100644 products/src/main/java/com/danivelasco/products/client/ProductApiClient.java create mode 100644 products/src/main/java/com/danivelasco/products/client/ProductApiClientImpl.java create mode 100644 products/src/main/java/com/danivelasco/products/config/CacheConfig.java create mode 100644 products/src/main/java/com/danivelasco/products/config/RestClientConfig.java create mode 100644 products/src/main/java/com/danivelasco/products/controller/ProductController.java create mode 100644 products/src/main/java/com/danivelasco/products/dto/ProductDetailFailure.java create mode 100644 products/src/main/java/com/danivelasco/products/dto/ProductDetailResult.java create mode 100644 products/src/main/java/com/danivelasco/products/dto/ProductDetailsResponse.java create mode 100644 products/src/main/java/com/danivelasco/products/dto/ProductResponse.java create mode 100644 products/src/main/java/com/danivelasco/products/exception/ErrorResponse.java create mode 100644 products/src/main/java/com/danivelasco/products/exception/GlobalException.java create mode 100644 products/src/main/java/com/danivelasco/products/exception/GlobalExceptionHandler.java create mode 100644 products/src/main/java/com/danivelasco/products/service/SimilarProductService.java create mode 100644 products/src/main/java/com/danivelasco/products/service/SimilarProductServiceImpl.java create mode 100644 products/src/main/resources/application.yaml create mode 100644 products/src/test/java/com/danivelasco/products/ProductsApplicationTests.java create mode 100644 products/src/test/java/com/danivelasco/products/client/ProductApiClientImplTest.java create mode 100644 products/src/test/java/com/danivelasco/products/controller/ProductControllerTest.java create mode 100644 products/src/test/java/com/danivelasco/products/service/SimilarProductServiceImplTest.java diff --git a/products/.gitattributes b/products/.gitattributes new file mode 100644 index 00000000..3b41682a --- /dev/null +++ b/products/.gitattributes @@ -0,0 +1,2 @@ +/mvnw text eol=lf +*.cmd text eol=crlf diff --git a/products/.gitignore b/products/.gitignore new file mode 100644 index 00000000..667aaef0 --- /dev/null +++ b/products/.gitignore @@ -0,0 +1,33 @@ +HELP.md +target/ +.mvn/wrapper/maven-wrapper.jar +!**/src/main/**/target/ +!**/src/test/**/target/ + +### STS ### +.apt_generated +.classpath +.factorypath +.project +.settings +.springBeans +.sts4-cache + +### IntelliJ IDEA ### +.idea +*.iws +*.iml +*.ipr + +### NetBeans ### +/nbproject/private/ +/nbbuild/ +/dist/ +/nbdist/ +/.nb-gradle/ +build/ +!**/src/main/**/build/ +!**/src/test/**/build/ + +### VS Code ### +.vscode/ diff --git a/products/.mvn/wrapper/maven-wrapper.properties b/products/.mvn/wrapper/maven-wrapper.properties new file mode 100644 index 00000000..c595b009 --- /dev/null +++ b/products/.mvn/wrapper/maven-wrapper.properties @@ -0,0 +1,3 @@ +wrapperVersion=3.3.4 +distributionType=only-script +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.14/apache-maven-3.9.14-bin.zip diff --git a/products/mvnw b/products/mvnw new file mode 100644 index 00000000..bd8896bf --- /dev/null +++ b/products/mvnw @@ -0,0 +1,295 @@ +#!/bin/sh +# ---------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# ---------------------------------------------------------------------------- + +# ---------------------------------------------------------------------------- +# Apache Maven Wrapper startup batch script, version 3.3.4 +# +# Optional ENV vars +# ----------------- +# JAVA_HOME - location of a JDK home dir, required when download maven via java source +# MVNW_REPOURL - repo url base for downloading maven distribution +# MVNW_USERNAME/MVNW_PASSWORD - user and password for downloading maven +# MVNW_VERBOSE - true: enable verbose log; debug: trace the mvnw script; others: silence the output +# ---------------------------------------------------------------------------- + +set -euf +[ "${MVNW_VERBOSE-}" != debug ] || set -x + +# OS specific support. +native_path() { printf %s\\n "$1"; } +case "$(uname)" in +CYGWIN* | MINGW*) + [ -z "${JAVA_HOME-}" ] || JAVA_HOME="$(cygpath --unix "$JAVA_HOME")" + native_path() { cygpath --path --windows "$1"; } + ;; +esac + +# set JAVACMD and JAVACCMD +set_java_home() { + # For Cygwin and MinGW, ensure paths are in Unix format before anything is touched + if [ -n "${JAVA_HOME-}" ]; then + if [ -x "$JAVA_HOME/jre/sh/java" ]; then + # IBM's JDK on AIX uses strange locations for the executables + JAVACMD="$JAVA_HOME/jre/sh/java" + JAVACCMD="$JAVA_HOME/jre/sh/javac" + else + JAVACMD="$JAVA_HOME/bin/java" + JAVACCMD="$JAVA_HOME/bin/javac" + + if [ ! -x "$JAVACMD" ] || [ ! -x "$JAVACCMD" ]; then + echo "The JAVA_HOME environment variable is not defined correctly, so mvnw cannot run." >&2 + echo "JAVA_HOME is set to \"$JAVA_HOME\", but \"\$JAVA_HOME/bin/java\" or \"\$JAVA_HOME/bin/javac\" does not exist." >&2 + return 1 + fi + fi + else + JAVACMD="$( + 'set' +e + 'unset' -f command 2>/dev/null + 'command' -v java + )" || : + JAVACCMD="$( + 'set' +e + 'unset' -f command 2>/dev/null + 'command' -v javac + )" || : + + if [ ! -x "${JAVACMD-}" ] || [ ! -x "${JAVACCMD-}" ]; then + echo "The java/javac command does not exist in PATH nor is JAVA_HOME set, so mvnw cannot run." >&2 + return 1 + fi + fi +} + +# hash string like Java String::hashCode +hash_string() { + str="${1:-}" h=0 + while [ -n "$str" ]; do + char="${str%"${str#?}"}" + h=$(((h * 31 + $(LC_CTYPE=C printf %d "'$char")) % 4294967296)) + str="${str#?}" + done + printf %x\\n $h +} + +verbose() { :; } +[ "${MVNW_VERBOSE-}" != true ] || verbose() { printf %s\\n "${1-}"; } + +die() { + printf %s\\n "$1" >&2 + exit 1 +} + +trim() { + # MWRAPPER-139: + # Trims trailing and leading whitespace, carriage returns, tabs, and linefeeds. + # Needed for removing poorly interpreted newline sequences when running in more + # exotic environments such as mingw bash on Windows. + printf "%s" "${1}" | tr -d '[:space:]' +} + +scriptDir="$(dirname "$0")" +scriptName="$(basename "$0")" + +# parse distributionUrl and optional distributionSha256Sum, requires .mvn/wrapper/maven-wrapper.properties +while IFS="=" read -r key value; do + case "${key-}" in + distributionUrl) distributionUrl=$(trim "${value-}") ;; + distributionSha256Sum) distributionSha256Sum=$(trim "${value-}") ;; + esac +done <"$scriptDir/.mvn/wrapper/maven-wrapper.properties" +[ -n "${distributionUrl-}" ] || die "cannot read distributionUrl property in $scriptDir/.mvn/wrapper/maven-wrapper.properties" + +case "${distributionUrl##*/}" in +maven-mvnd-*bin.*) + MVN_CMD=mvnd.sh _MVNW_REPO_PATTERN=/maven/mvnd/ + case "${PROCESSOR_ARCHITECTURE-}${PROCESSOR_ARCHITEW6432-}:$(uname -a)" in + *AMD64:CYGWIN* | *AMD64:MINGW*) distributionPlatform=windows-amd64 ;; + :Darwin*x86_64) distributionPlatform=darwin-amd64 ;; + :Darwin*arm64) distributionPlatform=darwin-aarch64 ;; + :Linux*x86_64*) distributionPlatform=linux-amd64 ;; + *) + echo "Cannot detect native platform for mvnd on $(uname)-$(uname -m), use pure java version" >&2 + distributionPlatform=linux-amd64 + ;; + esac + distributionUrl="${distributionUrl%-bin.*}-$distributionPlatform.zip" + ;; +maven-mvnd-*) MVN_CMD=mvnd.sh _MVNW_REPO_PATTERN=/maven/mvnd/ ;; +*) MVN_CMD="mvn${scriptName#mvnw}" _MVNW_REPO_PATTERN=/org/apache/maven/ ;; +esac + +# apply MVNW_REPOURL and calculate MAVEN_HOME +# maven home pattern: ~/.m2/wrapper/dists/{apache-maven-,maven-mvnd--}/ +[ -z "${MVNW_REPOURL-}" ] || distributionUrl="$MVNW_REPOURL$_MVNW_REPO_PATTERN${distributionUrl#*"$_MVNW_REPO_PATTERN"}" +distributionUrlName="${distributionUrl##*/}" +distributionUrlNameMain="${distributionUrlName%.*}" +distributionUrlNameMain="${distributionUrlNameMain%-bin}" +MAVEN_USER_HOME="${MAVEN_USER_HOME:-${HOME}/.m2}" +MAVEN_HOME="${MAVEN_USER_HOME}/wrapper/dists/${distributionUrlNameMain-}/$(hash_string "$distributionUrl")" + +exec_maven() { + unset MVNW_VERBOSE MVNW_USERNAME MVNW_PASSWORD MVNW_REPOURL || : + exec "$MAVEN_HOME/bin/$MVN_CMD" "$@" || die "cannot exec $MAVEN_HOME/bin/$MVN_CMD" +} + +if [ -d "$MAVEN_HOME" ]; then + verbose "found existing MAVEN_HOME at $MAVEN_HOME" + exec_maven "$@" +fi + +case "${distributionUrl-}" in +*?-bin.zip | *?maven-mvnd-?*-?*.zip) ;; +*) die "distributionUrl is not valid, must match *-bin.zip or maven-mvnd-*.zip, but found '${distributionUrl-}'" ;; +esac + +# prepare tmp dir +if TMP_DOWNLOAD_DIR="$(mktemp -d)" && [ -d "$TMP_DOWNLOAD_DIR" ]; then + clean() { rm -rf -- "$TMP_DOWNLOAD_DIR"; } + trap clean HUP INT TERM EXIT +else + die "cannot create temp dir" +fi + +mkdir -p -- "${MAVEN_HOME%/*}" + +# Download and Install Apache Maven +verbose "Couldn't find MAVEN_HOME, downloading and installing it ..." +verbose "Downloading from: $distributionUrl" +verbose "Downloading to: $TMP_DOWNLOAD_DIR/$distributionUrlName" + +# select .zip or .tar.gz +if ! command -v unzip >/dev/null; then + distributionUrl="${distributionUrl%.zip}.tar.gz" + distributionUrlName="${distributionUrl##*/}" +fi + +# verbose opt +__MVNW_QUIET_WGET=--quiet __MVNW_QUIET_CURL=--silent __MVNW_QUIET_UNZIP=-q __MVNW_QUIET_TAR='' +[ "${MVNW_VERBOSE-}" != true ] || __MVNW_QUIET_WGET='' __MVNW_QUIET_CURL='' __MVNW_QUIET_UNZIP='' __MVNW_QUIET_TAR=v + +# normalize http auth +case "${MVNW_PASSWORD:+has-password}" in +'') MVNW_USERNAME='' MVNW_PASSWORD='' ;; +has-password) [ -n "${MVNW_USERNAME-}" ] || MVNW_USERNAME='' MVNW_PASSWORD='' ;; +esac + +if [ -z "${MVNW_USERNAME-}" ] && command -v wget >/dev/null; then + verbose "Found wget ... using wget" + wget ${__MVNW_QUIET_WGET:+"$__MVNW_QUIET_WGET"} "$distributionUrl" -O "$TMP_DOWNLOAD_DIR/$distributionUrlName" || die "wget: Failed to fetch $distributionUrl" +elif [ -z "${MVNW_USERNAME-}" ] && command -v curl >/dev/null; then + verbose "Found curl ... using curl" + curl ${__MVNW_QUIET_CURL:+"$__MVNW_QUIET_CURL"} -f -L -o "$TMP_DOWNLOAD_DIR/$distributionUrlName" "$distributionUrl" || die "curl: Failed to fetch $distributionUrl" +elif set_java_home; then + verbose "Falling back to use Java to download" + javaSource="$TMP_DOWNLOAD_DIR/Downloader.java" + targetZip="$TMP_DOWNLOAD_DIR/$distributionUrlName" + cat >"$javaSource" <<-END + public class Downloader extends java.net.Authenticator + { + protected java.net.PasswordAuthentication getPasswordAuthentication() + { + return new java.net.PasswordAuthentication( System.getenv( "MVNW_USERNAME" ), System.getenv( "MVNW_PASSWORD" ).toCharArray() ); + } + public static void main( String[] args ) throws Exception + { + setDefault( new Downloader() ); + java.nio.file.Files.copy( java.net.URI.create( args[0] ).toURL().openStream(), java.nio.file.Paths.get( args[1] ).toAbsolutePath().normalize() ); + } + } + END + # For Cygwin/MinGW, switch paths to Windows format before running javac and java + verbose " - Compiling Downloader.java ..." + "$(native_path "$JAVACCMD")" "$(native_path "$javaSource")" || die "Failed to compile Downloader.java" + verbose " - Running Downloader.java ..." + "$(native_path "$JAVACMD")" -cp "$(native_path "$TMP_DOWNLOAD_DIR")" Downloader "$distributionUrl" "$(native_path "$targetZip")" +fi + +# If specified, validate the SHA-256 sum of the Maven distribution zip file +if [ -n "${distributionSha256Sum-}" ]; then + distributionSha256Result=false + if [ "$MVN_CMD" = mvnd.sh ]; then + echo "Checksum validation is not supported for maven-mvnd." >&2 + echo "Please disable validation by removing 'distributionSha256Sum' from your maven-wrapper.properties." >&2 + exit 1 + elif command -v sha256sum >/dev/null; then + if echo "$distributionSha256Sum $TMP_DOWNLOAD_DIR/$distributionUrlName" | sha256sum -c - >/dev/null 2>&1; then + distributionSha256Result=true + fi + elif command -v shasum >/dev/null; then + if echo "$distributionSha256Sum $TMP_DOWNLOAD_DIR/$distributionUrlName" | shasum -a 256 -c >/dev/null 2>&1; then + distributionSha256Result=true + fi + else + echo "Checksum validation was requested but neither 'sha256sum' or 'shasum' are available." >&2 + echo "Please install either command, or disable validation by removing 'distributionSha256Sum' from your maven-wrapper.properties." >&2 + exit 1 + fi + if [ $distributionSha256Result = false ]; then + echo "Error: Failed to validate Maven distribution SHA-256, your Maven distribution might be compromised." >&2 + echo "If you updated your Maven version, you need to update the specified distributionSha256Sum property." >&2 + exit 1 + fi +fi + +# unzip and move +if command -v unzip >/dev/null; then + unzip ${__MVNW_QUIET_UNZIP:+"$__MVNW_QUIET_UNZIP"} "$TMP_DOWNLOAD_DIR/$distributionUrlName" -d "$TMP_DOWNLOAD_DIR" || die "failed to unzip" +else + tar xzf${__MVNW_QUIET_TAR:+"$__MVNW_QUIET_TAR"} "$TMP_DOWNLOAD_DIR/$distributionUrlName" -C "$TMP_DOWNLOAD_DIR" || die "failed to untar" +fi + +# Find the actual extracted directory name (handles snapshots where filename != directory name) +actualDistributionDir="" + +# First try the expected directory name (for regular distributions) +if [ -d "$TMP_DOWNLOAD_DIR/$distributionUrlNameMain" ]; then + if [ -f "$TMP_DOWNLOAD_DIR/$distributionUrlNameMain/bin/$MVN_CMD" ]; then + actualDistributionDir="$distributionUrlNameMain" + fi +fi + +# If not found, search for any directory with the Maven executable (for snapshots) +if [ -z "$actualDistributionDir" ]; then + # enable globbing to iterate over items + set +f + for dir in "$TMP_DOWNLOAD_DIR"/*; do + if [ -d "$dir" ]; then + if [ -f "$dir/bin/$MVN_CMD" ]; then + actualDistributionDir="$(basename "$dir")" + break + fi + fi + done + set -f +fi + +if [ -z "$actualDistributionDir" ]; then + verbose "Contents of $TMP_DOWNLOAD_DIR:" + verbose "$(ls -la "$TMP_DOWNLOAD_DIR")" + die "Could not find Maven distribution directory in extracted archive" +fi + +verbose "Found extracted Maven distribution directory: $actualDistributionDir" +printf %s\\n "$distributionUrl" >"$TMP_DOWNLOAD_DIR/$actualDistributionDir/mvnw.url" +mv -- "$TMP_DOWNLOAD_DIR/$actualDistributionDir" "$MAVEN_HOME" || [ -d "$MAVEN_HOME" ] || die "fail to move MAVEN_HOME" + +clean || : +exec_maven "$@" diff --git a/products/mvnw.cmd b/products/mvnw.cmd new file mode 100644 index 00000000..92450f93 --- /dev/null +++ b/products/mvnw.cmd @@ -0,0 +1,189 @@ +<# : batch portion +@REM ---------------------------------------------------------------------------- +@REM Licensed to the Apache Software Foundation (ASF) under one +@REM or more contributor license agreements. See the NOTICE file +@REM distributed with this work for additional information +@REM regarding copyright ownership. The ASF licenses this file +@REM to you under the Apache License, Version 2.0 (the +@REM "License"); you may not use this file except in compliance +@REM with the License. You may obtain a copy of the License at +@REM +@REM http://www.apache.org/licenses/LICENSE-2.0 +@REM +@REM Unless required by applicable law or agreed to in writing, +@REM software distributed under the License is distributed on an +@REM "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +@REM KIND, either express or implied. See the License for the +@REM specific language governing permissions and limitations +@REM under the License. +@REM ---------------------------------------------------------------------------- + +@REM ---------------------------------------------------------------------------- +@REM Apache Maven Wrapper startup batch script, version 3.3.4 +@REM +@REM Optional ENV vars +@REM MVNW_REPOURL - repo url base for downloading maven distribution +@REM MVNW_USERNAME/MVNW_PASSWORD - user and password for downloading maven +@REM MVNW_VERBOSE - true: enable verbose log; others: silence the output +@REM ---------------------------------------------------------------------------- + +@IF "%__MVNW_ARG0_NAME__%"=="" (SET __MVNW_ARG0_NAME__=%~nx0) +@SET __MVNW_CMD__= +@SET __MVNW_ERROR__= +@SET __MVNW_PSMODULEP_SAVE=%PSModulePath% +@SET PSModulePath= +@FOR /F "usebackq tokens=1* delims==" %%A IN (`powershell -noprofile "& {$scriptDir='%~dp0'; $script='%__MVNW_ARG0_NAME__%'; icm -ScriptBlock ([Scriptblock]::Create((Get-Content -Raw '%~f0'))) -NoNewScope}"`) DO @( + IF "%%A"=="MVN_CMD" (set __MVNW_CMD__=%%B) ELSE IF "%%B"=="" (echo %%A) ELSE (echo %%A=%%B) +) +@SET PSModulePath=%__MVNW_PSMODULEP_SAVE% +@SET __MVNW_PSMODULEP_SAVE= +@SET __MVNW_ARG0_NAME__= +@SET MVNW_USERNAME= +@SET MVNW_PASSWORD= +@IF NOT "%__MVNW_CMD__%"=="" ("%__MVNW_CMD__%" %*) +@echo Cannot start maven from wrapper >&2 && exit /b 1 +@GOTO :EOF +: end batch / begin powershell #> + +$ErrorActionPreference = "Stop" +if ($env:MVNW_VERBOSE -eq "true") { + $VerbosePreference = "Continue" +} + +# calculate distributionUrl, requires .mvn/wrapper/maven-wrapper.properties +$distributionUrl = (Get-Content -Raw "$scriptDir/.mvn/wrapper/maven-wrapper.properties" | ConvertFrom-StringData).distributionUrl +if (!$distributionUrl) { + Write-Error "cannot read distributionUrl property in $scriptDir/.mvn/wrapper/maven-wrapper.properties" +} + +switch -wildcard -casesensitive ( $($distributionUrl -replace '^.*/','') ) { + "maven-mvnd-*" { + $USE_MVND = $true + $distributionUrl = $distributionUrl -replace '-bin\.[^.]*$',"-windows-amd64.zip" + $MVN_CMD = "mvnd.cmd" + break + } + default { + $USE_MVND = $false + $MVN_CMD = $script -replace '^mvnw','mvn' + break + } +} + +# apply MVNW_REPOURL and calculate MAVEN_HOME +# maven home pattern: ~/.m2/wrapper/dists/{apache-maven-,maven-mvnd--}/ +if ($env:MVNW_REPOURL) { + $MVNW_REPO_PATTERN = if ($USE_MVND -eq $False) { "/org/apache/maven/" } else { "/maven/mvnd/" } + $distributionUrl = "$env:MVNW_REPOURL$MVNW_REPO_PATTERN$($distributionUrl -replace "^.*$MVNW_REPO_PATTERN",'')" +} +$distributionUrlName = $distributionUrl -replace '^.*/','' +$distributionUrlNameMain = $distributionUrlName -replace '\.[^.]*$','' -replace '-bin$','' + +$MAVEN_M2_PATH = "$HOME/.m2" +if ($env:MAVEN_USER_HOME) { + $MAVEN_M2_PATH = "$env:MAVEN_USER_HOME" +} + +if (-not (Test-Path -Path $MAVEN_M2_PATH)) { + New-Item -Path $MAVEN_M2_PATH -ItemType Directory | Out-Null +} + +$MAVEN_WRAPPER_DISTS = $null +if ((Get-Item $MAVEN_M2_PATH).Target[0] -eq $null) { + $MAVEN_WRAPPER_DISTS = "$MAVEN_M2_PATH/wrapper/dists" +} else { + $MAVEN_WRAPPER_DISTS = (Get-Item $MAVEN_M2_PATH).Target[0] + "/wrapper/dists" +} + +$MAVEN_HOME_PARENT = "$MAVEN_WRAPPER_DISTS/$distributionUrlNameMain" +$MAVEN_HOME_NAME = ([System.Security.Cryptography.SHA256]::Create().ComputeHash([byte[]][char[]]$distributionUrl) | ForEach-Object {$_.ToString("x2")}) -join '' +$MAVEN_HOME = "$MAVEN_HOME_PARENT/$MAVEN_HOME_NAME" + +if (Test-Path -Path "$MAVEN_HOME" -PathType Container) { + Write-Verbose "found existing MAVEN_HOME at $MAVEN_HOME" + Write-Output "MVN_CMD=$MAVEN_HOME/bin/$MVN_CMD" + exit $? +} + +if (! $distributionUrlNameMain -or ($distributionUrlName -eq $distributionUrlNameMain)) { + Write-Error "distributionUrl is not valid, must end with *-bin.zip, but found $distributionUrl" +} + +# prepare tmp dir +$TMP_DOWNLOAD_DIR_HOLDER = New-TemporaryFile +$TMP_DOWNLOAD_DIR = New-Item -Itemtype Directory -Path "$TMP_DOWNLOAD_DIR_HOLDER.dir" +$TMP_DOWNLOAD_DIR_HOLDER.Delete() | Out-Null +trap { + if ($TMP_DOWNLOAD_DIR.Exists) { + try { Remove-Item $TMP_DOWNLOAD_DIR -Recurse -Force | Out-Null } + catch { Write-Warning "Cannot remove $TMP_DOWNLOAD_DIR" } + } +} + +New-Item -Itemtype Directory -Path "$MAVEN_HOME_PARENT" -Force | Out-Null + +# Download and Install Apache Maven +Write-Verbose "Couldn't find MAVEN_HOME, downloading and installing it ..." +Write-Verbose "Downloading from: $distributionUrl" +Write-Verbose "Downloading to: $TMP_DOWNLOAD_DIR/$distributionUrlName" + +$webclient = New-Object System.Net.WebClient +if ($env:MVNW_USERNAME -and $env:MVNW_PASSWORD) { + $webclient.Credentials = New-Object System.Net.NetworkCredential($env:MVNW_USERNAME, $env:MVNW_PASSWORD) +} +[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 +$webclient.DownloadFile($distributionUrl, "$TMP_DOWNLOAD_DIR/$distributionUrlName") | Out-Null + +# If specified, validate the SHA-256 sum of the Maven distribution zip file +$distributionSha256Sum = (Get-Content -Raw "$scriptDir/.mvn/wrapper/maven-wrapper.properties" | ConvertFrom-StringData).distributionSha256Sum +if ($distributionSha256Sum) { + if ($USE_MVND) { + Write-Error "Checksum validation is not supported for maven-mvnd. `nPlease disable validation by removing 'distributionSha256Sum' from your maven-wrapper.properties." + } + Import-Module $PSHOME\Modules\Microsoft.PowerShell.Utility -Function Get-FileHash + if ((Get-FileHash "$TMP_DOWNLOAD_DIR/$distributionUrlName" -Algorithm SHA256).Hash.ToLower() -ne $distributionSha256Sum) { + Write-Error "Error: Failed to validate Maven distribution SHA-256, your Maven distribution might be compromised. If you updated your Maven version, you need to update the specified distributionSha256Sum property." + } +} + +# unzip and move +Expand-Archive "$TMP_DOWNLOAD_DIR/$distributionUrlName" -DestinationPath "$TMP_DOWNLOAD_DIR" | Out-Null + +# Find the actual extracted directory name (handles snapshots where filename != directory name) +$actualDistributionDir = "" + +# First try the expected directory name (for regular distributions) +$expectedPath = Join-Path "$TMP_DOWNLOAD_DIR" "$distributionUrlNameMain" +$expectedMvnPath = Join-Path "$expectedPath" "bin/$MVN_CMD" +if ((Test-Path -Path $expectedPath -PathType Container) -and (Test-Path -Path $expectedMvnPath -PathType Leaf)) { + $actualDistributionDir = $distributionUrlNameMain +} + +# If not found, search for any directory with the Maven executable (for snapshots) +if (!$actualDistributionDir) { + Get-ChildItem -Path "$TMP_DOWNLOAD_DIR" -Directory | ForEach-Object { + $testPath = Join-Path $_.FullName "bin/$MVN_CMD" + if (Test-Path -Path $testPath -PathType Leaf) { + $actualDistributionDir = $_.Name + } + } +} + +if (!$actualDistributionDir) { + Write-Error "Could not find Maven distribution directory in extracted archive" +} + +Write-Verbose "Found extracted Maven distribution directory: $actualDistributionDir" +Rename-Item -Path "$TMP_DOWNLOAD_DIR/$actualDistributionDir" -NewName $MAVEN_HOME_NAME | Out-Null +try { + Move-Item -Path "$TMP_DOWNLOAD_DIR/$MAVEN_HOME_NAME" -Destination $MAVEN_HOME_PARENT | Out-Null +} catch { + if (! (Test-Path -Path "$MAVEN_HOME" -PathType Container)) { + Write-Error "fail to move MAVEN_HOME" + } +} finally { + try { Remove-Item $TMP_DOWNLOAD_DIR -Recurse -Force | Out-Null } + catch { Write-Warning "Cannot remove $TMP_DOWNLOAD_DIR" } +} + +Write-Output "MVN_CMD=$MAVEN_HOME/bin/$MVN_CMD" diff --git a/products/pom.xml b/products/pom.xml new file mode 100644 index 00000000..6f49910e --- /dev/null +++ b/products/pom.xml @@ -0,0 +1,68 @@ + + + 4.0.0 + + org.springframework.boot + spring-boot-starter-parent + 3.5.12 + + + com.danivelasco + products + 0.0.1-SNAPSHOT + + + + + + + + + + + + + + + + + 21 + + + + org.springframework.boot + spring-boot-starter-webflux + + + + org.springframework.boot + spring-boot-starter-test + test + + + io.projectreactor + reactor-test + test + + + + org.springframework.boot + spring-boot-starter-cache + + + com.github.ben-manes.caffeine + caffeine + + + + + + + org.springframework.boot + spring-boot-maven-plugin + + + + + diff --git a/products/src/main/java/com/danivelasco/products/ProductsApplication.java b/products/src/main/java/com/danivelasco/products/ProductsApplication.java new file mode 100644 index 00000000..d5a609a7 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/ProductsApplication.java @@ -0,0 +1,13 @@ +package com.danivelasco.products; + +import org.springframework.boot.SpringApplication; +import org.springframework.boot.autoconfigure.SpringBootApplication; + +@SpringBootApplication +public class ProductsApplication { + + public static void main(String[] args) { + SpringApplication.run(ProductsApplication.class, args); + } + +} diff --git a/products/src/main/java/com/danivelasco/products/client/ProductApiClient.java b/products/src/main/java/com/danivelasco/products/client/ProductApiClient.java new file mode 100644 index 00000000..a5ff8751 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/client/ProductApiClient.java @@ -0,0 +1,13 @@ +package com.danivelasco.products.client; + +import com.danivelasco.products.dto.ProductResponse; +import reactor.core.publisher.Mono; + +import java.util.List; + +public interface ProductApiClient { + + Mono> getSimilarProductIds(String productId); + + Mono getProductDetail(String productId); +} diff --git a/products/src/main/java/com/danivelasco/products/client/ProductApiClientImpl.java b/products/src/main/java/com/danivelasco/products/client/ProductApiClientImpl.java new file mode 100644 index 00000000..18e0f327 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/client/ProductApiClientImpl.java @@ -0,0 +1,40 @@ +package com.danivelasco.products.client; + +import com.danivelasco.products.dto.ProductResponse; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.core.ParameterizedTypeReference; +import org.springframework.stereotype.Component; +import org.springframework.web.reactive.function.client.WebClient; +import reactor.core.publisher.Mono; + +import java.util.List; + +@Component +public class ProductApiClientImpl implements ProductApiClient { + + private static final Logger log = LoggerFactory.getLogger(ProductApiClientImpl.class); + + private final WebClient productApiWebClient; + + public ProductApiClientImpl(WebClient productApiWebClient) { + this.productApiWebClient = productApiWebClient; + } + + @Override + public Mono> getSimilarProductIds(String productId) { + return productApiWebClient.get() + .uri("/product/{productId}/similarids", productId) + .retrieve() + .bodyToMono(new ParameterizedTypeReference>() { + }); + } + + @Override + public Mono getProductDetail(String productId) { + return productApiWebClient.get() + .uri("/product/{productId}", productId) + .retrieve() + .bodyToMono(ProductResponse.class); + } +} diff --git a/products/src/main/java/com/danivelasco/products/config/CacheConfig.java b/products/src/main/java/com/danivelasco/products/config/CacheConfig.java new file mode 100644 index 00000000..63a7dadb --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/config/CacheConfig.java @@ -0,0 +1,27 @@ +package com.danivelasco.products.config; + +import com.github.benmanes.caffeine.cache.Caffeine; +import org.springframework.cache.CacheManager; +import org.springframework.cache.annotation.EnableCaching; +import org.springframework.cache.caffeine.CaffeineCacheManager; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; + +import java.util.concurrent.TimeUnit; + +@Configuration +@EnableCaching +public class CacheConfig { + + @Bean + public Caffeine caffeineConfig() { + return Caffeine.newBuilder().expireAfterWrite(3, TimeUnit.MINUTES).maximumSize(1000); + } + + @Bean + public CacheManager cacheManager(Caffeine caffeine) { + CaffeineCacheManager caffeineCacheManager = new CaffeineCacheManager("similar_products_full"); + caffeineCacheManager.setCaffeine(caffeine); + return caffeineCacheManager; + } +} diff --git a/products/src/main/java/com/danivelasco/products/config/RestClientConfig.java b/products/src/main/java/com/danivelasco/products/config/RestClientConfig.java new file mode 100644 index 00000000..4f3e13cd --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/config/RestClientConfig.java @@ -0,0 +1,31 @@ +package com.danivelasco.products.config; + +import io.netty.channel.ChannelOption; +import org.springframework.beans.factory.annotation.Value; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.http.client.reactive.ReactorClientHttpConnector; +import org.springframework.web.reactive.function.client.WebClient; +import reactor.netty.http.client.HttpClient; +import reactor.netty.resources.ConnectionProvider; + +@Configuration +public class RestClientConfig { + + @Bean + public WebClient productApiWebClient( + @Value("${external.products-api.base-url}") String baseUrl, + @Value("${external.products-api.timeouts.connect-ms}") int connectTimeout + ) { + ConnectionProvider provider = ConnectionProvider.builder("product-api-pool") + .maxConnections(200) + .build(); + + HttpClient httpClient = HttpClient.create(provider).option(ChannelOption.CONNECT_TIMEOUT_MILLIS, connectTimeout); + + return WebClient.builder() + .baseUrl(baseUrl) + .clientConnector(new ReactorClientHttpConnector(httpClient)) + .build(); + } +} diff --git a/products/src/main/java/com/danivelasco/products/controller/ProductController.java b/products/src/main/java/com/danivelasco/products/controller/ProductController.java new file mode 100644 index 00000000..07f8e1d1 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/controller/ProductController.java @@ -0,0 +1,30 @@ +package com.danivelasco.products.controller; + +import com.danivelasco.products.dto.ProductDetailsResponse; +import com.danivelasco.products.dto.ProductResponse; +import com.danivelasco.products.service.SimilarProductService; +import org.springframework.http.ResponseEntity; +import org.springframework.web.bind.annotation.GetMapping; +import org.springframework.web.bind.annotation.PathVariable; +import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RestController; +import reactor.core.publisher.Mono; + +import java.util.List; + +@RestController +@RequestMapping("/product") +public class ProductController { + + private final SimilarProductService similarProductService; + + public ProductController(SimilarProductService similarProductService) { + this.similarProductService = similarProductService; + } + + @GetMapping("/{productId}/similar") + public Mono> getSimilarProducts(@PathVariable String productId) { + return this.similarProductService.getSimilarProducts(productId) + .map(ResponseEntity::ok); + } +} diff --git a/products/src/main/java/com/danivelasco/products/dto/ProductDetailFailure.java b/products/src/main/java/com/danivelasco/products/dto/ProductDetailFailure.java new file mode 100644 index 00000000..40ec4d35 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/dto/ProductDetailFailure.java @@ -0,0 +1,4 @@ +package com.danivelasco.products.dto; + +public record ProductDetailFailure(String productId, int status) { +} diff --git a/products/src/main/java/com/danivelasco/products/dto/ProductDetailResult.java b/products/src/main/java/com/danivelasco/products/dto/ProductDetailResult.java new file mode 100644 index 00000000..d20a4678 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/dto/ProductDetailResult.java @@ -0,0 +1,18 @@ +package com.danivelasco.products.dto; + +public record ProductDetailResult( + ProductResponse product, + ProductDetailFailure failure +) { + public static ProductDetailResult success(ProductResponse product) { + return new ProductDetailResult(product, null); + } + + public static ProductDetailResult failure(ProductDetailFailure failure) { + return new ProductDetailResult(null, failure); + } + + public boolean isSuccess() { + return product != null; + } +} diff --git a/products/src/main/java/com/danivelasco/products/dto/ProductDetailsResponse.java b/products/src/main/java/com/danivelasco/products/dto/ProductDetailsResponse.java new file mode 100644 index 00000000..75d3aa86 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/dto/ProductDetailsResponse.java @@ -0,0 +1,8 @@ +package com.danivelasco.products.dto; + +import java.util.List; + +public record ProductDetailsResponse( + List products, + List failures) { +} diff --git a/products/src/main/java/com/danivelasco/products/dto/ProductResponse.java b/products/src/main/java/com/danivelasco/products/dto/ProductResponse.java new file mode 100644 index 00000000..da0488e2 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/dto/ProductResponse.java @@ -0,0 +1,9 @@ +package com.danivelasco.products.dto; + +public record ProductResponse( + String id, + String name, + double price, + boolean availability +) { +} diff --git a/products/src/main/java/com/danivelasco/products/exception/ErrorResponse.java b/products/src/main/java/com/danivelasco/products/exception/ErrorResponse.java new file mode 100644 index 00000000..9bd0f872 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/exception/ErrorResponse.java @@ -0,0 +1,4 @@ +package com.danivelasco.products.exception; + +public record ErrorResponse (String message) { +} diff --git a/products/src/main/java/com/danivelasco/products/exception/GlobalException.java b/products/src/main/java/com/danivelasco/products/exception/GlobalException.java new file mode 100644 index 00000000..d90a6598 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/exception/GlobalException.java @@ -0,0 +1,17 @@ +package com.danivelasco.products.exception; + +import org.springframework.http.HttpStatus; + +public class GlobalException extends RuntimeException { + + private final HttpStatus httpStatus; + + public GlobalException(String message, HttpStatus httpStatus) { + super(message); + this.httpStatus = httpStatus; + } + + public HttpStatus getHttpStatus() { + return httpStatus; + } +} diff --git a/products/src/main/java/com/danivelasco/products/exception/GlobalExceptionHandler.java b/products/src/main/java/com/danivelasco/products/exception/GlobalExceptionHandler.java new file mode 100644 index 00000000..60b984b3 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/exception/GlobalExceptionHandler.java @@ -0,0 +1,30 @@ +package com.danivelasco.products.exception; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.http.HttpStatus; +import org.springframework.http.ResponseEntity; +import org.springframework.web.bind.annotation.ExceptionHandler; +import org.springframework.web.bind.annotation.RestControllerAdvice; + +@RestControllerAdvice +public class GlobalExceptionHandler { + + private static final Logger log = LoggerFactory.getLogger(GlobalExceptionHandler.class); + + @ExceptionHandler(GlobalException.class) + public ResponseEntity handleGlobalException(GlobalException ex) { + ErrorResponse errorResponse = new ErrorResponse(ex.getMessage()); + + return ResponseEntity.status(ex.getHttpStatus()).body(errorResponse); + } + + @ExceptionHandler(Exception.class) + public ResponseEntity handleUnexpectedException(Exception ex) { + ErrorResponse errorResponse = new ErrorResponse("Unexpected error"); + + log.error("Se ha producido un error: ", ex); + + return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(errorResponse); + } +} diff --git a/products/src/main/java/com/danivelasco/products/service/SimilarProductService.java b/products/src/main/java/com/danivelasco/products/service/SimilarProductService.java new file mode 100644 index 00000000..fb60c6c0 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/service/SimilarProductService.java @@ -0,0 +1,13 @@ +package com.danivelasco.products.service; + +import com.danivelasco.products.dto.ProductDetailsResponse; +import com.danivelasco.products.dto.ProductResponse; +import reactor.core.publisher.Mono; + +import java.util.List; + +public interface SimilarProductService { + + Mono getSimilarProducts(String productId); + +} diff --git a/products/src/main/java/com/danivelasco/products/service/SimilarProductServiceImpl.java b/products/src/main/java/com/danivelasco/products/service/SimilarProductServiceImpl.java new file mode 100644 index 00000000..94209913 --- /dev/null +++ b/products/src/main/java/com/danivelasco/products/service/SimilarProductServiceImpl.java @@ -0,0 +1,91 @@ +package com.danivelasco.products.service; + +import com.danivelasco.products.client.ProductApiClient; +import com.danivelasco.products.dto.ProductDetailFailure; +import com.danivelasco.products.dto.ProductDetailResult; +import com.danivelasco.products.dto.ProductDetailsResponse; +import com.danivelasco.products.dto.ProductResponse; +import com.danivelasco.products.exception.GlobalException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.cache.Cache; +import org.springframework.cache.CacheManager; +import org.springframework.http.HttpStatus; +import org.springframework.stereotype.Service; +import org.springframework.web.reactive.function.client.WebClientResponseException; +import reactor.core.publisher.Flux; +import reactor.core.publisher.Mono; + +import java.time.Duration; +import java.util.List; + +@Service +public class SimilarProductServiceImpl implements SimilarProductService { + + private static final Logger log = LoggerFactory.getLogger(SimilarProductServiceImpl.class); + private final ProductApiClient productApiClient; + private final CacheManager cacheManager; + + public SimilarProductServiceImpl(ProductApiClient productApiClient, CacheManager cacheManager) { + this.productApiClient = productApiClient; + this.cacheManager = cacheManager; + } + + @Override + public Mono getSimilarProducts(String productId) { + Cache cache = cacheManager.getCache("similar_products_full"); + + if (cache != null) { + ProductDetailsResponse cachedValue = cache.get(productId, ProductDetailsResponse.class); + + if (cachedValue != null) { + return Mono.just(cachedValue); + } + + } + + return productApiClient.getSimilarProductIds(productId) + .onErrorMap(WebClientResponseException.NotFound.class, + ex -> { + log.info("Not Found {}", productId); + return new GlobalException("No similar products found", HttpStatus.NOT_FOUND); + }) + .flatMapMany(Flux::fromIterable) + .flatMap(this::getProductDetailResult, 8) + .collectList() + .map(results -> { + List products = results.stream() + .filter(ProductDetailResult::isSuccess) + .map(ProductDetailResult::product) + .toList(); + + List failures = results.stream() + .filter(result -> !result.isSuccess()) + .map(ProductDetailResult::failure) + .toList(); + + return new ProductDetailsResponse(products, failures); + }) + .doOnNext(result -> { + if (cache != null) { + cache.put(productId, result); + } + }); + } + + private Mono getProductDetailResult(String productId) { + return productApiClient.getProductDetail(productId) + .timeout(Duration.ofSeconds(2)) + .map(ProductDetailResult::success) + .onErrorResume(WebClientResponseException.class, ex -> + Mono.just(ProductDetailResult.failure( + new ProductDetailFailure(productId, ex.getStatusCode().value()) + )) + ) + .onErrorResume(ex -> + Mono.just(ProductDetailResult.failure( + new ProductDetailFailure(productId, 500) + )) + ); + } +} diff --git a/products/src/main/resources/application.yaml b/products/src/main/resources/application.yaml new file mode 100644 index 00000000..f2d756a9 --- /dev/null +++ b/products/src/main/resources/application.yaml @@ -0,0 +1,15 @@ +spring: + application: + name: products +server: + port: 5000 + tomcat: + threads: + max: 200 + accept-count: 200 + +external: + products-api: + base-url: http://localhost:3001 + timeouts: + connect-ms: 300 diff --git a/products/src/test/java/com/danivelasco/products/ProductsApplicationTests.java b/products/src/test/java/com/danivelasco/products/ProductsApplicationTests.java new file mode 100644 index 00000000..292c227c --- /dev/null +++ b/products/src/test/java/com/danivelasco/products/ProductsApplicationTests.java @@ -0,0 +1,13 @@ +package com.danivelasco.products; + +import org.junit.jupiter.api.Test; +import org.springframework.boot.test.context.SpringBootTest; + +@SpringBootTest +class ProductsApplicationTests { + + @Test + void contextLoads() { + } + +} diff --git a/products/src/test/java/com/danivelasco/products/client/ProductApiClientImplTest.java b/products/src/test/java/com/danivelasco/products/client/ProductApiClientImplTest.java new file mode 100644 index 00000000..17d04a16 --- /dev/null +++ b/products/src/test/java/com/danivelasco/products/client/ProductApiClientImplTest.java @@ -0,0 +1,16 @@ +package com.danivelasco.products.client; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.*; + +class ProductApiClientImplTest { + + @Test + void getSimilarProductIds() { + } + + @Test + void getProductDetail() { + } +} \ No newline at end of file diff --git a/products/src/test/java/com/danivelasco/products/controller/ProductControllerTest.java b/products/src/test/java/com/danivelasco/products/controller/ProductControllerTest.java new file mode 100644 index 00000000..d25120a0 --- /dev/null +++ b/products/src/test/java/com/danivelasco/products/controller/ProductControllerTest.java @@ -0,0 +1,12 @@ +package com.danivelasco.products.controller; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.*; + +class ProductControllerTest { + + @Test + void getSimilarProducts() { + } +} \ No newline at end of file diff --git a/products/src/test/java/com/danivelasco/products/service/SimilarProductServiceImplTest.java b/products/src/test/java/com/danivelasco/products/service/SimilarProductServiceImplTest.java new file mode 100644 index 00000000..98e51e15 --- /dev/null +++ b/products/src/test/java/com/danivelasco/products/service/SimilarProductServiceImplTest.java @@ -0,0 +1,12 @@ +package com.danivelasco.products.service; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.*; + +class SimilarProductServiceImplTest { + + @Test + void getSimilarProducts() { + } +} \ No newline at end of file From 5a35f73cab82819e59b8a67326dcbc92ee01ba35 Mon Sep 17 00:00:00 2001 From: Dani Date: Thu, 26 Mar 2026 15:28:12 +0100 Subject: [PATCH 2/2] Backend Dev Test solution --- products/pom.xml | 10 ++ .../products/client/ProductApiClient.java | 8 ++ .../products/client/ProductApiClientImpl.java | 28 +++- .../products/config/CacheConfig.java | 31 ++++- .../products/config/RestClientConfig.java | 32 ++++- .../controller/ProductController.java | 18 ++- .../exception/GlobalExceptionHandler.java | 9 +- .../service/SimilarProductServiceImpl.java | 53 ++++++-- .../client/ProductApiClientImplTest.java | 72 +++++++++- .../controller/ProductControllerTest.java | 39 +++++- .../SimilarProductServiceImplTest.java | 127 +++++++++++++++++- 11 files changed, 399 insertions(+), 28 deletions(-) diff --git a/products/pom.xml b/products/pom.xml index 6f49910e..8a2865bc 100644 --- a/products/pom.xml +++ b/products/pom.xml @@ -62,6 +62,16 @@ org.springframework.boot spring-boot-maven-plugin + + org.apache.maven.plugins + maven-surefire-plugin + 3.2.5 + + + -javaagent:${settings.localRepository}/net/bytebuddy/byte-buddy-agent/1.17.8/byte-buddy-agent-1.17.8.jar + + + diff --git a/products/src/main/java/com/danivelasco/products/client/ProductApiClient.java b/products/src/main/java/com/danivelasco/products/client/ProductApiClient.java index a5ff8751..8b14e765 100644 --- a/products/src/main/java/com/danivelasco/products/client/ProductApiClient.java +++ b/products/src/main/java/com/danivelasco/products/client/ProductApiClient.java @@ -5,6 +5,14 @@ import java.util.List; +/** + * Client abstraction for external product API. + * + *

This layer decouples the service logic from the HTTP client implementation, + * making the system easier to test, maintain and evolve. + * + *

It also centralizes external communication concerns (URLs, serialization, etc.). + */ public interface ProductApiClient { Mono> getSimilarProductIds(String productId); diff --git a/products/src/main/java/com/danivelasco/products/client/ProductApiClientImpl.java b/products/src/main/java/com/danivelasco/products/client/ProductApiClientImpl.java index 18e0f327..baf8b0c9 100644 --- a/products/src/main/java/com/danivelasco/products/client/ProductApiClientImpl.java +++ b/products/src/main/java/com/danivelasco/products/client/ProductApiClientImpl.java @@ -1,8 +1,6 @@ package com.danivelasco.products.client; import com.danivelasco.products.dto.ProductResponse; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import org.springframework.core.ParameterizedTypeReference; import org.springframework.stereotype.Component; import org.springframework.web.reactive.function.client.WebClient; @@ -10,26 +8,44 @@ import java.util.List; +/** + * Implementation of ProductApiClient that communicates with the external products API. + * Uses Spring WebClient to perform non-blocking HTTP requests. + */ @Component public class ProductApiClientImpl implements ProductApiClient { - private static final Logger log = LoggerFactory.getLogger(ProductApiClientImpl.class); - private final WebClient productApiWebClient; + /** + * Constructor. + * + * @param productApiWebClient configured WebClient for external API calls + */ public ProductApiClientImpl(WebClient productApiWebClient) { this.productApiWebClient = productApiWebClient; } + /** + * Retrieves IDs of similar products for a given product. + * + * @param productId product identifier + * @return Mono emitting a list of similar product IDs + */ @Override public Mono> getSimilarProductIds(String productId) { return productApiWebClient.get() .uri("/product/{productId}/similarids", productId) .retrieve() - .bodyToMono(new ParameterizedTypeReference>() { - }); + .bodyToMono(new ParameterizedTypeReference<>() {}); } + /** + * Retrieves detailed information of a product. + * + * @param productId product identifier + * @return Mono emitting product details + */ @Override public Mono getProductDetail(String productId) { return productApiWebClient.get() diff --git a/products/src/main/java/com/danivelasco/products/config/CacheConfig.java b/products/src/main/java/com/danivelasco/products/config/CacheConfig.java index 63a7dadb..0864223a 100644 --- a/products/src/main/java/com/danivelasco/products/config/CacheConfig.java +++ b/products/src/main/java/com/danivelasco/products/config/CacheConfig.java @@ -9,15 +9,44 @@ import java.util.concurrent.TimeUnit; +/** + * Configuration class for application caching. + * + *

We use Caffeine as an in-memory cache due to: + *

    + *
  • High performance (near optimal hit latency)
    • + *
  • Low overhead compared to distributed caches
    • + *
  • Built-in eviction policies (size + time based)
    • + *
+ * + *

This cache is especially useful for reducing repeated calls to the external + * products API when the same productId is requested multiple times in a short period. + * + *

Trade-off: data may become slightly stale (max 3 minutes), but this is acceptable + * given the performance gain and the nature of the use case. + */ @Configuration @EnableCaching public class CacheConfig { + /** + * Defines the Caffeine cache configuration. + * + * @return configured Caffeine instance + */ @Bean public Caffeine caffeineConfig() { - return Caffeine.newBuilder().expireAfterWrite(3, TimeUnit.MINUTES).maximumSize(1000); + return Caffeine.newBuilder() + .expireAfterWrite(3, TimeUnit.MINUTES) + .maximumSize(2_000); } + /** + * Creates the cache manager with a specific cache for similar products. + * + * @param caffeine caffeine configuration + * @return CacheManager instance + */ @Bean public CacheManager cacheManager(Caffeine caffeine) { CaffeineCacheManager caffeineCacheManager = new CaffeineCacheManager("similar_products_full"); diff --git a/products/src/main/java/com/danivelasco/products/config/RestClientConfig.java b/products/src/main/java/com/danivelasco/products/config/RestClientConfig.java index 4f3e13cd..440dbd93 100644 --- a/products/src/main/java/com/danivelasco/products/config/RestClientConfig.java +++ b/products/src/main/java/com/danivelasco/products/config/RestClientConfig.java @@ -9,23 +9,51 @@ import reactor.netty.http.client.HttpClient; import reactor.netty.resources.ConnectionProvider; +/** + * Configuration for WebClient used to call external APIs. + * + *

WebClient is used instead of RestTemplate or RestClient because: + *

    + *
  • Non-blocking I/O (reactive), allowing better scalability under high concurrency
    • + *
  • Efficient resource usage (threads are not blocked waiting for I/O)
    • + *
  • Better integration with Project Reactor (Mono/Flux)
    • + *
+ * + *

A custom connection pool is configured to: + *

    + *
  • Limit the number of concurrent outbound connections
    • + *
  • Prevent uncontrolled resource usage
    • + *
  • Avoid bottlenecks under load
    • + *
+ * + *

Trade-off: requires careful tuning of pool size and concurrency to avoid saturation. + */ @Configuration public class RestClientConfig { + /** + * Creates a WebClient configured with connection pooling. + * + * @param baseUrl base URL of the external products API + * @param connectTimeout connection timeout in milliseconds + * @return configured WebClient instance + */ @Bean public WebClient productApiWebClient( @Value("${external.products-api.base-url}") String baseUrl, @Value("${external.products-api.timeouts.connect-ms}") int connectTimeout ) { ConnectionProvider provider = ConnectionProvider.builder("product-api-pool") + .pendingAcquireMaxCount(200) .maxConnections(200) .build(); - HttpClient httpClient = HttpClient.create(provider).option(ChannelOption.CONNECT_TIMEOUT_MILLIS, connectTimeout); + HttpClient httpClient = HttpClient.create(provider) + .option(ChannelOption.CONNECT_TIMEOUT_MILLIS, connectTimeout); return WebClient.builder() .baseUrl(baseUrl) .clientConnector(new ReactorClientHttpConnector(httpClient)) .build(); } -} +} \ No newline at end of file diff --git a/products/src/main/java/com/danivelasco/products/controller/ProductController.java b/products/src/main/java/com/danivelasco/products/controller/ProductController.java index 07f8e1d1..78d386f0 100644 --- a/products/src/main/java/com/danivelasco/products/controller/ProductController.java +++ b/products/src/main/java/com/danivelasco/products/controller/ProductController.java @@ -1,7 +1,6 @@ package com.danivelasco.products.controller; import com.danivelasco.products.dto.ProductDetailsResponse; -import com.danivelasco.products.dto.ProductResponse; import com.danivelasco.products.service.SimilarProductService; import org.springframework.http.ResponseEntity; import org.springframework.web.bind.annotation.GetMapping; @@ -10,18 +9,31 @@ import org.springframework.web.bind.annotation.RestController; import reactor.core.publisher.Mono; -import java.util.List; - +/** + * REST controller that exposes product-related endpoints + * Provides operations to retrieve similar products based on a given product ID + */ @RestController @RequestMapping("/product") public class ProductController { private final SimilarProductService similarProductService; + /** + * Constructor for ProductController + * + * @param similarProductService service responsible for retrieving similar products + */ public ProductController(SimilarProductService similarProductService) { this.similarProductService = similarProductService; } + /** + * Retrieves similar products for a given product ID + * + * @param productId the identifier of the product + * @return a Mono containing the response with similar product details + */ @GetMapping("/{productId}/similar") public Mono> getSimilarProducts(@PathVariable String productId) { return this.similarProductService.getSimilarProducts(productId) diff --git a/products/src/main/java/com/danivelasco/products/exception/GlobalExceptionHandler.java b/products/src/main/java/com/danivelasco/products/exception/GlobalExceptionHandler.java index 60b984b3..076dad0b 100644 --- a/products/src/main/java/com/danivelasco/products/exception/GlobalExceptionHandler.java +++ b/products/src/main/java/com/danivelasco/products/exception/GlobalExceptionHandler.java @@ -14,6 +14,10 @@ public class GlobalExceptionHandler { @ExceptionHandler(GlobalException.class) public ResponseEntity handleGlobalException(GlobalException ex) { + + log.warn("Handled GlobalException - status: {}, message: {}", + ex.getHttpStatus(), ex.getMessage()); + ErrorResponse errorResponse = new ErrorResponse(ex.getMessage()); return ResponseEntity.status(ex.getHttpStatus()).body(errorResponse); @@ -21,9 +25,10 @@ public ResponseEntity handleGlobalException(GlobalException ex) { @ExceptionHandler(Exception.class) public ResponseEntity handleUnexpectedException(Exception ex) { - ErrorResponse errorResponse = new ErrorResponse("Unexpected error"); - log.error("Se ha producido un error: ", ex); + log.error("Unexpected error occurred", ex); + + ErrorResponse errorResponse = new ErrorResponse("Unexpected error"); return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(errorResponse); } diff --git a/products/src/main/java/com/danivelasco/products/service/SimilarProductServiceImpl.java b/products/src/main/java/com/danivelasco/products/service/SimilarProductServiceImpl.java index 94209913..87c76bd0 100644 --- a/products/src/main/java/com/danivelasco/products/service/SimilarProductServiceImpl.java +++ b/products/src/main/java/com/danivelasco/products/service/SimilarProductServiceImpl.java @@ -6,8 +6,6 @@ import com.danivelasco.products.dto.ProductDetailsResponse; import com.danivelasco.products.dto.ProductResponse; import com.danivelasco.products.exception.GlobalException; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; import org.springframework.cache.Cache; import org.springframework.cache.CacheManager; import org.springframework.http.HttpStatus; @@ -18,11 +16,17 @@ import java.time.Duration; import java.util.List; +import java.util.concurrent.TimeoutException; +/** + * Service implementation responsible for retrieving similar products. + *

+ * Combines multiple external API calls to build a complete response. + * Includes caching, error handling and partial failure tolerance. + */ @Service public class SimilarProductServiceImpl implements SimilarProductService { - private static final Logger log = LoggerFactory.getLogger(SimilarProductServiceImpl.class); private final ProductApiClient productApiClient; private final CacheManager cacheManager; @@ -31,6 +35,20 @@ public SimilarProductServiceImpl(ProductApiClient productApiClient, CacheManager this.cacheManager = cacheManager; } + /** + * Retrieves similar products with a resilient and performant approach. + * + *

Key design decisions: + *

    + *
  • Parallel fetching of product details using flatMap to reduce latency
    • + *
  • Controlled concurrency (flatMap with limit) to avoid overwhelming external APIs
    • + *
  • Partial failure handling: failed product calls do not break the whole response
    • + *
  • Timeout applied to each external call to prevent long blocking operations
    • + *
  • Caching applied to reduce repeated expensive calls
    • + *
+ * + *

This design prioritizes availability and performance over strict consistency. + */ @Override public Mono getSimilarProducts(String productId) { Cache cache = cacheManager.getCache("similar_products_full"); @@ -41,17 +59,24 @@ public Mono getSimilarProducts(String productId) { if (cachedValue != null) { return Mono.just(cachedValue); } - } return productApiClient.getSimilarProductIds(productId) .onErrorMap(WebClientResponseException.NotFound.class, - ex -> { - log.info("Not Found {}", productId); - return new GlobalException("No similar products found", HttpStatus.NOT_FOUND); - }) + ex -> new GlobalException("No similar products found", HttpStatus.NOT_FOUND)) + .onErrorMap(WebClientResponseException.class, + ex -> new GlobalException("Upstream service error", HttpStatus.BAD_GATEWAY)) + .onErrorMap(TimeoutException.class, + ex -> new GlobalException("Upstream timeout", HttpStatus.GATEWAY_TIMEOUT)) .flatMapMany(Flux::fromIterable) - .flatMap(this::getProductDetailResult, 8) + // Controlled concurrency: + // We limit the number of parallel calls to 4 to avoid saturating the external service + // and the WebClient connection pool. This value is intentionally conservative to + // maintain system stability under high concurrency (200 VUs). + // + // A higher value could reduce latency for individual requests, but would significantly + // increase the risk of connection pool exhaustion and degraded p95 latency. + .flatMap(this::getProductDetailResult, 4) .collectList() .map(results -> { List products = results.stream() @@ -73,10 +98,20 @@ public Mono getSimilarProducts(String productId) { }); } + /** + * Retrieves product detail safely, converting errors into failure objects. + * + * @param productId product identifier + * @return Mono with success or failure result + */ private Mono getProductDetailResult(String productId) { return productApiClient.getProductDetail(productId) + // Timeout ensures that slow upstream responses do not block the entire flow. + // This helps maintain responsiveness and avoids resource exhaustion. .timeout(Duration.ofSeconds(2)) .map(ProductDetailResult::success) + // Instead of failing the whole request, we capture individual failures + // and return partial results. This improves system resilience and user experience. .onErrorResume(WebClientResponseException.class, ex -> Mono.just(ProductDetailResult.failure( new ProductDetailFailure(productId, ex.getStatusCode().value()) diff --git a/products/src/test/java/com/danivelasco/products/client/ProductApiClientImplTest.java b/products/src/test/java/com/danivelasco/products/client/ProductApiClientImplTest.java index 17d04a16..fb789d86 100644 --- a/products/src/test/java/com/danivelasco/products/client/ProductApiClientImplTest.java +++ b/products/src/test/java/com/danivelasco/products/client/ProductApiClientImplTest.java @@ -1,16 +1,86 @@ package com.danivelasco.products.client; +import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; +import org.springframework.http.HttpHeaders; +import org.springframework.http.HttpStatus; +import org.springframework.http.MediaType; +import org.springframework.web.reactive.function.client.ClientResponse; +import org.springframework.web.reactive.function.client.ExchangeFunction; +import org.springframework.web.reactive.function.client.WebClient; +import reactor.core.publisher.Mono; +import reactor.test.StepVerifier; -import static org.junit.jupiter.api.Assertions.*; +import java.util.List; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertTrue; class ProductApiClientImplTest { + private ProductApiClientImpl productApiClient; + + @BeforeEach + void setUp() { + } + @Test void getSimilarProductIds() { + ExchangeFunction exchangeFunction = request -> { + assertEquals("/product/1/similarids", request.url().getPath()); + + return Mono.just( + ClientResponse.create(HttpStatus.OK) + .header(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE) + .body("[\"2\",\"3\",\"4\"]") + .build() + ); + }; + + WebClient webClient = WebClient.builder() + .exchangeFunction(exchangeFunction) + .build(); + + productApiClient = new ProductApiClientImpl(webClient); + + StepVerifier.create(productApiClient.getSimilarProductIds("1")) + .assertNext(ids -> assertEquals(List.of("2", "3", "4"), ids)) + .verifyComplete(); } @Test void getProductDetail() { + ExchangeFunction exchangeFunction = request -> { + assertEquals("/product/2", request.url().getPath()); + + return Mono.just( + ClientResponse.create(HttpStatus.OK) + .header(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE) + .body(""" + { + "id":"2", + "name":"Shirt", + "price":35.99, + "availability":true + } + """) + .build() + ); + }; + + WebClient webClient = WebClient.builder() + .exchangeFunction(exchangeFunction) + .build(); + + productApiClient = new ProductApiClientImpl(webClient); + + StepVerifier.create(productApiClient.getProductDetail("2")) + .assertNext(product -> { + assertEquals("2", product.id()); + assertEquals("Shirt", product.name()); + assertEquals(35.99, product.price()); + assertTrue(product.availability()); + }) + .verifyComplete(); } } \ No newline at end of file diff --git a/products/src/test/java/com/danivelasco/products/controller/ProductControllerTest.java b/products/src/test/java/com/danivelasco/products/controller/ProductControllerTest.java index d25120a0..3683b73c 100644 --- a/products/src/test/java/com/danivelasco/products/controller/ProductControllerTest.java +++ b/products/src/test/java/com/danivelasco/products/controller/ProductControllerTest.java @@ -1,12 +1,47 @@ package com.danivelasco.products.controller; +import com.danivelasco.products.dto.ProductDetailFailure; +import com.danivelasco.products.dto.ProductDetailsResponse; +import com.danivelasco.products.dto.ProductResponse; +import com.danivelasco.products.service.SimilarProductService; +import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; +import org.mockito.Mockito; +import org.springframework.http.HttpStatus; +import reactor.core.publisher.Mono; +import reactor.test.StepVerifier; -import static org.junit.jupiter.api.Assertions.*; +import java.util.List; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.mockito.Mockito.when; class ProductControllerTest { + private SimilarProductService similarProductService; + private ProductController productController; + + @BeforeEach + void setUp() { + similarProductService = Mockito.mock(SimilarProductService.class); + productController = new ProductController(similarProductService); + } + @Test - void getSimilarProducts() { + void getSimilarProducts_returnsOkResponseEntity() { + ProductResponse product = new ProductResponse("2", "Shirt", 35.99, true); + ProductDetailFailure failure = new ProductDetailFailure("3", 404); + ProductDetailsResponse serviceResponse = + new ProductDetailsResponse(List.of(product), List.of(failure)); + + when(similarProductService.getSimilarProducts("1")) + .thenReturn(Mono.just(serviceResponse)); + + StepVerifier.create(productController.getSimilarProducts("1")) + .assertNext(response -> { + assertEquals(HttpStatus.OK, response.getStatusCode()); + assertEquals(serviceResponse, response.getBody()); + }) + .verifyComplete(); } } \ No newline at end of file diff --git a/products/src/test/java/com/danivelasco/products/service/SimilarProductServiceImplTest.java b/products/src/test/java/com/danivelasco/products/service/SimilarProductServiceImplTest.java index 98e51e15..a6af2945 100644 --- a/products/src/test/java/com/danivelasco/products/service/SimilarProductServiceImplTest.java +++ b/products/src/test/java/com/danivelasco/products/service/SimilarProductServiceImplTest.java @@ -1,12 +1,135 @@ package com.danivelasco.products.service; +import com.danivelasco.products.client.ProductApiClient; +import com.danivelasco.products.dto.ProductDetailsResponse; +import com.danivelasco.products.dto.ProductResponse; +import com.danivelasco.products.exception.GlobalException; +import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; +import org.mockito.ArgumentCaptor; +import org.springframework.cache.Cache; +import org.springframework.cache.CacheManager; +import org.springframework.http.HttpHeaders; +import org.springframework.http.HttpStatus; +import org.springframework.web.reactive.function.client.WebClientResponseException; +import reactor.core.publisher.Mono; +import reactor.test.StepVerifier; -import static org.junit.jupiter.api.Assertions.*; +import java.nio.charset.StandardCharsets; +import java.util.List; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.mockito.ArgumentMatchers.anyString; +import static org.mockito.Mockito.*; class SimilarProductServiceImplTest { + private ProductApiClient productApiClient; + private Cache cache; + private SimilarProductServiceImpl similarProductService; + + @BeforeEach + void setUp() { + productApiClient = mock(ProductApiClient.class); + CacheManager cacheManager = mock(CacheManager.class); + cache = mock(Cache.class); + + when(cacheManager.getCache("similar_products_full")).thenReturn(cache); + + similarProductService = new SimilarProductServiceImpl(productApiClient, cacheManager); + } + + @Test + void getSimilarProducts_returnsCachedValue_whenExists() { + ProductDetailsResponse cachedResponse = + new ProductDetailsResponse(List.of(), List.of()); + + when(cache.get("1", ProductDetailsResponse.class)).thenReturn(cachedResponse); + + StepVerifier.create(similarProductService.getSimilarProducts("1")) + .expectNext(cachedResponse) + .verifyComplete(); + + verify(productApiClient, never()).getSimilarProductIds(anyString()); + verify(productApiClient, never()).getProductDetail(anyString()); + } + @Test - void getSimilarProducts() { + void getSimilarProducts_returnsProductsAndFailures_andCachesResult() { + ProductResponse product2 = new ProductResponse("2", "Shirt", 35.99, true); + + when(cache.get("1", ProductDetailsResponse.class)).thenReturn(null); + when(productApiClient.getSimilarProductIds("1")).thenReturn(Mono.just(List.of("2", "3"))); + + when(productApiClient.getProductDetail("2")).thenReturn(Mono.just(product2)); + when(productApiClient.getProductDetail("3")).thenReturn(Mono.error(notFoundException())); + + StepVerifier.create(similarProductService.getSimilarProducts("1")) + .assertNext(response -> { + assertEquals(1, response.products().size()); + assertEquals("2", response.products().getFirst().id()); + + assertEquals(1, response.failures().size()); + assertEquals("3", response.failures().getFirst().productId()); + assertEquals(404, response.failures().getFirst().status()); + }) + .verifyComplete(); + + ArgumentCaptor captor = + ArgumentCaptor.forClass(ProductDetailsResponse.class); + + verify(cache).put(eq("1"), captor.capture()); + + ProductDetailsResponse cachedValue = captor.getValue(); + assertEquals(1, cachedValue.products().size()); + assertEquals(1, cachedValue.failures().size()); + } + + @Test + void getSimilarProducts_throwsGlobalException_whenSimilarIdsEndpointReturns404() { + when(cache.get("1", ProductDetailsResponse.class)).thenReturn(null); + when(productApiClient.getSimilarProductIds("1")) + .thenReturn(Mono.error(notFoundException())); + + StepVerifier.create(similarProductService.getSimilarProducts("1")) + .expectErrorSatisfies(error -> { + assertEquals(GlobalException.class, error.getClass()); + GlobalException ex = (GlobalException) error; + assertEquals(HttpStatus.NOT_FOUND, ex.getHttpStatus()); + assertEquals("No similar products found", ex.getMessage()); + }) + .verify(); + + verify(productApiClient, never()).getProductDetail(anyString()); + verify(cache, never()).put(anyString(), any()); + } + + @Test + void getSimilarProducts_addsFailure500_whenProductDetailFailsWithGenericError() { + when(cache.get("1", ProductDetailsResponse.class)).thenReturn(null); + when(productApiClient.getSimilarProductIds("1")).thenReturn(Mono.just(List.of("2"))); + when(productApiClient.getProductDetail("2")) + .thenReturn(Mono.error(new RuntimeException("boom"))); + + StepVerifier.create(similarProductService.getSimilarProducts("1")) + .assertNext(response -> { + assertEquals(0, response.products().size()); + assertEquals(1, response.failures().size()); + assertEquals("2", response.failures().getFirst().productId()); + assertEquals(500, response.failures().getFirst().status()); + }) + .verifyComplete(); + + verify(cache).put(eq("1"), any(ProductDetailsResponse.class)); + } + + private WebClientResponseException.NotFound notFoundException() { + return (WebClientResponseException.NotFound) WebClientResponseException.create( + 404, + "Not Found", + HttpHeaders.EMPTY, + new byte[0], + StandardCharsets.UTF_8 + ); } } \ No newline at end of file