fix: ghostty_surface_inherited_config returns dangling working_directory pointer

[daiimus]

Summary

ghostty_surface_inherited_config (embedded.zig:1044-1061) allocates a dupeZ of the working directory via the app allocator, then returns the Options struct by value. The C header declares ghostty_surface_config_s containing const char* working_directory.

The caller receives a raw pointer to heap memory with:

• No documented ownership
• No free function
• No indication that the caller must free it

This is a memory leak if the caller doesn't free it, or a use-after-free if the caller incorrectly frees it with the wrong allocator.

Fix

Either:

1. Document the ownership and provide a ghostty_surface_config_free function.
2. Use a static/arena-allocated string with clear lifetime semantics.

Severity

MEDIUM — Memory leak per call. Not a crash but accumulates.

Source

Identified during code review of daiimus/ghostty:ios-external-backend.

[daiimus]

Verification

Confirmed — newSurfaceOptions at embedded.zig:1044 calls alloc.dupeZ() to create a heap-allocated copy of the working directory, embeds the raw [*:0]const u8 pointer in the returned Options struct, and provides no free function.

However, this is an upstream bug, not fork-specific. The exact same code exists in upstream/main:embedded.zig:920. Our fork has not modified newSurfaceOptions at all.

Recommendation

Keep the issue open but add the upstream label. This is a real memory leak but the fix belongs upstream. If we fix it in our fork, we'd diverge further from upstream for no iOS-specific reason. Worth noting in case we want to report upstream or if they fix it first.