Git doesn't build

[prokoudine]

The latest git code doesn't build on Fedora 42:

In file included from connectors/volca_sample_sdk/korg_syro_comp.c:7:
connectors/volca_sample_sdk/korg_syro_type.h:35:13: error: ‘bool’ cannot be defined via ‘typedef’
   35 | typedef int bool;
      |             ^~~~
connectors/volca_sample_sdk/korg_syro_type.h:35:13: note: ‘bool’ is a keyword with ‘-std=c23’ onwards
connectors/volca_sample_sdk/korg_syro_type.h:35:1: warning: useless type name in empty declaration
   35 | typedef int bool;
      | ^~~~~~~
make[2]: *** [Makefile:2067: connectors/volca_sample_sdk/elektroid_cli-korg_syro_comp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
mv -f connectors/.deps/elektroid_cli-sds.Tpo connectors/.deps/elektroid_cli-sds.Po
In file included from connectors/volca_sample_sdk/korg_syro_volcasample.h:4,
                 from connectors/volca_sample.c:24:
connectors/volca_sample_sdk/korg_syro_type.h:35:13: error: ‘bool’ cannot be defined via ‘typedef’
   35 | typedef int bool;
      |             ^~~~
connectors/volca_sample_sdk/korg_syro_type.h:35:13: note: ‘bool’ is a keyword with ‘-std=c23’ onwards
connectors/volca_sample_sdk/korg_syro_type.h:35:1: warning: useless type name in empty declaration
   35 | typedef int bool;
      | ^~~~~~~
make[2]: *** [Makefile:2053: connectors/elektroid_cli-volca_sample.o] Error 1
make[2]: Leaving directory '/home/alex/soft/sound/elektroid/elektroid/src'
make[1]: *** [Makefile:450: all-recursive] Error 1
make[1]: Leaving directory '/home/alex/soft/sound/elektroid/elektroid'
make: *** [Makefile:382: all] Error 2

Any additional info I can get you?

[jwakely]

This is just because GCC 15 defaults to -std=gnu23

https://gcc.gnu.org/gcc-15/porting_to.html#c23-new-keywords

[dagargo]

Thanks for pointing this out, @jwakely.

I thought I already fixed it but I didn't.

I'll fix it later today.

[dagargo]

I was aware of the issue and even had a local branch with the fix.

The reason is that the code causing the error is an external library from KORG to manage the Volca Sample via an audio link. I even created a PR in their project to address this (see korginc/volcasample#22) but never got merged. The idea was to apply the change once they merged it but it's time to apply the patch directly to Elektroid.

The solution is simply tweaking a #ifndef directive to make it like this.

#if !defined(__cplusplus) && (!defined(__STDC_VERSION__) || __STDC_VERSION__ < 202000)

I've pushed a commit containing the fix to the fix-korg-sample-sdk-c23 branch. Could you give it a try and report back, @prokoudine?

[prokoudine]

Patched src/connectors/volca_sample_sdk/korg_syro_type.h instead, and the build is successful.

[dagargo]

Branch merged in #200.

Thanks for reporting and testing this, @prokoudine!