fix: fixes from coderabbit revision

Author: eduardo-garcia18

mati/resources/verifications.py

@@ -133,20 +133,20 @@ def get_document_validation(
     ) -> Optional[DocumentScore]:
         if not document:
             return None
-        type = document.type.replace("-", "_")
+        document_type = document.type.replace("-", "_")
         is_expired = (
-            self.computed['is_document_expired']['data'][type]
+            self.computed['is_document_expired']['data'][document_type]
             if self.computed
             else False
         )
         steps = document.steps
         if is_expired:
             steps.append(
                 VerificationDocumentStep(
-                    id=f'{type}_verification',
+                    id=f'{document_type}_verification',
                     status=500,
                     error={
-                        'verification': f'Document {type} expired',
+                        'verification': f'Document {document_type} expired',
                         'code': 500,
                     },
                 )

…t_retrive_verification_invalid_govt.yaml …_retrieve_verification_invalid_govt.yamltests/resources/cassettes/test_retrive_verification_invalid_govt.yaml renamed to tests/resources/cassettes/test_retrieve_verification_invalid_govt.yaml tests/resources/cassettes/test_retrive_verification_invalid_govt.yaml renamed to tests/resources/cassettes/test_retrieve_verification_invalid_govt.yaml

@@ -82,14 +82,14 @@ def test_retrieve_dni_verification(verification_without_pol):
 
 
 @pytest.mark.vcr
-def test_retrive_verification_invalid_govt(verification_with_govt_expired):
+def test_retrieve_verification_invalid_govt(verification_with_govt_expired):
     verification = verification_with_govt_expired
     assert not verification.govt_id_validation.is_valid
     assert verification.govt_id_validation.error_codes
 
 
 @pytest.mark.vcr
-def test_retrive_verification_invalid_poa(verification_with_poa_expired):
+def test_retrieve_verification_invalid_poa(verification_with_poa_expired):
     verification = verification_with_poa_expired
     assert not verification.proof_of_residency_validation.is_valid
     assert verification.proof_of_residency_validation.error_codes