Skip to content

Commit 1612b0d

Browse files
authored
Better testing configs (#31)
* change requirements installs to a better config * linted project * forgot to install before installing test requirements * solved comments * fixed pydantic version
1 parent 9e74b95 commit 1612b0d

6 files changed

Lines changed: 30 additions & 19 deletions

File tree

.github/dependabot.yml

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,21 @@
11
version: 2
22
updates:
3+
- package-ecosystem: "github-actions"
4+
directory: "/"
5+
schedule:
6+
interval: daily
7+
time: "08:00"
8+
timezone: "America/Mexico_City"
9+
open-pull-requests-limit: 5
10+
reviewers:
11+
- "matin"
12+
313
- package-ecosystem: pip
414
directory: "/"
515
schedule:
616
interval: daily
7-
time: '11:00'
8-
open-pull-requests-limit: 10
17+
time: "08:00"
18+
timezone: "America/Mexico_City"
19+
open-pull-requests-limit: 5
20+
reviewers:
21+
- "matin"

Makefile

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,14 @@ venv:
1212
$(PYTHON) -m venv --prompt $(PROJECT) venv
1313
pip install -qU pip
1414

15-
install-test:
16-
pip install -q .[test]
15+
install:
16+
pip install -qU -r requirements.txt
17+
18+
install-test: install
19+
pip install -qU -r requirements-test.txt
1720

1821
test: clean install-test lint
19-
python setup.py test
22+
pytest
2023

2124
format:
2225
$(isort)
@@ -43,7 +46,7 @@ clean:
4346
rm -rf build
4447
rm -rf dist
4548

46-
release: clean
49+
release: test clean
4750
python setup.py sdist bdist_wheel
4851
twine upload dist/*
4952

clabe/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '1.2.3'
1+
__version__ = '1.2.4'

requirements-test.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
pytest==5.4.*
2+
pytest-cov==2.10.*
3+
black==19.10b0
4+
isort==5.0.*
5+
flake8==3.8.*
6+
mypy==0.782

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
pydantic==1.4

setup.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,6 @@
55
version = SourceFileLoader('version', 'clabe/version.py').load_module()
66

77

8-
test_requires = [
9-
'pytest==5.4.3',
10-
'pytest-cov==2.10.0',
11-
'black==19.10b0',
12-
'isort==5.0.4',
13-
'flake8==3.8.3',
14-
'mypy==0.782',
15-
]
16-
178
with open('README.md', 'r') as f:
189
long_description = f.read()
1910

@@ -31,9 +22,6 @@
3122
include_package_data=True,
3223
package_data=dict(clabe=['py.typed']),
3324
install_requires=['pydantic>=1.4,<2.0'],
34-
setup_requires=['pytest-runner'],
35-
tests_require=test_requires,
36-
extras_require=dict(test=test_requires),
3725
classifiers=[
3826
'Programming Language :: Python :: 3',
3927
'License :: OSI Approved :: MIT License',

0 commit comments

Comments
 (0)