Replies: 1 comment
-
|
Thanks for raising this for discussion, @snuxoll. @rogpeppe did some work in this space ahead of our work on CUE modules. In short (but I will let @rogpeppe expand) this change has implications deep within CUE. As an additional comment, as part of work on |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
The overlay support in cue/load is undoubtedly useful in many applications, but the design of intercepting absolute file paths causes some problems not only in usage of the overlay feature itself; but also in other places within the code (a large issue I have had myself is custom modregistries cannot just return an io.FS backed in memory, in a ZIP file, embedded with go:embed, or other virtual file system that does not have a reasonable way to implement OSRootFS to make cue/load happy).
I know #607 has been open for years, and I’m sure I’m not the only person who’s silently hung their head dealing with this - so I’m happy to contribute a patch if we can come up with a solution that makes everyone happy.
There’s a few major questions to answer here:
Alternatively, if we can simply accept anything that implements io.FS in a context do we even need to implement overlay support in cue anymore? Any user could simply implement a simple overlay (as had already been done internally) that implements io.FS themselves.
Beta Was this translation helpful? Give feedback.
All reactions