EmailInfo TemplateParameters are ignored

[avifatal]

Hi,
I think this is a bug.
I am setting the template params as the following: emailInfo.setTemplateParameters(Collections.singletonMap("name","test name"));
this is the body content emailInfo.setBody("<b>test ${name}</b>");
the email arriving is: <b>test ${name}</b> and not as expected <b>test name</b> ;

Could it be that TemplateParameters is ignored when no providing template path?

thanks

            EmailInfo emailInfo =
                    new EmailInfo(
                            customer.getEmail(),
                            "test@gmail.com",
                            "My subject",
                            "");
            emailInfo.setCaption("Subject");
            emailInfo.setFrom("myemail@gmail.com");
            emailInfo.setBodyContentType("text/html; charset=UTF-8");
            emailInfo.setBody("<b>test ${name}</b>");
            emailInfo.setTemplateParameters(Collections.singletonMap("name","test name"));
            try {

                this.emailService.sendEmail(emailInfo);
            } catch (EmailException e) {
                e.printStackTrace();
            }

[jreznot]

Hi,

it is not a bug, template parameters used only if you provide template path. Body always inserted as is.

We could improve it in the future releases, but there are no concrete plans for now.

[avifatal]

Ok. that's a little bit odd and misleading API (-:
But thank you!

[jreznot]

Will at least add JavaDoc soon and document current behaviour there

[avifatal]

Can create a pull request for this? The caption / subject should also be compiled with the object.

[jreznot]

Sure, feel free to create PR!

[avifatal]

PR: #1345