Skip to content

Upjet resources do not set observedGeneration in the Synced condition #591

@bobh66

Description

@bobh66

What happened?

upjet resources are not setting the observedGeneration in the Synced condition which causes the lastTransitionTime to be updated on every reconciliation cycle.

See crossplane/crossplane-runtime#902 for more details.

How can we reproduce it?

Create an upjet-based resource and put a watch on it. Observe that the resource is updated on every pollInterval and the only change is the lastTransitionTime in the Synced condition.

WithObservedGeneration() needs to be added to the ReconcileSuccess() conditions (and possibly others?)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions