Skip to content

add: possibility to add custom locale code; #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TeslyukTaras wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add: possibility to add custom locale code; #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/kotlin/com/crobox/sdk/testapp/ui/DemoActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.crobox.sdk.testapp.ui
import android.os.Bundle
import com.crobox.sdk.common.CurrencyCode
import com.crobox.sdk.common.LocaleCode
import com.crobox.sdk.common.DefaultLocaleCode
import com.crobox.sdk.config.CroboxConfig
import com.crobox.sdk.core.Crobox
import com.crobox.sdk.testapp.R
Expand Down Expand Up @@ -32,7 +33,7 @@ class DemoActivity : BaseActivity() {
containerId = containerId,
visitorId = UUID.randomUUID(),
currencyCode = CurrencyCode.USD,
localeCode = LocaleCode.EN_US
localeCode = LocaleCode(DefaultLocaleCode.EN_US)
)
)

Expand Down
8 changes: 7 additions & 1 deletion sdk/src/main/kotlin/com/crobox/sdk/common/LocaleCode.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@ package com.crobox.sdk.common
* - the language is lowercase, two-letter form of ISO 639-1 language codes
* - the country is uppercase, two-letter form of ISO 3166-1 Country codes
*/
enum class LocaleCode(val code: String) {

class LocaleCode(val code: String) {

// Secondary constructor that takes a DefaultLocaleCode enum
constructor(DefaultLocaleCode: DefaultLocaleCode) : this(DefaultLocaleCode.code)
}
enum class DefaultLocaleCode(val code: String) {
EN_US("en_US"),
EN_GB("en_GB"),
EN_CA("en_CA"),
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/main/kotlin/com/crobox/sdk/presenter/CroboxAPIPresenter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ internal class CroboxAPIPresenter(private val config: CroboxConfig) {

// Optional parameters
config.currencyCode?.let { parameters["cc"] = it.toString() }
config.localeCode?.let { parameters["lc"] = it.toString() }
config.localeCode?.let { parameters["lc"] = it.code }
config.userId?.let { parameters["uid"] = it }
parameters["ts"] = CroboxEncoder.toBase36(System.currentTimeMillis())
config.timezone?.let { parameters["tz"] = it }
Expand Down